[jira] [Commented] (CALCITE-4188) support EnumerableBatchNestedLoopJoin in JdbcToEnumerableConverter implement

["Stamatis Zampetakis (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CALCITE-4188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17498508#comment-17498508 ] 

Stamatis Zampetakis commented on CALCITE-4188:
----------------------------------------------

Just following up on the question of [~gavinray] in the [mailing list|https://lists.apache.org/thread/62tydrh7c1ogljv8dln3j55g9n44256z] the main point holding me back from merging this PR in master is the new APIs in {{SqlString}}. More specifically, I am a bit concerned about bringing concepts from the Rex-land to the Sql-land. Unfortunately I didn't find time to see if and how can this be avoided but leaving a comment here in case someone is able to figure things out and it further.

> support EnumerableBatchNestedLoopJoin in JdbcToEnumerableConverter implement
> ----------------------------------------------------------------------------
>
>                 Key: CALCITE-4188
>                 URL: https://issues.apache.org/jira/browse/CALCITE-4188
>             Project: Calcite
>          Issue Type: Improvement
>          Components: core
>    Affects Versions: 1.25.0
>            Reporter: JIasen Sheng
>            Priority: Major
>              Labels: pull-request-available
>          Time Spent: 1h 50m
>  Remaining Estimate: 0h
>
> support  EnumerableBatchNestedLoopJoin in JdbcToEnumerableConverter implement function
> ENUMERABLE_BATCH_NESTED_LOOP_JOIN_RULE make correlate RexNode, 
> when implementing,
> [https://github.com/apache/calcite/blob/eab043f4ef43112c16a9f6708e6c53a15b1cfbe0/core/src/main/java/org/apache/calcite/rel/rel2sql/SqlImplementor.java#L675]
> will throw null Exception



--
This message was sent by Atlassian Jira
(v8.20.1#820001)