You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by GitBox <gi...@apache.org> on 2021/01/16 03:06:00 UTC
[GitHub] [hbase] Apache9 opened a new pull request #2890: HBASE-25509 ChoreService.cancelChore will not call ScheduledChore.cle…
Apache9 opened a new pull request #2890:
URL: https://github.com/apache/hbase/pull/2890
…anup which may lead to resource leak
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] virajjasani commented on pull request #2890: HBASE-25509 ChoreService.cancelChore will not call ScheduledChore.cle…
Posted by GitBox <gi...@apache.org>.
virajjasani commented on pull request #2890:
URL: https://github.com/apache/hbase/pull/2890#issuecomment-761520154
```
[ERROR] COMPILATION ERROR :
[INFO] -------------------------------------------------------------
[ERROR] /home/jenkins/jenkins-agent/workspace/Base-PreCommit-GitHub-PR_PR-2890/yetus-general-check/src/hbase-common/src/test/java/org/apache/hadoop/hbase/TestChoreService.java:[757,14] error: [JUnit4TestNotRun] This looks like a test method but is not run; please add @Test and @Ignore, or, if this is a helper method, reduce its visibility.
(see https://errorprone.info/bugpattern/JUnit4TestNotRun)
Did you mean '@Test public void testInitialDelay() {' or '@Test @Ignore public void testInitialDelay() {' or 'private void testInitialDelay() {'?
[INFO] 1 error
[INFO] -------------------------------------------------------------
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #2890: HBASE-25509 ChoreService.cancelChore will not call ScheduledChore.cle…
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on pull request #2890:
URL: https://github.com/apache/hbase/pull/2890#issuecomment-762920588
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 0m 29s | Docker mode activated. |
| -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck |
||| _ Prechecks _ |
||| _ master Compile Tests _ |
| +0 :ok: | mvndep | 0m 27s | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 3m 32s | master passed |
| +1 :green_heart: | compile | 1m 20s | master passed |
| +1 :green_heart: | shadedjars | 6m 33s | branch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | javadoc | 0m 57s | master passed |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 16s | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 3m 30s | the patch passed |
| +1 :green_heart: | compile | 1m 23s | the patch passed |
| +1 :green_heart: | javac | 1m 23s | the patch passed |
| +1 :green_heart: | shadedjars | 6m 34s | patch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | javadoc | 0m 59s | the patch passed |
||| _ Other Tests _ |
| +1 :green_heart: | unit | 1m 33s | hbase-common in the patch passed. |
| +1 :green_heart: | unit | 141m 12s | hbase-server in the patch passed. |
| | | 171m 20s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2890/5/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/2890 |
| Optional Tests | javac javadoc unit shadedjars compile |
| uname | Linux b5d464603d06 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / 6c3861f65d |
| Default Java | AdoptOpenJDK-1.8.0_232-b09 |
| Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2890/5/testReport/ |
| Max. process+thread count | 4789 (vs. ulimit of 30000) |
| modules | C: hbase-common hbase-server U: . |
| Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2890/5/console |
| versions | git=2.17.1 maven=3.6.3 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #2890: HBASE-25509 ChoreService.cancelChore will not call ScheduledChore.cle…
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on pull request #2890:
URL: https://github.com/apache/hbase/pull/2890#issuecomment-761359231
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 0m 41s | Docker mode activated. |
| -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck |
||| _ Prechecks _ |
||| _ master Compile Tests _ |
| +0 :ok: | mvndep | 0m 24s | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 4m 30s | master passed |
| +1 :green_heart: | compile | 1m 32s | master passed |
| +1 :green_heart: | shadedjars | 7m 55s | branch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | javadoc | 1m 5s | master passed |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 16s | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 4m 2s | the patch passed |
| +1 :green_heart: | compile | 1m 32s | the patch passed |
| +1 :green_heart: | javac | 1m 32s | the patch passed |
| +1 :green_heart: | shadedjars | 7m 36s | patch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | javadoc | 1m 9s | the patch passed |
||| _ Other Tests _ |
| +1 :green_heart: | unit | 1m 37s | hbase-common in the patch passed. |
| -1 :x: | unit | 32m 36s | hbase-server in the patch failed. |
| | | 66m 31s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2890/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/2890 |
| Optional Tests | javac javadoc unit shadedjars compile |
| uname | Linux ab11e4deb8ca 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / 1474ebcc69 |
| Default Java | AdoptOpenJDK-1.8.0_232-b09 |
| unit | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2890/1/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-server.txt |
| Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2890/1/testReport/ |
| Max. process+thread count | 1483 (vs. ulimit of 30000) |
| modules | C: hbase-common hbase-server U: . |
| Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2890/1/console |
| versions | git=2.17.1 maven=3.6.3 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] Apache9 commented on pull request #2890: HBASE-25509 ChoreService.cancelChore will not call ScheduledChore.cle…
Posted by GitBox <gi...@apache.org>.
Apache9 commented on pull request #2890:
URL: https://github.com/apache/hbase/pull/2890#issuecomment-761302815
It is really a pain. We need a full redesign of the ChoreService and ScheduledChore. After reading the code, I think the intention here is that, if the stopper is stopped, we will cleanup the ScheduledChore, otherwise even if we call cancel, it only means we want to cancel it from the current ChoreService, and we could still schedule it again, with the current ChoreService or another one.
But in our code, lots of places just assume that, a simple cancel will do the clean up work.
In general, I do not think in our code base, we want to switch the ChoreService so I do not think we need the different semantic for cancel and stop. I think this is also why in our code base we just use cancel to clean up the chore when shutting down. But unluckily, ChoreService and ScheduledChore are marked as IA.Public, so we can not change its public facing API.
But I do not think these two classes should be marked as IA.Public. We are providing a SDK to users for connecting with HBase Cluster, not a scheduler framework.
So in this patch, I just added a shutdown method for cleanup the chore, but I would like to open another issue to change the IA annotation of these two classes to IA.Private, and then give it a full redesign.
Thanks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #2890: HBASE-25509 ChoreService.cancelChore will not call ScheduledChore.cle…
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on pull request #2890:
URL: https://github.com/apache/hbase/pull/2890#issuecomment-761354529
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 0m 27s | Docker mode activated. |
| -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck |
||| _ Prechecks _ |
||| _ master Compile Tests _ |
| +0 :ok: | mvndep | 0m 24s | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 4m 16s | master passed |
| +1 :green_heart: | compile | 1m 32s | master passed |
| +1 :green_heart: | shadedjars | 6m 48s | branch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | javadoc | 1m 6s | master passed |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 16s | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 4m 7s | the patch passed |
| +1 :green_heart: | compile | 1m 32s | the patch passed |
| +1 :green_heart: | javac | 1m 32s | the patch passed |
| +1 :green_heart: | shadedjars | 6m 41s | patch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | javadoc | 1m 5s | the patch passed |
||| _ Other Tests _ |
| +1 :green_heart: | unit | 1m 42s | hbase-common in the patch passed. |
| -1 :x: | unit | 31m 1s | hbase-server in the patch failed. |
| | | 62m 43s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2890/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/2890 |
| Optional Tests | javac javadoc unit shadedjars compile |
| uname | Linux 48c48753de4d 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / 1474ebcc69 |
| Default Java | AdoptOpenJDK-11.0.6+10 |
| unit | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2890/1/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt |
| Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2890/1/testReport/ |
| Max. process+thread count | 1455 (vs. ulimit of 30000) |
| modules | C: hbase-common hbase-server U: . |
| Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2890/1/console |
| versions | git=2.17.1 maven=3.6.3 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #2890: HBASE-25509 ChoreService.cancelChore will not call ScheduledChore.cle…
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on pull request #2890:
URL: https://github.com/apache/hbase/pull/2890#issuecomment-761613258
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 0m 31s | Docker mode activated. |
| -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck |
||| _ Prechecks _ |
||| _ master Compile Tests _ |
| +0 :ok: | mvndep | 0m 23s | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 3m 42s | master passed |
| +1 :green_heart: | compile | 1m 22s | master passed |
| +1 :green_heart: | shadedjars | 6m 37s | branch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | javadoc | 1m 0s | master passed |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 16s | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 3m 30s | the patch passed |
| +1 :green_heart: | compile | 1m 20s | the patch passed |
| +1 :green_heart: | javac | 1m 20s | the patch passed |
| +1 :green_heart: | shadedjars | 6m 40s | patch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | javadoc | 0m 58s | the patch passed |
||| _ Other Tests _ |
| +1 :green_heart: | unit | 1m 35s | hbase-common in the patch passed. |
| -1 :x: | unit | 148m 0s | hbase-server in the patch failed. |
| | | 178m 17s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2890/2/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/2890 |
| Optional Tests | javac javadoc unit shadedjars compile |
| uname | Linux cce15377fba8 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / 643548f5f5 |
| Default Java | AdoptOpenJDK-1.8.0_232-b09 |
| unit | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2890/2/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-server.txt |
| Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2890/2/testReport/ |
| Max. process+thread count | 4411 (vs. ulimit of 30000) |
| modules | C: hbase-common hbase-server U: . |
| Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2890/2/console |
| versions | git=2.17.1 maven=3.6.3 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #2890: HBASE-25509 ChoreService.cancelChore will not call ScheduledChore.cle…
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on pull request #2890:
URL: https://github.com/apache/hbase/pull/2890#issuecomment-761612101
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 1m 9s | Docker mode activated. |
| -0 :warning: | yetus | 0m 4s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck |
||| _ Prechecks _ |
||| _ master Compile Tests _ |
| +0 :ok: | mvndep | 0m 22s | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 4m 14s | master passed |
| +1 :green_heart: | compile | 1m 30s | master passed |
| +1 :green_heart: | shadedjars | 6m 39s | branch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | javadoc | 1m 5s | master passed |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 15s | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 4m 1s | the patch passed |
| +1 :green_heart: | compile | 1m 32s | the patch passed |
| +1 :green_heart: | javac | 1m 32s | the patch passed |
| +1 :green_heart: | shadedjars | 6m 39s | patch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | javadoc | 1m 4s | the patch passed |
||| _ Other Tests _ |
| +1 :green_heart: | unit | 1m 45s | hbase-common in the patch passed. |
| -1 :x: | unit | 138m 23s | hbase-server in the patch failed. |
| | | 171m 14s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2890/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/2890 |
| Optional Tests | javac javadoc unit shadedjars compile |
| uname | Linux 4b05117d5f39 4.15.0-65-generic #74-Ubuntu SMP Tue Sep 17 17:06:04 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / 643548f5f5 |
| Default Java | AdoptOpenJDK-11.0.6+10 |
| unit | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2890/2/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt |
| Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2890/2/testReport/ |
| Max. process+thread count | 4045 (vs. ulimit of 30000) |
| modules | C: hbase-common hbase-server U: . |
| Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2890/2/console |
| versions | git=2.17.1 maven=3.6.3 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #2890: HBASE-25509 ChoreService.cancelChore will not call ScheduledChore.cle…
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on pull request #2890:
URL: https://github.com/apache/hbase/pull/2890#issuecomment-762918049
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 0m 28s | Docker mode activated. |
| -0 :warning: | yetus | 0m 7s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck |
||| _ Prechecks _ |
||| _ master Compile Tests _ |
| +0 :ok: | mvndep | 0m 13s | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 3m 58s | master passed |
| +1 :green_heart: | compile | 1m 32s | master passed |
| +1 :green_heart: | shadedjars | 6m 40s | branch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | javadoc | 1m 4s | master passed |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 16s | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 4m 7s | the patch passed |
| +1 :green_heart: | compile | 1m 32s | the patch passed |
| +1 :green_heart: | javac | 1m 32s | the patch passed |
| +1 :green_heart: | shadedjars | 6m 39s | patch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | javadoc | 1m 4s | the patch passed |
||| _ Other Tests _ |
| +1 :green_heart: | unit | 1m 44s | hbase-common in the patch passed. |
| +1 :green_heart: | unit | 135m 54s | hbase-server in the patch passed. |
| | | 167m 42s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2890/5/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/2890 |
| Optional Tests | javac javadoc unit shadedjars compile |
| uname | Linux 2ee1e08be43c 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / 6c3861f65d |
| Default Java | AdoptOpenJDK-11.0.6+10 |
| Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2890/5/testReport/ |
| Max. process+thread count | 4376 (vs. ulimit of 30000) |
| modules | C: hbase-common hbase-server U: . |
| Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2890/5/console |
| versions | git=2.17.1 maven=3.6.3 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] Apache9 commented on a change in pull request #2890: HBASE-25509 ChoreService.cancelChore will not call ScheduledChore.cle…
Posted by GitBox <gi...@apache.org>.
Apache9 commented on a change in pull request #2890:
URL: https://github.com/apache/hbase/pull/2890#discussion_r560042891
##########
File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/HMaster.java
##########
@@ -1500,11 +1499,9 @@ private void switchSnapshotCleanup(final boolean on) {
try {
snapshotCleanupTracker.setSnapshotCleanupEnabled(on);
if (on) {
- if (!getChoreService().isChoreScheduled(this.snapshotCleanerChore)) {
- getChoreService().scheduleChore(this.snapshotCleanerChore);
- }
+ getChoreService().scheduleChore(this.snapshotCleanerChore);
} else {
- getChoreService().cancelChore(this.snapshotCleanerChore);
+ this.snapshotCleanerChore.cancel();
Review comment:
I do not think it could be null here? This method is called inside the switchSnapshotCleanup method above and it could call synchronized on the snapshotCleanerChore instance...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] virajjasani commented on a change in pull request #2890: HBASE-25509 ChoreService.cancelChore will not call ScheduledChore.cle…
Posted by GitBox <gi...@apache.org>.
virajjasani commented on a change in pull request #2890:
URL: https://github.com/apache/hbase/pull/2890#discussion_r559461474
##########
File path: hbase-common/src/main/java/org/apache/hadoop/hbase/ChoreService.java
##########
@@ -319,12 +360,18 @@ public synchronized void onChoreMissedStartTime(ScheduledChore chore) {
* shutdown the service. Any chores that are scheduled for execution will be cancelled. Any chores
* in the middle of execution will be interrupted and shutdown. This service will be unusable
* after this method has been called (i.e. future scheduling attempts will fail).
+ * <p/>
+ * Notice that, this will only clean the chore from this ChoreService but you could still schedule
+ * the chore with other ChoreService.
Review comment:
nit: other or same ChreService instance?
##########
File path: hbase-common/src/main/java/org/apache/hadoop/hbase/ChoreService.java
##########
@@ -141,28 +140,41 @@ public ChoreService(final String coreThreadPoolPrefix, int corePoolSize, boolean
* @return true when the chore was successfully scheduled. false when the scheduling failed
* (typically occurs when a chore is scheduled during shutdown of service)
*/
- public synchronized boolean scheduleChore(ScheduledChore chore) {
+ public boolean scheduleChore(ScheduledChore chore) {
if (chore == null) {
return false;
}
-
- try {
- if (chore.getPeriod() <= 0) {
- LOG.info("Chore {} is disabled because its period is not positive.", chore);
- return false;
- }
- LOG.info("Chore {} is enabled.", chore);
- chore.setChoreServicer(this);
- ScheduledFuture<?> future =
- scheduler.scheduleAtFixedRate(chore, chore.getInitialDelay(), chore.getPeriod(),
- chore.getTimeUnit());
- scheduledChores.put(chore, future);
- return true;
- } catch (Exception exception) {
- if (LOG.isInfoEnabled()) {
- LOG.info("Could not successfully schedule chore: " + chore.getName());
+ // always lock chore first to prevent dead lock
+ synchronized (chore) {
Review comment:
Other than here, do we have synchronization on `ScheduledChore` elsewhere? I think all other methods themselves are synchronized which is good but how do we prevent anyone from synchronizing on `ScheduledChore` instance in future? Perhaps for now, we can write a Javadoc comment on `ScheduledChore` providing this info?
##########
File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/ServerManager.java
##########
@@ -936,7 +936,7 @@ public void startChore() {
*/
public void stop() {
if (flushedSeqIdFlusher != null) {
- flushedSeqIdFlusher.cancel();
+ flushedSeqIdFlusher.shutdown();
Review comment:
`shutdown(true)` looks better candidate
##########
File path: hbase-server/src/main/java/org/apache/hadoop/hbase/quotas/RegionServerSpaceQuotaManager.java
##########
@@ -98,11 +98,11 @@ public synchronized void start() throws IOException {
public synchronized void stop() {
if (spaceQuotaRefresher != null) {
- spaceQuotaRefresher.cancel();
Review comment:
`cancel()` is nothing but `cancel(true)`, so all `cancel()` should be replaced with `shutdown(true)` just like all `cancel(true)` are replaced with `shutdown(true)`
##########
File path: hbase-common/src/main/java/org/apache/hadoop/hbase/ChoreService.java
##########
@@ -141,28 +140,41 @@ public ChoreService(final String coreThreadPoolPrefix, int corePoolSize, boolean
* @return true when the chore was successfully scheduled. false when the scheduling failed
* (typically occurs when a chore is scheduled during shutdown of service)
*/
- public synchronized boolean scheduleChore(ScheduledChore chore) {
+ public boolean scheduleChore(ScheduledChore chore) {
if (chore == null) {
return false;
}
-
- try {
- if (chore.getPeriod() <= 0) {
- LOG.info("Chore {} is disabled because its period is not positive.", chore);
- return false;
- }
- LOG.info("Chore {} is enabled.", chore);
- chore.setChoreServicer(this);
- ScheduledFuture<?> future =
- scheduler.scheduleAtFixedRate(chore, chore.getInitialDelay(), chore.getPeriod(),
- chore.getTimeUnit());
- scheduledChores.put(chore, future);
- return true;
- } catch (Exception exception) {
- if (LOG.isInfoEnabled()) {
- LOG.info("Could not successfully schedule chore: " + chore.getName());
+ // always lock chore first to prevent dead lock
+ synchronized (chore) {
+ synchronized (this) {
+ try {
+ // Chores should only ever be scheduled with a single ChoreService. If the choreService
+ // is changing, cancel any existing schedules of this chore.
+ if (chore.getChoreService() == this) {
+ LOG.warn("Chore {} has already been scheduled with us", chore);
+ return false;
+ }
+ if (chore.getPeriod() <= 0) {
+ LOG.info("Chore {} is disabled because its period is not positive.", chore);
+ return false;
+ }
+ LOG.info("Chore {} is enabled.", chore);
+ if (chore.getChoreService() != null) {
+ LOG.info("Cancel chore {} from its previous service", chore);
+ chore.getChoreService().cancelChore(chore);
+ }
+ chore.setChoreService(this);
+ ScheduledFuture<?> future = scheduler.scheduleAtFixedRate(chore, chore.getInitialDelay(),
+ chore.getPeriod(), chore.getTimeUnit());
+ scheduledChores.put(chore, future);
+ return true;
+ } catch (Exception exception) {
+ if (LOG.isInfoEnabled()) {
+ LOG.info("Could not successfully schedule chore: " + chore.getName());
Review comment:
Let's convert this to ERROR with exception stacktrace?
##########
File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/HMaster.java
##########
@@ -1500,11 +1499,9 @@ private void switchSnapshotCleanup(final boolean on) {
try {
snapshotCleanupTracker.setSnapshotCleanupEnabled(on);
if (on) {
- if (!getChoreService().isChoreScheduled(this.snapshotCleanerChore)) {
- getChoreService().scheduleChore(this.snapshotCleanerChore);
- }
+ getChoreService().scheduleChore(this.snapshotCleanerChore);
} else {
- getChoreService().cancelChore(this.snapshotCleanerChore);
+ this.snapshotCleanerChore.cancel();
Review comment:
I know it's a pain but we need to have null check here
##########
File path: hbase-common/src/main/java/org/apache/hadoop/hbase/ChoreService.java
##########
@@ -141,28 +140,41 @@ public ChoreService(final String coreThreadPoolPrefix, int corePoolSize, boolean
* @return true when the chore was successfully scheduled. false when the scheduling failed
* (typically occurs when a chore is scheduled during shutdown of service)
*/
- public synchronized boolean scheduleChore(ScheduledChore chore) {
+ public boolean scheduleChore(ScheduledChore chore) {
if (chore == null) {
return false;
}
-
- try {
- if (chore.getPeriod() <= 0) {
- LOG.info("Chore {} is disabled because its period is not positive.", chore);
- return false;
- }
- LOG.info("Chore {} is enabled.", chore);
- chore.setChoreServicer(this);
- ScheduledFuture<?> future =
- scheduler.scheduleAtFixedRate(chore, chore.getInitialDelay(), chore.getPeriod(),
- chore.getTimeUnit());
- scheduledChores.put(chore, future);
- return true;
- } catch (Exception exception) {
- if (LOG.isInfoEnabled()) {
- LOG.info("Could not successfully schedule chore: " + chore.getName());
+ // always lock chore first to prevent dead lock
+ synchronized (chore) {
+ synchronized (this) {
+ try {
+ // Chores should only ever be scheduled with a single ChoreService. If the choreService
+ // is changing, cancel any existing schedules of this chore.
+ if (chore.getChoreService() == this) {
+ LOG.warn("Chore {} has already been scheduled with us", chore);
+ return false;
+ }
+ if (chore.getPeriod() <= 0) {
+ LOG.info("Chore {} is disabled because its period is not positive.", chore);
+ return false;
+ }
+ LOG.info("Chore {} is enabled.", chore);
+ if (chore.getChoreService() != null) {
+ LOG.info("Cancel chore {} from its previous service", chore);
+ chore.getChoreService().cancelChore(chore);
Review comment:
I think it makes sense. So what we are doing is we are taking lock on give `ScheduledChore` instance, followed by current `ChoreService` itself and when we find that this ScheduledChore belongs to different ChoreService instance, we call `cancel()` on that instance, which is anyways synchronized instance method.
##########
File path: hbase-common/src/main/java/org/apache/hadoop/hbase/ScheduledChore.java
##########
@@ -354,7 +320,27 @@ protected boolean initialChore() {
/**
* Override to run cleanup tasks when the Chore encounters an error and must stop running
*/
- protected synchronized void cleanup() {
+ protected void cleanup() {
+ }
+
+ /**
+ * Call {@link #shutdown(boolean)} with {@code true}.
+ * @see ScheduledChore#shutdown(boolean)
+ */
+ public synchronized void shutdown() {
+ cancel(false);
+ cleanup();
Review comment:
This is supposed to call `shutdown(true)` right? Javadoc also says so.
##########
File path: hbase-common/src/main/java/org/apache/hadoop/hbase/ChoreService.java
##########
@@ -319,12 +360,18 @@ public synchronized void onChoreMissedStartTime(ScheduledChore chore) {
* shutdown the service. Any chores that are scheduled for execution will be cancelled. Any chores
* in the middle of execution will be interrupted and shutdown. This service will be unusable
* after this method has been called (i.e. future scheduling attempts will fail).
+ * <p/>
+ * Notice that, this will only clean the chore from this ChoreService but you could still schedule
+ * the chore with other ChoreService.
*/
public synchronized void shutdown() {
+ if (isShutdown()) {
+ return;
+ }
scheduler.shutdownNow();
if (LOG.isInfoEnabled()) {
- LOG.info("Chore service for: " + coreThreadPoolPrefix + " had " + scheduledChores.keySet()
- + " on shutdown");
+ LOG.info("Chore service for: " + coreThreadPoolPrefix + " had " + scheduledChores.keySet() +
+ " on shutdown");
}
Review comment:
I think INFO is quite common level set by majority applications. We better remove `isInfoEnabled()` check and also replace String concat with placeholders with `{}`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] virajjasani commented on a change in pull request #2890: HBASE-25509 ChoreService.cancelChore will not call ScheduledChore.cle…
Posted by GitBox <gi...@apache.org>.
virajjasani commented on a change in pull request #2890:
URL: https://github.com/apache/hbase/pull/2890#discussion_r558819095
##########
File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java
##########
@@ -2649,15 +2649,16 @@ private void scheduleAbortTimer() {
protected void stopServiceThreads() {
// clean up the scheduled chores
if (this.choreService != null) {
- choreService.cancelChore(nonceManagerChore);
- choreService.cancelChore(compactionChecker);
- choreService.cancelChore(periodicFlusher);
- choreService.cancelChore(healthCheckChore);
- choreService.cancelChore(executorStatusChore);
- choreService.cancelChore(storefileRefresher);
- choreService.cancelChore(fsUtilizationChore);
- choreService.cancelChore(slowLogTableOpsChore);
- // clean up the remaining scheduled chores (in case we missed out any)
+ nonceManagerChore.shutdown();
+ compactionChecker.shutdown();
+ periodicFlusher.shutdown();
+ healthCheckChore.shutdown();
+ executorStatusChore.shutdown();
+ storefileRefresher.shutdown();
+ fsUtilizationChore.shutdown();
+ slowLogTableOpsChore.shutdown();
Review comment:
All of these are mandatory chores right? Any chances, any chore can be null?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #2890: HBASE-25509 ChoreService.cancelChore will not call ScheduledChore.cle…
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on pull request #2890:
URL: https://github.com/apache/hbase/pull/2890#issuecomment-762815792
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 0m 29s | Docker mode activated. |
| -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck |
||| _ Prechecks _ |
||| _ master Compile Tests _ |
| +0 :ok: | mvndep | 0m 30s | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 3m 35s | master passed |
| +1 :green_heart: | compile | 1m 23s | master passed |
| +1 :green_heart: | shadedjars | 6m 32s | branch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | javadoc | 0m 58s | master passed |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 16s | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 3m 27s | the patch passed |
| +1 :green_heart: | compile | 1m 20s | the patch passed |
| +1 :green_heart: | javac | 1m 20s | the patch passed |
| +1 :green_heart: | shadedjars | 6m 34s | patch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | javadoc | 0m 57s | the patch passed |
||| _ Other Tests _ |
| +1 :green_heart: | unit | 1m 34s | hbase-common in the patch passed. |
| +1 :green_heart: | unit | 141m 58s | hbase-server in the patch passed. |
| | | 172m 10s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2890/4/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/2890 |
| Optional Tests | javac javadoc unit shadedjars compile |
| uname | Linux dc2554618c5f 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / 6c3861f65d |
| Default Java | AdoptOpenJDK-1.8.0_232-b09 |
| Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2890/4/testReport/ |
| Max. process+thread count | 4826 (vs. ulimit of 30000) |
| modules | C: hbase-common hbase-server U: . |
| Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2890/4/console |
| versions | git=2.17.1 maven=3.6.3 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #2890: HBASE-25509 ChoreService.cancelChore will not call ScheduledChore.cle…
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on pull request #2890:
URL: https://github.com/apache/hbase/pull/2890#issuecomment-761592117
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 0m 29s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 1s | No case conflicting files found. |
| +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
||| _ master Compile Tests _ |
| +0 :ok: | mvndep | 0m 22s | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 3m 45s | master passed |
| +1 :green_heart: | compile | 4m 1s | master passed |
| +1 :green_heart: | checkstyle | 1m 34s | master passed |
| +1 :green_heart: | spotbugs | 2m 41s | master passed |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 14s | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 3m 27s | the patch passed |
| +1 :green_heart: | compile | 3m 56s | the patch passed |
| +1 :green_heart: | javac | 3m 56s | the patch passed |
| +1 :green_heart: | checkstyle | 0m 24s | hbase-common: The patch generated 0 new + 2 unchanged - 3 fixed = 2 total (was 5) |
| +1 :green_heart: | checkstyle | 1m 7s | The patch passed checkstyle in hbase-server |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. |
| +1 :green_heart: | hadoopcheck | 17m 11s | Patch does not cause any errors with Hadoop 3.1.2 3.2.1 3.3.0. |
| +1 :green_heart: | spotbugs | 2m 57s | the patch passed |
||| _ Other Tests _ |
| +1 :green_heart: | asflicense | 0m 26s | The patch does not generate ASF License warnings. |
| | | 50m 20s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2890/2/artifact/yetus-general-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/2890 |
| Optional Tests | dupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile |
| uname | Linux c5811a2d0164 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / 643548f5f5 |
| Default Java | AdoptOpenJDK-1.8.0_232-b09 |
| Max. process+thread count | 96 (vs. ulimit of 30000) |
| modules | C: hbase-common hbase-server U: . |
| Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2890/2/console |
| versions | git=2.17.1 maven=3.6.3 spotbugs=3.1.12 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] Apache9 merged pull request #2890: HBASE-25509 ChoreService.cancelChore will not call ScheduledChore.cle…
Posted by GitBox <gi...@apache.org>.
Apache9 merged pull request #2890:
URL: https://github.com/apache/hbase/pull/2890
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #2890: HBASE-25509 ChoreService.cancelChore will not call ScheduledChore.cle…
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on pull request #2890:
URL: https://github.com/apache/hbase/pull/2890#issuecomment-762811154
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 1m 21s | Docker mode activated. |
| -0 :warning: | yetus | 0m 4s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck |
||| _ Prechecks _ |
||| _ master Compile Tests _ |
| +0 :ok: | mvndep | 0m 24s | Maven dependency ordering for branch |
| -1 :x: | mvninstall | 1m 16s | root in master failed. |
| -1 :x: | compile | 0m 20s | hbase-server in master failed. |
| +1 :green_heart: | shadedjars | 6m 48s | branch has no errors when building our shaded downstream artifacts. |
| -0 :warning: | javadoc | 0m 11s | hbase-server in master failed. |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 17s | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 4m 6s | the patch passed |
| +1 :green_heart: | compile | 1m 33s | the patch passed |
| -0 :warning: | javac | 1m 6s | hbase-server generated 4 new + 0 unchanged - 0 fixed = 4 total (was 0) |
| +1 :green_heart: | shadedjars | 6m 44s | patch has no errors when building our shaded downstream artifacts. |
| -0 :warning: | javadoc | 0m 41s | hbase-server generated 79 new + 0 unchanged - 0 fixed = 79 total (was 0) |
||| _ Other Tests _ |
| +1 :green_heart: | unit | 1m 45s | hbase-common in the patch passed. |
| +1 :green_heart: | unit | 132m 57s | hbase-server in the patch passed. |
| | | 162m 5s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2890/4/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/2890 |
| Optional Tests | javac javadoc unit shadedjars compile |
| uname | Linux aa5116c30179 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / 6c3861f65d |
| Default Java | AdoptOpenJDK-11.0.6+10 |
| mvninstall | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2890/4/artifact/yetus-jdk11-hadoop3-check/output/branch-mvninstall-root.txt |
| compile | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2890/4/artifact/yetus-jdk11-hadoop3-check/output/branch-compile-hbase-server.txt |
| javadoc | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2890/4/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-server.txt |
| javac | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2890/4/artifact/yetus-jdk11-hadoop3-check/output/diff-compile-javac-hbase-server.txt |
| javadoc | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2890/4/artifact/yetus-jdk11-hadoop3-check/output/diff-javadoc-javadoc-hbase-server.txt |
| Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2890/4/testReport/ |
| Max. process+thread count | 4078 (vs. ulimit of 30000) |
| modules | C: hbase-common hbase-server U: . |
| Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2890/4/console |
| versions | git=2.17.1 maven=3.6.3 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] Apache9 commented on a change in pull request #2890: HBASE-25509 ChoreService.cancelChore will not call ScheduledChore.cle…
Posted by GitBox <gi...@apache.org>.
Apache9 commented on a change in pull request #2890:
URL: https://github.com/apache/hbase/pull/2890#discussion_r560034538
##########
File path: hbase-common/src/main/java/org/apache/hadoop/hbase/ChoreService.java
##########
@@ -141,28 +140,41 @@ public ChoreService(final String coreThreadPoolPrefix, int corePoolSize, boolean
* @return true when the chore was successfully scheduled. false when the scheduling failed
* (typically occurs when a chore is scheduled during shutdown of service)
*/
- public synchronized boolean scheduleChore(ScheduledChore chore) {
+ public boolean scheduleChore(ScheduledChore chore) {
if (chore == null) {
return false;
}
-
- try {
- if (chore.getPeriod() <= 0) {
- LOG.info("Chore {} is disabled because its period is not positive.", chore);
- return false;
- }
- LOG.info("Chore {} is enabled.", chore);
- chore.setChoreServicer(this);
- ScheduledFuture<?> future =
- scheduler.scheduleAtFixedRate(chore, chore.getInitialDelay(), chore.getPeriod(),
- chore.getTimeUnit());
- scheduledChores.put(chore, future);
- return true;
- } catch (Exception exception) {
- if (LOG.isInfoEnabled()) {
- LOG.info("Could not successfully schedule chore: " + chore.getName());
+ // always lock chore first to prevent dead lock
+ synchronized (chore) {
Review comment:
The problem is the order, so it is OK that you synchronized ScheduledChore first and then call the synchronized method in ChoreService.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #2890: HBASE-25509 ChoreService.cancelChore will not call ScheduledChore.cle…
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on pull request #2890:
URL: https://github.com/apache/hbase/pull/2890#issuecomment-761984063
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 1m 22s | Docker mode activated. |
| -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck |
||| _ Prechecks _ |
||| _ master Compile Tests _ |
| +0 :ok: | mvndep | 0m 25s | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 3m 25s | master passed |
| +1 :green_heart: | compile | 1m 22s | master passed |
| +1 :green_heart: | shadedjars | 6m 29s | branch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | javadoc | 0m 57s | master passed |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 16s | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 3m 28s | the patch passed |
| +1 :green_heart: | compile | 1m 18s | the patch passed |
| +1 :green_heart: | javac | 1m 18s | the patch passed |
| +1 :green_heart: | shadedjars | 6m 30s | patch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | javadoc | 0m 57s | the patch passed |
||| _ Other Tests _ |
| +1 :green_heart: | unit | 1m 33s | hbase-common in the patch passed. |
| +1 :green_heart: | unit | 145m 19s | hbase-server in the patch passed. |
| | | 175m 44s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2890/3/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/2890 |
| Optional Tests | javac javadoc unit shadedjars compile |
| uname | Linux 4d5a8235698e 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / d5debe15b5 |
| Default Java | AdoptOpenJDK-1.8.0_232-b09 |
| Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2890/3/testReport/ |
| Max. process+thread count | 5016 (vs. ulimit of 30000) |
| modules | C: hbase-common hbase-server U: . |
| Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2890/3/console |
| versions | git=2.17.1 maven=3.6.3 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] Apache9 commented on a change in pull request #2890: HBASE-25509 ChoreService.cancelChore will not call ScheduledChore.cle…
Posted by GitBox <gi...@apache.org>.
Apache9 commented on a change in pull request #2890:
URL: https://github.com/apache/hbase/pull/2890#discussion_r560043688
##########
File path: hbase-common/src/main/java/org/apache/hadoop/hbase/ScheduledChore.java
##########
@@ -354,7 +320,27 @@ protected boolean initialChore() {
/**
* Override to run cleanup tasks when the Chore encounters an error and must stop running
*/
- protected synchronized void cleanup() {
+ protected void cleanup() {
+ }
+
+ /**
+ * Call {@link #shutdown(boolean)} with {@code true}.
+ * @see ScheduledChore#shutdown(boolean)
+ */
+ public synchronized void shutdown() {
+ cancel(false);
+ cleanup();
Review comment:
Oh, a typo. It should be `shutdown(true);`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] Apache9 commented on a change in pull request #2890: HBASE-25509 ChoreService.cancelChore will not call ScheduledChore.cle…
Posted by GitBox <gi...@apache.org>.
Apache9 commented on a change in pull request #2890:
URL: https://github.com/apache/hbase/pull/2890#discussion_r560044017
##########
File path: hbase-server/src/main/java/org/apache/hadoop/hbase/quotas/RegionServerSpaceQuotaManager.java
##########
@@ -98,11 +98,11 @@ public synchronized void start() throws IOException {
public synchronized void stop() {
if (spaceQuotaRefresher != null) {
- spaceQuotaRefresher.cancel();
Review comment:
shutdown() is just shutdown(true) after fixing the above typo.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #2890: HBASE-25509 ChoreService.cancelChore will not call ScheduledChore.cle…
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on pull request #2890:
URL: https://github.com/apache/hbase/pull/2890#issuecomment-761949719
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 0m 46s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. |
| +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
||| _ master Compile Tests _ |
| +0 :ok: | mvndep | 0m 26s | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 3m 30s | master passed |
| +1 :green_heart: | compile | 3m 54s | master passed |
| +1 :green_heart: | checkstyle | 1m 33s | master passed |
| +1 :green_heart: | spotbugs | 2m 43s | master passed |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 13s | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 3m 28s | the patch passed |
| +1 :green_heart: | compile | 3m 57s | the patch passed |
| +1 :green_heart: | javac | 3m 57s | the patch passed |
| +1 :green_heart: | checkstyle | 0m 22s | hbase-common: The patch generated 0 new + 2 unchanged - 3 fixed = 2 total (was 5) |
| +1 :green_heart: | checkstyle | 1m 7s | The patch passed checkstyle in hbase-server |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. |
| +1 :green_heart: | hadoopcheck | 17m 5s | Patch does not cause any errors with Hadoop 3.1.2 3.2.1 3.3.0. |
| +1 :green_heart: | spotbugs | 2m 57s | the patch passed |
||| _ Other Tests _ |
| +1 :green_heart: | asflicense | 0m 26s | The patch does not generate ASF License warnings. |
| | | 50m 13s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2890/3/artifact/yetus-general-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/2890 |
| Optional Tests | dupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile |
| uname | Linux fd5a0d893e89 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / d5debe15b5 |
| Default Java | AdoptOpenJDK-1.8.0_232-b09 |
| Max. process+thread count | 96 (vs. ulimit of 30000) |
| modules | C: hbase-common hbase-server U: . |
| Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2890/3/console |
| versions | git=2.17.1 maven=3.6.3 spotbugs=3.1.12 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #2890: HBASE-25509 ChoreService.cancelChore will not call ScheduledChore.cle…
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on pull request #2890:
URL: https://github.com/apache/hbase/pull/2890#issuecomment-762757812
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 1m 36s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. |
| +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
||| _ master Compile Tests _ |
| +0 :ok: | mvndep | 0m 28s | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 3m 31s | master passed |
| +1 :green_heart: | compile | 3m 57s | master passed |
| +1 :green_heart: | checkstyle | 1m 32s | master passed |
| +1 :green_heart: | spotbugs | 2m 39s | master passed |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 13s | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 3m 29s | the patch passed |
| +1 :green_heart: | compile | 3m 54s | the patch passed |
| +1 :green_heart: | javac | 3m 54s | the patch passed |
| -0 :warning: | checkstyle | 0m 25s | hbase-common: The patch generated 1 new + 2 unchanged - 3 fixed = 3 total (was 5) |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. |
| +1 :green_heart: | hadoopcheck | 18m 5s | Patch does not cause any errors with Hadoop 3.1.2 3.2.1 3.3.0. |
| +1 :green_heart: | spotbugs | 3m 25s | the patch passed |
||| _ Other Tests _ |
| +1 :green_heart: | asflicense | 0m 23s | The patch does not generate ASF License warnings. |
| | | 53m 35s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2890/4/artifact/yetus-general-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/2890 |
| Optional Tests | dupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile |
| uname | Linux fb6d4d13a6d6 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / 6c3861f65d |
| Default Java | AdoptOpenJDK-1.8.0_232-b09 |
| checkstyle | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2890/4/artifact/yetus-general-check/output/diff-checkstyle-hbase-common.txt |
| Max. process+thread count | 96 (vs. ulimit of 30000) |
| modules | C: hbase-common hbase-server U: . |
| Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2890/4/console |
| versions | git=2.17.1 maven=3.6.3 spotbugs=3.1.12 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] Apache9 commented on a change in pull request #2890: HBASE-25509 ChoreService.cancelChore will not call ScheduledChore.cle…
Posted by GitBox <gi...@apache.org>.
Apache9 commented on a change in pull request #2890:
URL: https://github.com/apache/hbase/pull/2890#discussion_r560032645
##########
File path: hbase-common/src/main/java/org/apache/hadoop/hbase/ChoreService.java
##########
@@ -319,12 +360,18 @@ public synchronized void onChoreMissedStartTime(ScheduledChore chore) {
* shutdown the service. Any chores that are scheduled for execution will be cancelled. Any chores
* in the middle of execution will be interrupted and shutdown. This service will be unusable
* after this method has been called (i.e. future scheduling attempts will fail).
+ * <p/>
+ * Notice that, this will only clean the chore from this ChoreService but you could still schedule
+ * the chore with other ChoreService.
Review comment:
The same ChoreService has already been shutdown...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #2890: HBASE-25509 ChoreService.cancelChore will not call ScheduledChore.cle…
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on pull request #2890:
URL: https://github.com/apache/hbase/pull/2890#issuecomment-761981101
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 0m 29s | Docker mode activated. |
| -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck |
||| _ Prechecks _ |
||| _ master Compile Tests _ |
| +0 :ok: | mvndep | 0m 26s | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 4m 21s | master passed |
| +1 :green_heart: | compile | 1m 34s | master passed |
| +1 :green_heart: | shadedjars | 6m 41s | branch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | javadoc | 1m 7s | master passed |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 15s | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 4m 6s | the patch passed |
| +1 :green_heart: | compile | 1m 36s | the patch passed |
| +1 :green_heart: | javac | 1m 36s | the patch passed |
| +1 :green_heart: | shadedjars | 6m 39s | patch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | javadoc | 1m 3s | the patch passed |
||| _ Other Tests _ |
| +1 :green_heart: | unit | 1m 45s | hbase-common in the patch passed. |
| +1 :green_heart: | unit | 133m 53s | hbase-server in the patch passed. |
| | | 166m 30s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2890/3/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/2890 |
| Optional Tests | javac javadoc unit shadedjars compile |
| uname | Linux dc8aa22ac6bb 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / d5debe15b5 |
| Default Java | AdoptOpenJDK-11.0.6+10 |
| Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2890/3/testReport/ |
| Max. process+thread count | 4264 (vs. ulimit of 30000) |
| modules | C: hbase-common hbase-server U: . |
| Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2890/3/console |
| versions | git=2.17.1 maven=3.6.3 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #2890: HBASE-25509 ChoreService.cancelChore will not call ScheduledChore.cle…
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on pull request #2890:
URL: https://github.com/apache/hbase/pull/2890#issuecomment-761341571
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 0m 30s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. |
| +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
||| _ master Compile Tests _ |
| +0 :ok: | mvndep | 0m 24s | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 3m 45s | master passed |
| +1 :green_heart: | compile | 3m 59s | master passed |
| +1 :green_heart: | checkstyle | 1m 35s | master passed |
| +1 :green_heart: | spotbugs | 2m 42s | master passed |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 14s | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 3m 23s | the patch passed |
| -1 :x: | compile | 0m 49s | hbase-common in the patch failed. |
| -0 :warning: | javac | 0m 49s | hbase-common in the patch failed. |
| +1 :green_heart: | checkstyle | 0m 24s | hbase-common: The patch generated 0 new + 2 unchanged - 3 fixed = 2 total (was 5) |
| +1 :green_heart: | checkstyle | 1m 7s | The patch passed checkstyle in hbase-server |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. |
| +1 :green_heart: | hadoopcheck | 17m 23s | Patch does not cause any errors with Hadoop 3.1.2 3.2.1 3.3.0. |
| +1 :green_heart: | spotbugs | 3m 0s | the patch passed |
||| _ Other Tests _ |
| +1 :green_heart: | asflicense | 0m 28s | The patch does not generate ASF License warnings. |
| | | 50m 39s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2890/1/artifact/yetus-general-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/2890 |
| Optional Tests | dupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile |
| uname | Linux c3bbe3e0b4bb 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / 1474ebcc69 |
| Default Java | AdoptOpenJDK-1.8.0_232-b09 |
| compile | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2890/1/artifact/yetus-general-check/output/patch-compile-hbase-common.txt |
| javac | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2890/1/artifact/yetus-general-check/output/patch-compile-hbase-common.txt |
| Max. process+thread count | 96 (vs. ulimit of 30000) |
| modules | C: hbase-common hbase-server U: . |
| Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2890/1/console |
| versions | git=2.17.1 maven=3.6.3 spotbugs=3.1.12 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #2890: HBASE-25509 ChoreService.cancelChore will not call ScheduledChore.cle…
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on pull request #2890:
URL: https://github.com/apache/hbase/pull/2890#issuecomment-762840589
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 0m 28s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. |
| +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
||| _ master Compile Tests _ |
| +0 :ok: | mvndep | 0m 14s | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 3m 29s | master passed |
| +1 :green_heart: | compile | 3m 53s | master passed |
| +1 :green_heart: | checkstyle | 1m 32s | master passed |
| +1 :green_heart: | spotbugs | 2m 36s | master passed |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 14s | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 3m 25s | the patch passed |
| +1 :green_heart: | compile | 3m 54s | the patch passed |
| +1 :green_heart: | javac | 3m 54s | the patch passed |
| +1 :green_heart: | checkstyle | 0m 23s | hbase-common: The patch generated 0 new + 2 unchanged - 3 fixed = 2 total (was 5) |
| +1 :green_heart: | checkstyle | 1m 8s | The patch passed checkstyle in hbase-server |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. |
| +1 :green_heart: | hadoopcheck | 16m 56s | Patch does not cause any errors with Hadoop 3.1.2 3.2.1 3.3.0. |
| +1 :green_heart: | spotbugs | 2m 59s | the patch passed |
||| _ Other Tests _ |
| +1 :green_heart: | asflicense | 0m 25s | The patch does not generate ASF License warnings. |
| | | 49m 19s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2890/5/artifact/yetus-general-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/2890 |
| Optional Tests | dupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile |
| uname | Linux f5fabfe2caa1 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / 6c3861f65d |
| Default Java | AdoptOpenJDK-1.8.0_232-b09 |
| Max. process+thread count | 96 (vs. ulimit of 30000) |
| modules | C: hbase-common hbase-server U: . |
| Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2890/5/console |
| versions | git=2.17.1 maven=3.6.3 spotbugs=3.1.12 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org