You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by "Timothy St. Clair" <ts...@redhat.com> on 2014/06/19 03:31:27 UTC

Re: Review Request 21598: Cleanup libjvm to use DynamicLibrary

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21598/
-----------------------------------------------------------

(Updated June 19, 2014, 1:31 a.m.)


Review request for mesos, Benjamin Hindman and Niklas Nielsen.


Changes
-------

Changing the summary to reflect. 


Summary (updated)
-----------------

Cleanup libjvm to use DynamicLibrary


Bugs: MESOS-1354
    https://issues.apache.org/jira/browse/MESOS-1354


Repository: mesos-git


Description (updated)
-------

Update the code to leverage stout/dynamiclibrary.


Diffs
-----

  src/jvm/jvm.cpp 745b48f 

Diff: https://reviews.apache.org/r/21598/diff/


Testing
-------

make check


Thanks,

Timothy St. Clair

Re: Review Request 21598: Cleanup libjvm to use DynamicLibrary

Posted by Niklas Nielsen <ni...@qni.dk>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21598/#review46544
-----------------------------------------------------------

Ship it!


Ship It!

- Niklas Nielsen


On June 19, 2014, 12:05 p.m., Timothy St. Clair wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21598/
> -----------------------------------------------------------
> 
> (Updated June 19, 2014, 12:05 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Niklas Nielsen.
> 
> 
> Bugs: MESOS-1354
>     https://issues.apache.org/jira/browse/MESOS-1354
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> Update the code to leverage stout/dynamiclibrary.
> 
> 
> Diffs
> -----
> 
>   src/jvm/jvm.cpp 745b48f 
> 
> Diff: https://reviews.apache.org/r/21598/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Timothy St. Clair
> 
>

Re: Review Request 21598: Cleanup libjvm to use DynamicLibrary

Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21598/#review46511
-----------------------------------------------------------


Patch looks great!

Reviews applied: [21598]

All tests passed.

- Mesos ReviewBot


On June 19, 2014, 7:05 p.m., Timothy St. Clair wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21598/
> -----------------------------------------------------------
> 
> (Updated June 19, 2014, 7:05 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Niklas Nielsen.
> 
> 
> Bugs: MESOS-1354
>     https://issues.apache.org/jira/browse/MESOS-1354
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> Update the code to leverage stout/dynamiclibrary.
> 
> 
> Diffs
> -----
> 
>   src/jvm/jvm.cpp 745b48f 
> 
> Diff: https://reviews.apache.org/r/21598/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Timothy St. Clair
> 
>

Re: Review Request 21598: Cleanup libjvm to use DynamicLibrary

Posted by "Timothy St. Clair" <ts...@redhat.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21598/
-----------------------------------------------------------

(Updated June 19, 2014, 7:05 p.m.)


Review request for mesos, Benjamin Hindman and Niklas Nielsen.


Changes
-------

update, wrong patch last time. 


Bugs: MESOS-1354
    https://issues.apache.org/jira/browse/MESOS-1354


Repository: mesos-git


Description
-------

Update the code to leverage stout/dynamiclibrary.


Diffs (updated)
-----

  src/jvm/jvm.cpp 745b48f 

Diff: https://reviews.apache.org/r/21598/diff/


Testing
-------

make check


Thanks,

Timothy St. Clair

Re: Review Request 21598: Cleanup libjvm to use DynamicLibrary

Posted by "Timothy St. Clair" <ts...@redhat.com>.

> On June 19, 2014, 4:49 a.m., Niklas Nielsen wrote:
> > Wrong diff?

haha sorry. 


- Timothy


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21598/#review46188
-----------------------------------------------------------


On June 19, 2014, 2:05 a.m., Timothy St. Clair wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21598/
> -----------------------------------------------------------
> 
> (Updated June 19, 2014, 2:05 a.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Niklas Nielsen.
> 
> 
> Bugs: MESOS-1354
>     https://issues.apache.org/jira/browse/MESOS-1354
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> Update the code to leverage stout/dynamiclibrary.
> 
> 
> Diffs
> -----
> 
>   src/linux/cgroups.hpp 75c5602 
>   src/linux/cgroups.cpp a4274a8 
>   src/slave/containerizer/isolators/cgroups/cpushare.cpp 3265a80 
>   src/slave/containerizer/isolators/cgroups/mem.cpp 3b731f9 
> 
> Diff: https://reviews.apache.org/r/21598/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Timothy St. Clair
> 
>

Re: Review Request 21598: Cleanup libjvm to use DynamicLibrary

Posted by Niklas Nielsen <ni...@qni.dk>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21598/#review46188
-----------------------------------------------------------


Wrong diff?

- Niklas Nielsen


On June 18, 2014, 7:05 p.m., Timothy St. Clair wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21598/
> -----------------------------------------------------------
> 
> (Updated June 18, 2014, 7:05 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Niklas Nielsen.
> 
> 
> Bugs: MESOS-1354
>     https://issues.apache.org/jira/browse/MESOS-1354
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> Update the code to leverage stout/dynamiclibrary.
> 
> 
> Diffs
> -----
> 
>   src/linux/cgroups.hpp 75c5602 
>   src/linux/cgroups.cpp a4274a8 
>   src/slave/containerizer/isolators/cgroups/cpushare.cpp 3265a80 
>   src/slave/containerizer/isolators/cgroups/mem.cpp 3b731f9 
> 
> Diff: https://reviews.apache.org/r/21598/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Timothy St. Clair
> 
>

Re: Review Request 21598: Cleanup libjvm to use DynamicLibrary

Posted by "Timothy St. Clair" <ts...@redhat.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21598/
-----------------------------------------------------------

(Updated June 19, 2014, 2:05 a.m.)


Review request for mesos, Benjamin Hindman and Niklas Nielsen.


Changes
-------

update per review. 


Bugs: MESOS-1354
    https://issues.apache.org/jira/browse/MESOS-1354


Repository: mesos-git


Description
-------

Update the code to leverage stout/dynamiclibrary.


Diffs (updated)
-----

  src/linux/cgroups.hpp 75c5602 
  src/linux/cgroups.cpp a4274a8 
  src/slave/containerizer/isolators/cgroups/cpushare.cpp 3265a80 
  src/slave/containerizer/isolators/cgroups/mem.cpp 3b731f9 

Diff: https://reviews.apache.org/r/21598/diff/


Testing
-------

make check


Thanks,

Timothy St. Clair