You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by bu...@apache.org on 2012/02/21 13:10:20 UTC

DO NOT REPLY [Bug 52730] New: Another incomplete fix for the resource leak bug in CometConnectionManagerValve.java

https://issues.apache.org/bugzilla/show_bug.cgi?id=52730

             Bug #: 52730
           Summary: Another incomplete fix for the resource leak bug in
                    CometConnectionManagerValve.java
           Product: Tomcat 7
           Version: trunk
          Platform: PC
        OS/Version: Mac System 7
            Status: NEW
          Severity: critical
          Priority: P2
         Component: Catalina
        AssignedTo: dev@tomcat.apache.org
        ReportedBy: lianggt08@sei.pku.edu.cn
    Classification: Unclassified


The fix revision 730178 was aimed to remove an resource leak bug on the
FileInputStream object "fis " (created in line 451), the Socket object "socket"
(created in line 474) and the OutputStream object "stream" (created in line
475) in the method "stopServer()" of the file
"/tomcat/trunk/java/org/apache/catalina/valves/CometConnectionManagerValve.java"
, but it is incomplete. 

There are some problems: 
1. when the statements at lines 452-454 throw some exception, the "fis" can not
be closed as expected. 
2. when the statements at lines 475-480 throw some exception, the "socket" and
the "stream" can not be closed as expected. 

The best way to close such resource objects is putting such close operations in
the finaly block of a try-catch-finally structure.

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org

DO NOT REPLY [Bug 52730] Another incomplete fix for the resource leak bug in CometConnectionManagerValve.java

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=52730

Mark Thomas <ma...@apache.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |INVALID

--- Comment #1 from Mark Thomas <ma...@apache.org> 2012-03-06 21:30:09 UTC ---
Complete, total and utter nonsense.

r730178 has nothing to do with either the CometConnectionManagerValve nor
fixing a resource leak.

The line number referenced does not exist in CometConnectionManagerValve.java

This looks like an incoherent  mish-mash of bug 52729 and bug 52724.

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org