You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2021/10/11 23:10:45 UTC
[GitHub] [ozone] umamaheswararao opened a new pull request #2733: HDDS-5364: EC: Adopt EC related utility from Hadoop source repository
umamaheswararao opened a new pull request #2733:
URL: https://github.com/apache/ozone/pull/2733
## What changes were proposed in this pull request?
Code copied from Hadoop repo. Originally this work done by Marton and now I fixed the conflicts and updated.
For discussions: https://github.com/apache/ozone/pull/2444
## What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-5364
Please replace this section with the link to the Apache JIRA)
## How was this patch tested?
Tests included.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] fapifta commented on a change in pull request #2733: HDDS-5364: EC: Adopt EC related utility from Hadoop source repository
Posted by GitBox <gi...@apache.org>.
fapifta commented on a change in pull request #2733:
URL: https://github.com/apache/ozone/pull/2733#discussion_r732088348
##########
File path: hadoop-hdds/erasurecode/pom.xml
##########
@@ -0,0 +1,57 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<!--
+ Licensed under the Apache License, Version 2.0 (the "License");
+ you may not use this file except in compliance with the License.
+ You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+ Unless required by applicable law or agreed to in writing, software
+ distributed under the License is distributed on an "AS IS" BASIS,
+ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ See the License for the specific language governing permissions and
+ limitations under the License. See accompanying LICENSE file.
+-->
+<project xmlns="http://maven.apache.org/POM/4.0.0"
+ xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0
+https://maven.apache.org/xsd/maven-4.0.0.xsd">
+ <modelVersion>4.0.0</modelVersion>
+ <parent>
+ <groupId>org.apache.ozone</groupId>
+ <artifactId>hdds</artifactId>
+ <version>1.2.0-SNAPSHOT</version>
+ </parent>
+ <artifactId>hdds-erasurecode</artifactId>
+ <version>1.2.0-SNAPSHOT</version>
+ <description>Apache Ozone Distributed Data Store Earsurecode utils
+ </description>
+ <name>Apache Ozone HDDS Erasurecode</name>
+ <packaging>jar</packaging>
+
+ <dependencies>
+
+ <dependency>
+ <groupId>org.apache.ozone</groupId>
+ <artifactId>hdds-common</artifactId>
+ </dependency>
+ <dependency>
+ <groupId>org.apache.ozone</groupId>
+ <artifactId>hdds-test-utils</artifactId>
+ <scope>test</scope>
+ </dependency>
+ <dependency>
Review comment:
This one seems to be the same as the prior dependency, though the prior dependency defined for the test scope only.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] fapifta commented on pull request #2733: HDDS-5364: EC: Adopt EC related utility from Hadoop source repository
Posted by GitBox <gi...@apache.org>.
fapifta commented on pull request #2733:
URL: https://github.com/apache/ozone/pull/2733#issuecomment-946947635
Hi @umamaheswararao thank you for taking this on, and continue the work on this one, the changes look good to me, besides that duplication I have added a separate comment to. If that is resolved, +1.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] umamaheswararao merged pull request #2733: HDDS-5364: EC: Adopt EC related utility from Hadoop source repository
Posted by GitBox <gi...@apache.org>.
umamaheswararao merged pull request #2733:
URL: https://github.com/apache/ozone/pull/2733
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org