You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@myfaces.apache.org by Leonardo Uribe <lu...@gmail.com> on 2008/02/12 20:26:32 UTC
Can I add components to trinidad-sandbox
Hi
I have noted that now exists this on svn repo
http://svn.apache.org/repos/asf/myfaces/trinidad-sandbox/
I have a component to be added (tableFormLayout), but I don't know what
prefix use (trs, trhs, ) and if someone is working on other components
Should I wait to the module projects will be created?
regards
Leonardo Uribe
Re: Can I add components to trinidad-sandbox
Posted by Matthias Wessendorf <ma...@apache.org>.
hi
On Feb 13, 2008 11:38 AM, Carsten Pieper <ca...@continentale.de> wrote:
>
> Argh, that's happening when users are posting on the developers' forum ;-}
> (I have been told, that it's OK to do so... If not, please let me know)
sure, nothing wrong with your post.
>
> > Would you be interested to make the sandbox 1.1 compatible ?
> > We could apply your patches to a special 1.1 branch, just as one option.
> Er, to be honest, right now I don't have the slightest idea how to do that.
> Neither in general nor for the tableFormLayout... So I can't make any real
> statement.
>
> However, we'll look at it to get a clue... But even if we get the impression
> that we could give it a try for the tableFormLayout I surely can't promise,
> that we could / would take care for other components, that make it to the
> sandbox.
>
> Would that be OK for you or would you only start the 1.1 compatible branch
> with a dedicated sandbox keeper?
it is not up to me; the community has to make a decision.
Do we want a JSF 1.1 branch as well or not.
My vote would be -0
-Matthias
>
>
> Thanks, Carsten
>
>
> Matthias Wessendorf-4 wrote:
> >
> > Hi Carsten,
> >
> > On Feb 13, 2008 10:12 AM, Carsten Pieper <ca...@continentale.de>
> > wrote:
> >>
> >> Just to let you know:
> >>
> >> We love the idea of the Trinidad sandbox - especially with the
> >> newly improved tableFormLayout in it!
> >>
> >> But... we're still on Trinidad 1.0.x, so that we'd prefer the sandbox to
> >> be compatible with both "branches".
> >
> > I think that "JSF 1.1 vs JSF 1.2" is a difficult question.
> >
> > I tend to prefer new features make it into a JSF 1.2 version of the
> > sandbox;
> >
> > Would you be interested to make the sandbox 1.1 compatible ?
> > We could apply your patches to a special 1.1 branch, just as one option.
> >
> > -M
> >>
> >> Thanks, Carsten
> >>
> >>
> >>
> >> Matthias Wessendorf-4 wrote:
> >> >
> >> > Hi,
> >> >
> >> > On Feb 12, 2008 8:45 PM, Leonardo Uribe <lu...@gmail.com> wrote:
> >> >> Hi
> >> >>
> >> >> I have another question: trinidad sandbox should be for 1.2 ?
> >> >
> >> > +1 on that.
> >> >
> >> >>
> >> >> My component works if I do a light change on LabelAndMessageRenderer,
> >> can
> >> >> I
> >> >> change this class too?
> >> >>
> >> >> This is the patch file:
> >> >>
> >> >> Index:
> >> >>
> >> src/main/java/org/apache/myfaces/trinidadinternal/renderkit/core/xhtml/LabelAndMessageRenderer.java
> >> >> ===================================================================
> >> >> ---
> >> >>
> >> src/main/java/org/apache/myfaces/trinidadinternal/renderkit/core/xhtml/LabelAndMessageRenderer.java
> >> >> (revision 614757)
> >> >> +++
> >> >>
> >> src/main/java/org/apache/myfaces/trinidadinternal/renderkit/core/xhtml/LabelAndMessageRenderer.java
> >> >> (working copy)
> >> >> @@ -279,6 +279,27 @@
> >> >> }
> >> >> }
> >> >>
> >> >> + //This part is necessary to make work hspace on
> >> tr:tableFormLayout
> >> >> + Map<String, Object> requestMap = context.getExternalContext()
> >> >> + .getRequestMap();
> >> >> +
> >> >> + Integer hspaceObject = (Integer) requestMap.get(
> >> >> + "org.apache.myfaces.trinidadinternal.TableFormHspace");
> >> >> +
> >> >> + Boolean percentWidthObject = (Boolean) requestMap.get(
> >> >> +
> >> >> "org.apache.myfaces.trinidadinternal.TableFormPercentWidth");
> >> >> +
> >> >> + if (hspaceObject != null){
> >> >> +
> >> >> + rw.startElement("td", null);
> >> >> + if (percentWidthObject != null && percentWidthObject ==
> >> true){
> >> >> + rw.writeAttribute("width", hspaceObject +"%", null);
> >> >> + }else{
> >> >> + rw.writeAttribute("width", hspaceObject, null);
> >> >> + }
> >> >> + rw.endElement("td");
> >> >> + }
> >> >> +
> >> >> _renderFieldCell(context, arc, component, bean, labelExists,
> >> >> needsPanelFormLayout, isInline);
> >> >>
> >> >> @@ -787,7 +808,8 @@
> >> >> {
> >> >> return "org.apache.myfaces.trinidad.Form".equals(rendererType) ||
> >> >>
> >> "org.apache.myfaces.trinidad.FormLayout".equals(rendererType)
> >> >> ||
> >> >> - "org.apache.myfaces.trinidad.rich.Form".equals(rendererType);
> >> >> + "org.apache.myfaces.trinidad.rich.Form".equals(rendererType)
> >> ||
> >> >> +
> >> "org.apache.myfaces.trinidad.TableLayout".equals(rendererType);
> >> >> }
> >> >>
> >> >>
> >> >>
> >> >> How does your comp differ from "panelFormLayout" ?
> >> >>
> >> >> An example is this
> >> >>
> >> >> <mycomp:tableFormLayout width="1000"
> >> >> columns="1*;2*;1*;2*">
> >> >> <tr:outputText value="Layout Example:
> >> Personal
> >> >> Information" >
> >> >> <f:attribute name="spanX" value="4" />
> >> >> </tr:outputText>
> >> >>
> >> >> <tr:selectOneChoice label="Salutation">
> >> >> <f:selectItem itemLabel="1 Option"
> >> >> itemValue="1"
> >> >> />
> >> >> <f:selectItem itemLabel="2 Option"
> >> >> itemValue="2"/>
> >> >> </tr:selectOneChoice>
> >> >>
> >> >> <tr:outputText>
> >> >> <f:attribute name="spanX" value="2" />
> >> >> </tr:outputText>
> >> >>
> >> >> <tr:inputText label="First Name"
> >> >> required="true"/>
> >> >> <tr:inputText label="Last Name"
> >> >> required="true"/>
> >> >>
> >> >> <tr:inputText label="c/o" required="true">
> >> >> <f:attribute name="spanXItem" value="3"
> >> />
> >> >> </tr:inputText>
> >> >>
> >> >> <tr:inputText label="Street" required="true"/>
> >> >> <tr:inputText label="No" required="true"/>
> >> >> <tr:inputText label="ZIP" required="true"/>
> >> >> <tr:inputText label="City" required="true"/>
> >> >> <tr:inputText label="Note" rows="4"
> >> >> required="true">
> >> >> <f:attribute name="spanXItem" value="3" />
> >> >> </tr:inputText>
> >> >> </mycomp:tableFormLayout>
> >> >>
> >> >> It calculates widths, heights for each component and make all layout
> >> >> tasks
> >> >> (colspan and others) more easy.
> >> >>
> >> >> You can see an screenshot on TRINIDAD-115
> >> >
> >> > not done yet, thanks for the pointer.
> >> >
> >> > -M
> >> >
> >> >>
> >> >> regards
> >> >>
> >> >> Leonardo Uribe
> >> >>
> >> >
> >> >
> >> >
> >> > --
> >> > Matthias Wessendorf
> >> >
> >> > further stuff:
> >> > blog: http://matthiaswessendorf.wordpress.com/
> >> > sessions: http://www.slideshare.net/mwessendorf
> >> > mail: matzew-at-apache-dot-org
> >> >
> >> >
> >>
> >> --
> >> View this message in context:
> >> http://www.nabble.com/Can-I-add-components-to-trinidad-sandbox-tp15440908p15451860.html
> >> Sent from the My Faces - Dev mailing list archive at Nabble.com.
> >>
> >>
> >
> >
> >
> > --
> > Matthias Wessendorf
> >
> > further stuff:
> > blog: http://matthiaswessendorf.wordpress.com/
> > sessions: http://www.slideshare.net/mwessendorf
> > mail: matzew-at-apache-dot-org
> >
> >
>
> --
> View this message in context: http://www.nabble.com/Can-I-add-components-to-trinidad-sandbox-tp15440908p15454092.html
>
> Sent from the My Faces - Dev mailing list archive at Nabble.com.
>
>
--
Matthias Wessendorf
further stuff:
blog: http://matthiaswessendorf.wordpress.com/
sessions: http://www.slideshare.net/mwessendorf
mail: matzew-at-apache-dot-org
Re: Can I add components to trinidad-sandbox
Posted by Carsten Pieper <ca...@continentale.de>.
Argh, that's happening when users are posting on the developers' forum ;-}
(I have been told, that it's OK to do so... If not, please let me know)
> Would you be interested to make the sandbox 1.1 compatible ?
> We could apply your patches to a special 1.1 branch, just as one option.
Er, to be honest, right now I don't have the slightest idea how to do that.
Neither in general nor for the tableFormLayout... So I can't make any real
statement.
However, we'll look at it to get a clue... But even if we get the impression
that we could give it a try for the tableFormLayout I surely can't promise,
that we could / would take care for other components, that make it to the
sandbox.
Would that be OK for you or would you only start the 1.1 compatible branch
with a dedicated sandbox keeper?
Thanks, Carsten
Matthias Wessendorf-4 wrote:
>
> Hi Carsten,
>
> On Feb 13, 2008 10:12 AM, Carsten Pieper <ca...@continentale.de>
> wrote:
>>
>> Just to let you know:
>>
>> We love the idea of the Trinidad sandbox - especially with the
>> newly improved tableFormLayout in it!
>>
>> But... we're still on Trinidad 1.0.x, so that we'd prefer the sandbox to
>> be compatible with both "branches".
>
> I think that "JSF 1.1 vs JSF 1.2" is a difficult question.
>
> I tend to prefer new features make it into a JSF 1.2 version of the
> sandbox;
>
> Would you be interested to make the sandbox 1.1 compatible ?
> We could apply your patches to a special 1.1 branch, just as one option.
>
> -M
>>
>> Thanks, Carsten
>>
>>
>>
>> Matthias Wessendorf-4 wrote:
>> >
>> > Hi,
>> >
>> > On Feb 12, 2008 8:45 PM, Leonardo Uribe <lu...@gmail.com> wrote:
>> >> Hi
>> >>
>> >> I have another question: trinidad sandbox should be for 1.2 ?
>> >
>> > +1 on that.
>> >
>> >>
>> >> My component works if I do a light change on LabelAndMessageRenderer,
>> can
>> >> I
>> >> change this class too?
>> >>
>> >> This is the patch file:
>> >>
>> >> Index:
>> >>
>> src/main/java/org/apache/myfaces/trinidadinternal/renderkit/core/xhtml/LabelAndMessageRenderer.java
>> >> ===================================================================
>> >> ---
>> >>
>> src/main/java/org/apache/myfaces/trinidadinternal/renderkit/core/xhtml/LabelAndMessageRenderer.java
>> >> (revision 614757)
>> >> +++
>> >>
>> src/main/java/org/apache/myfaces/trinidadinternal/renderkit/core/xhtml/LabelAndMessageRenderer.java
>> >> (working copy)
>> >> @@ -279,6 +279,27 @@
>> >> }
>> >> }
>> >>
>> >> + //This part is necessary to make work hspace on
>> tr:tableFormLayout
>> >> + Map<String, Object> requestMap = context.getExternalContext()
>> >> + .getRequestMap();
>> >> +
>> >> + Integer hspaceObject = (Integer) requestMap.get(
>> >> + "org.apache.myfaces.trinidadinternal.TableFormHspace");
>> >> +
>> >> + Boolean percentWidthObject = (Boolean) requestMap.get(
>> >> +
>> >> "org.apache.myfaces.trinidadinternal.TableFormPercentWidth");
>> >> +
>> >> + if (hspaceObject != null){
>> >> +
>> >> + rw.startElement("td", null);
>> >> + if (percentWidthObject != null && percentWidthObject ==
>> true){
>> >> + rw.writeAttribute("width", hspaceObject +"%", null);
>> >> + }else{
>> >> + rw.writeAttribute("width", hspaceObject, null);
>> >> + }
>> >> + rw.endElement("td");
>> >> + }
>> >> +
>> >> _renderFieldCell(context, arc, component, bean, labelExists,
>> >> needsPanelFormLayout, isInline);
>> >>
>> >> @@ -787,7 +808,8 @@
>> >> {
>> >> return "org.apache.myfaces.trinidad.Form".equals(rendererType) ||
>> >>
>> "org.apache.myfaces.trinidad.FormLayout".equals(rendererType)
>> >> ||
>> >> - "org.apache.myfaces.trinidad.rich.Form".equals(rendererType);
>> >> + "org.apache.myfaces.trinidad.rich.Form".equals(rendererType)
>> ||
>> >> +
>> "org.apache.myfaces.trinidad.TableLayout".equals(rendererType);
>> >> }
>> >>
>> >>
>> >>
>> >> How does your comp differ from "panelFormLayout" ?
>> >>
>> >> An example is this
>> >>
>> >> <mycomp:tableFormLayout width="1000"
>> >> columns="1*;2*;1*;2*">
>> >> <tr:outputText value="Layout Example:
>> Personal
>> >> Information" >
>> >> <f:attribute name="spanX" value="4" />
>> >> </tr:outputText>
>> >>
>> >> <tr:selectOneChoice label="Salutation">
>> >> <f:selectItem itemLabel="1 Option"
>> >> itemValue="1"
>> >> />
>> >> <f:selectItem itemLabel="2 Option"
>> >> itemValue="2"/>
>> >> </tr:selectOneChoice>
>> >>
>> >> <tr:outputText>
>> >> <f:attribute name="spanX" value="2" />
>> >> </tr:outputText>
>> >>
>> >> <tr:inputText label="First Name"
>> >> required="true"/>
>> >> <tr:inputText label="Last Name"
>> >> required="true"/>
>> >>
>> >> <tr:inputText label="c/o" required="true">
>> >> <f:attribute name="spanXItem" value="3"
>> />
>> >> </tr:inputText>
>> >>
>> >> <tr:inputText label="Street" required="true"/>
>> >> <tr:inputText label="No" required="true"/>
>> >> <tr:inputText label="ZIP" required="true"/>
>> >> <tr:inputText label="City" required="true"/>
>> >> <tr:inputText label="Note" rows="4"
>> >> required="true">
>> >> <f:attribute name="spanXItem" value="3" />
>> >> </tr:inputText>
>> >> </mycomp:tableFormLayout>
>> >>
>> >> It calculates widths, heights for each component and make all layout
>> >> tasks
>> >> (colspan and others) more easy.
>> >>
>> >> You can see an screenshot on TRINIDAD-115
>> >
>> > not done yet, thanks for the pointer.
>> >
>> > -M
>> >
>> >>
>> >> regards
>> >>
>> >> Leonardo Uribe
>> >>
>> >
>> >
>> >
>> > --
>> > Matthias Wessendorf
>> >
>> > further stuff:
>> > blog: http://matthiaswessendorf.wordpress.com/
>> > sessions: http://www.slideshare.net/mwessendorf
>> > mail: matzew-at-apache-dot-org
>> >
>> >
>>
>> --
>> View this message in context:
>> http://www.nabble.com/Can-I-add-components-to-trinidad-sandbox-tp15440908p15451860.html
>> Sent from the My Faces - Dev mailing list archive at Nabble.com.
>>
>>
>
>
>
> --
> Matthias Wessendorf
>
> further stuff:
> blog: http://matthiaswessendorf.wordpress.com/
> sessions: http://www.slideshare.net/mwessendorf
> mail: matzew-at-apache-dot-org
>
>
--
View this message in context: http://www.nabble.com/Can-I-add-components-to-trinidad-sandbox-tp15440908p15454092.html
Sent from the My Faces - Dev mailing list archive at Nabble.com.
Re: Can I add components to trinidad-sandbox
Posted by Leonardo Uribe <lu...@gmail.com>.
+1
Re: Can I add components to trinidad-sandbox
Posted by Matthias Wessendorf <ma...@apache.org>.
On Feb 13, 2008 5:45 PM, Andrew Robinson <an...@gmail.com> wrote:
> So would everyone be on-board with this structure?
>
> https://svn.apache.org/repos/asf/myfaces/trinidad/trunk(_1.2.x)/trinidad-sandbox/
>
> https://svn.apache.org/repos/asf/myfaces/trinidad/trunk(_1.2.x)/trinidad-sandbox/sandbox-build
> https://svn.apache.org/repos/asf/myfaces/trinidad/trunk(_1.2.x)/trinidad-sandbox/sandbox-api
>
> https://svn.apache.org/repos/asf/myfaces/trinidad/trunk(_1.2.x)/trinidad-sandbox/sandbox-impl
> https://svn.apache.org/repos/asf/myfaces/trinidad/trunk(_1.2.x)/trinidad-sandbox/sandbox-demo
>
> https://svn.apache.org/repos/asf/myfaces/trinidad/trunk(_1.2.x)/trinidad-sandbox/src
> (this last one would be the site)
+1
>
>
>
> On Feb 13, 2008 9:39 AM, Matthias Wessendorf <ma...@apache.org> wrote:
> >
> > On Feb 13, 2008 5:32 PM, Andrew Robinson <an...@gmail.com>
> wrote:
> > > Instead of a long drawn out debate, why don't we create the sanbox under
> the
> > > trinidad folder like tomahawk so that there is a sandbox under the 1.2
> trunk
> > > as well as the 1.0 trunk.
> >
> > you/we could do that.
> > I was about to start with the *sandbox*, but got stuck due to some
> > other things...
> > -M
> >
> >
> >
> >
> > >
> > >
> > >
> > > On Feb 13, 2008 2:41 AM, Matthias Wessendorf <ma...@apache.org> wrote:
> > >
> > > > Hi Carsten,
> > > >
> > > >
> > > > On Feb 13, 2008 10:12 AM, Carsten Pieper
> <ca...@continentale.de>
> > > wrote:
> > > > >
> > > > > Just to let you know:
> > > > >
> > > > > We love the idea of the Trinidad sandbox - especially with the
> > > > > newly improved tableFormLayout in it!
> > > > >
> > > > > But... we're still on Trinidad 1.0.x, so that we'd prefer the
> sandbox to
> > > > > be compatible with both "branches".
> > > >
> > > > I think that "JSF 1.1 vs JSF 1.2" is a difficult question.
> > > >
> > > > I tend to prefer new features make it into a JSF 1.2 version of the
> > > sandbox;
> > > >
> > > > Would you be interested to make the sandbox 1.1 compatible ?
> > > > We could apply your patches to a special 1.1 branch, just as one
> option.
> > > >
> > > > -M
> > > >
> > > >
> > > >
> > > > >
> > > > > Thanks, Carsten
> > > > >
> > > > >
> > > > >
> > > > > Matthias Wessendorf-4 wrote:
> > > > > >
> > > > > > Hi,
> > > > > >
> > > > > > On Feb 12, 2008 8:45 PM, Leonardo Uribe <lu...@gmail.com> wrote:
> > > > > >> Hi
> > > > > >>
> > > > > >> I have another question: trinidad sandbox should be for 1.2 ?
> > > > > >
> > > > > > +1 on that.
> > > > > >
> > > > > >>
> > > > > >> My component works if I do a light change on
> LabelAndMessageRenderer,
> > > can
> > > > > >> I
> > > > > >> change this class too?
> > > > > >>
> > > > > >> This is the patch file:
> > > > > >>
> > > > > >> Index:
> > > > > >>
> > >
> src/main/java/org/apache/myfaces/trinidadinternal/renderkit/core/xhtml/LabelAndMessageRenderer.java
> > > > > >>
> ===================================================================
> > > > > >> ---
> > > > > >>
> > >
> src/main/java/org/apache/myfaces/trinidadinternal/renderkit/core/xhtml/LabelAndMessageRenderer.java
> > > > > >> (revision 614757)
> > > > > >> +++
> > > > > >>
> > >
> src/main/java/org/apache/myfaces/trinidadinternal/renderkit/core/xhtml/LabelAndMessageRenderer.java
> > > > > >> (working copy)
> > > > > >> @@ -279,6 +279,27 @@
> > > > > >> }
> > > > > >> }
> > > > > >>
> > > > > >> + //This part is necessary to make work hspace on
> > > tr:tableFormLayout
> > > > > >> + Map<String, Object> requestMap =
> context.getExternalContext()
> > > > > >> + .getRequestMap();
> > > > > >> +
> > > > > >> + Integer hspaceObject = (Integer) requestMap.get(
> > > > > >> +
> > > "org.apache.myfaces.trinidadinternal.TableFormHspace");
> > > > > >> +
> > > > > >> + Boolean percentWidthObject = (Boolean) requestMap.get(
> > > > > >> +
> > > > > >> "org.apache.myfaces.trinidadinternal.TableFormPercentWidth");
> > > > > >> +
> > > > > >> + if (hspaceObject != null){
> > > > > >> +
> > > > > >> + rw.startElement("td", null);
> > > > > >> + if (percentWidthObject != null && percentWidthObject
> ==
> > > true){
> > > > > >> + rw.writeAttribute("width", hspaceObject +"%",
> null);
> > > > > >> + }else{
> > > > > >> + rw.writeAttribute("width", hspaceObject, null);
> > > > > >> + }
> > > > > >> + rw.endElement("td");
> > > > > >> + }
> > > > > >> +
> > > > > >> _renderFieldCell(context, arc, component, bean,
> labelExists,
> > > > > >> needsPanelFormLayout, isInline);
> > > > > >>
> > > > > >> @@ -787,7 +808,8 @@
> > > > > >> {
> > > > > >> return
> "org.apache.myfaces.trinidad.Form".equals(rendererType)
> > > ||
> > > > > >>
> > > "org.apache.myfaces.trinidad.FormLayout".equals(rendererType)
> > > > > >> ||
> > > > > >> -
> > > "org.apache.myfaces.trinidad.rich.Form".equals(rendererType);
> > > > > >> +
> "org.apache.myfaces.trinidad.rich.Form".equals(rendererType)
> > > ||
> > > > > >> +
> > > "org.apache.myfaces.trinidad.TableLayout".equals(rendererType);
> > > > > >> }
> > > > > >>
> > > > > >>
> > > > > >>
> > > > > >> How does your comp differ from "panelFormLayout" ?
> > > > > >>
> > > > > >> An example is this
> > > > > >>
> > > > > >> <mycomp:tableFormLayout width="1000"
> > > > > >> columns="1*;2*;1*;2*">
> > > > > >> <tr:outputText value="Layout Example:
> > > Personal
> > > > > >> Information" >
> > > > > >> <f:attribute name="spanX" value="4"
> />
> > > > > >> </tr:outputText>
> > > > > >>
> > > > > >> <tr:selectOneChoice label="Salutation">
> > > > > >> <f:selectItem itemLabel="1 Option"
> > > > > >> itemValue="1"
> > > > > >> />
> > > > > >> <f:selectItem itemLabel="2 Option"
> > > > > >> itemValue="2"/>
> > > > > >> </tr:selectOneChoice>
> > > > > >>
> > > > > >> <tr:outputText>
> > > > > >> <f:attribute name="spanX" value="2"
> />
> > > > > >> </tr:outputText>
> > > > > >>
> > > > > >> <tr:inputText label="First Name"
> > > > > >> required="true"/>
> > > > > >> <tr:inputText label="Last Name"
> > > > > >> required="true"/>
> > > > > >>
> > > > > >> <tr:inputText label="c/o"
> required="true">
> > > > > >> <f:attribute name="spanXItem"
> value="3"
> > > />
> > > > > >> </tr:inputText>
> > > > > >>
> > > > > >> <tr:inputText label="Street"
> > > required="true"/>
> > > > > >> <tr:inputText label="No"
> required="true"/>
> > > > > >> <tr:inputText label="ZIP"
> required="true"/>
> > > > > >> <tr:inputText label="City"
> required="true"/>
> > > > > >> <tr:inputText label="Note" rows="4"
> > > > > >> required="true">
> > > > > >> <f:attribute name="spanXItem"
> value="3"
> > > />
> > > > > >> </tr:inputText>
> > > > > >> </mycomp:tableFormLayout>
> > > > > >>
> > > > > >> It calculates widths, heights for each component and make all
> layout
> > > > > >> tasks
> > > > > >> (colspan and others) more easy.
> > > > > >>
> > > > > >> You can see an screenshot on TRINIDAD-115
> > > > > >
> > > > > > not done yet, thanks for the pointer.
> > > > > >
> > > > > > -M
> > > > > >
> > > > > >>
> > > > > >> regards
> > > > > >>
> > > > > >> Leonardo Uribe
> > > > > >>
> > > > > >
> > > > > >
> > > > > >
> > > > > > --
> > > > > > Matthias Wessendorf
> > > > > >
> > > > > > further stuff:
> > > > > > blog: http://matthiaswessendorf.wordpress.com/
> > > > > > sessions: http://www.slideshare.net/mwessendorf
> > > > > > mail: matzew-at-apache-dot-org
> > > > > >
> > > > > >
> > > > >
> > > > > --
> > > > > View this message in context:
> > >
> http://www.nabble.com/Can-I-add-components-to-trinidad-sandbox-tp15440908p15451860.html
> > > > > Sent from the My Faces - Dev mailing list archive at Nabble.com.
> > > > >
> > > > >
> > > >
> > > >
> > > >
> > > > --
> > > > Matthias Wessendorf
> > > >
> > > > further stuff:
> > > > blog: http://matthiaswessendorf.wordpress.com/
> > > > sessions: http://www.slideshare.net/mwessendorf
> > > > mail: matzew-at-apache-dot-org
> > > >
> > >
> > >
> >
> >
> >
> > --
> >
> >
> >
> > Matthias Wessendorf
> >
> > further stuff:
> > blog: http://matthiaswessendorf.wordpress.com/
> > sessions: http://www.slideshare.net/mwessendorf
> > mail: matzew-at-apache-dot-org
> >
>
>
--
Matthias Wessendorf
further stuff:
blog: http://matthiaswessendorf.wordpress.com/
sessions: http://www.slideshare.net/mwessendorf
mail: matzew-at-apache-dot-org
Re: Can I add components to trinidad-sandbox
Posted by Andrew Robinson <an...@gmail.com>.
So would everyone be on-board with this structure?
https://svn.apache.org/repos/asf/myfaces/trinidad/trunk(_1.2.x)/trinidad-sandbox/
https://svn.apache.org/repos/asf/myfaces/trinidad/trunk(_1.2.x)/trinidad-sandbox/sandbox-build
https://svn.apache.org/repos/asf/myfaces/trinidad/trunk(_1.2.x)/trinidad-sandbox/sandbox-api
https://svn.apache.org/repos/asf/myfaces/trinidad/trunk(_1.2.x)/trinidad-sandbox/sandbox-impl
https://svn.apache.org/repos/asf/myfaces/trinidad/trunk(_1.2.x)/trinidad-sandbox/sandbox-demo
https://svn.apache.org/repos/asf/myfaces/trinidad/trunk(_1.2.x)/trinidad-sandbox/src
(this last one would be the site)
On Feb 13, 2008 9:39 AM, Matthias Wessendorf <ma...@apache.org> wrote:
> On Feb 13, 2008 5:32 PM, Andrew Robinson <an...@gmail.com>
> wrote:
> > Instead of a long drawn out debate, why don't we create the sanbox under
> the
> > trinidad folder like tomahawk so that there is a sandbox under the 1.2trunk
> > as well as the 1.0 trunk.
>
> you/we could do that.
> I was about to start with the *sandbox*, but got stuck due to some
> other things...
> -M
>
> >
> >
> >
> > On Feb 13, 2008 2:41 AM, Matthias Wessendorf <ma...@apache.org> wrote:
> >
> > > Hi Carsten,
> > >
> > >
> > > On Feb 13, 2008 10:12 AM, Carsten Pieper <
> carsten.pieper@continentale.de>
> > wrote:
> > > >
> > > > Just to let you know:
> > > >
> > > > We love the idea of the Trinidad sandbox - especially with the
> > > > newly improved tableFormLayout in it!
> > > >
> > > > But... we're still on Trinidad 1.0.x, so that we'd prefer the
> sandbox to
> > > > be compatible with both "branches".
> > >
> > > I think that "JSF 1.1 vs JSF 1.2" is a difficult question.
> > >
> > > I tend to prefer new features make it into a JSF 1.2 version of the
> > sandbox;
> > >
> > > Would you be interested to make the sandbox 1.1 compatible ?
> > > We could apply your patches to a special 1.1 branch, just as one
> option.
> > >
> > > -M
> > >
> > >
> > >
> > > >
> > > > Thanks, Carsten
> > > >
> > > >
> > > >
> > > > Matthias Wessendorf-4 wrote:
> > > > >
> > > > > Hi,
> > > > >
> > > > > On Feb 12, 2008 8:45 PM, Leonardo Uribe <lu...@gmail.com> wrote:
> > > > >> Hi
> > > > >>
> > > > >> I have another question: trinidad sandbox should be for 1.2 ?
> > > > >
> > > > > +1 on that.
> > > > >
> > > > >>
> > > > >> My component works if I do a light change on
> LabelAndMessageRenderer,
> > can
> > > > >> I
> > > > >> change this class too?
> > > > >>
> > > > >> This is the patch file:
> > > > >>
> > > > >> Index:
> > > > >>
> >
> src/main/java/org/apache/myfaces/trinidadinternal/renderkit/core/xhtml/LabelAndMessageRenderer.java
> > > > >>
> ===================================================================
> > > > >> ---
> > > > >>
> >
> src/main/java/org/apache/myfaces/trinidadinternal/renderkit/core/xhtml/LabelAndMessageRenderer.java
> > > > >> (revision 614757)
> > > > >> +++
> > > > >>
> >
> src/main/java/org/apache/myfaces/trinidadinternal/renderkit/core/xhtml/LabelAndMessageRenderer.java
> > > > >> (working copy)
> > > > >> @@ -279,6 +279,27 @@
> > > > >> }
> > > > >> }
> > > > >>
> > > > >> + //This part is necessary to make work hspace on
> > tr:tableFormLayout
> > > > >> + Map<String, Object> requestMap =
> context.getExternalContext()
> > > > >> + .getRequestMap();
> > > > >> +
> > > > >> + Integer hspaceObject = (Integer) requestMap.get(
> > > > >> +
> > "org.apache.myfaces.trinidadinternal.TableFormHspace");
> > > > >> +
> > > > >> + Boolean percentWidthObject = (Boolean) requestMap.get(
> > > > >> +
> > > > >> "org.apache.myfaces.trinidadinternal.TableFormPercentWidth");
> > > > >> +
> > > > >> + if (hspaceObject != null){
> > > > >> +
> > > > >> + rw.startElement("td", null);
> > > > >> + if (percentWidthObject != null && percentWidthObject
> ==
> > true){
> > > > >> + rw.writeAttribute("width", hspaceObject +"%",
> null);
> > > > >> + }else{
> > > > >> + rw.writeAttribute("width", hspaceObject, null);
> > > > >> + }
> > > > >> + rw.endElement("td");
> > > > >> + }
> > > > >> +
> > > > >> _renderFieldCell(context, arc, component, bean,
> labelExists,
> > > > >> needsPanelFormLayout, isInline);
> > > > >>
> > > > >> @@ -787,7 +808,8 @@
> > > > >> {
> > > > >> return "org.apache.myfaces.trinidad.Form
> ".equals(rendererType)
> > ||
> > > > >>
> > "org.apache.myfaces.trinidad.FormLayout".equals(rendererType)
> > > > >> ||
> > > > >> -
> > "org.apache.myfaces.trinidad.rich.Form".equals(rendererType);
> > > > >> + "org.apache.myfaces.trinidad.rich.Form
> ".equals(rendererType)
> > ||
> > > > >> +
> > "org.apache.myfaces.trinidad.TableLayout".equals(rendererType);
> > > > >> }
> > > > >>
> > > > >>
> > > > >>
> > > > >> How does your comp differ from "panelFormLayout" ?
> > > > >>
> > > > >> An example is this
> > > > >>
> > > > >> <mycomp:tableFormLayout width="1000"
> > > > >> columns="1*;2*;1*;2*">
> > > > >> <tr:outputText value="Layout Example:
> > Personal
> > > > >> Information" >
> > > > >> <f:attribute name="spanX" value="4"
> />
> > > > >> </tr:outputText>
> > > > >>
> > > > >> <tr:selectOneChoice label="Salutation">
> > > > >> <f:selectItem itemLabel="1 Option"
> > > > >> itemValue="1"
> > > > >> />
> > > > >> <f:selectItem itemLabel="2 Option"
> > > > >> itemValue="2"/>
> > > > >> </tr:selectOneChoice>
> > > > >>
> > > > >> <tr:outputText>
> > > > >> <f:attribute name="spanX" value="2"
> />
> > > > >> </tr:outputText>
> > > > >>
> > > > >> <tr:inputText label="First Name"
> > > > >> required="true"/>
> > > > >> <tr:inputText label="Last Name"
> > > > >> required="true"/>
> > > > >>
> > > > >> <tr:inputText label="c/o"
> required="true">
> > > > >> <f:attribute name="spanXItem"
> value="3"
> > />
> > > > >> </tr:inputText>
> > > > >>
> > > > >> <tr:inputText label="Street"
> > required="true"/>
> > > > >> <tr:inputText label="No"
> required="true"/>
> > > > >> <tr:inputText label="ZIP"
> required="true"/>
> > > > >> <tr:inputText label="City"
> required="true"/>
> > > > >> <tr:inputText label="Note" rows="4"
> > > > >> required="true">
> > > > >> <f:attribute name="spanXItem"
> value="3"
> > />
> > > > >> </tr:inputText>
> > > > >> </mycomp:tableFormLayout>
> > > > >>
> > > > >> It calculates widths, heights for each component and make all
> layout
> > > > >> tasks
> > > > >> (colspan and others) more easy.
> > > > >>
> > > > >> You can see an screenshot on TRINIDAD-115
> > > > >
> > > > > not done yet, thanks for the pointer.
> > > > >
> > > > > -M
> > > > >
> > > > >>
> > > > >> regards
> > > > >>
> > > > >> Leonardo Uribe
> > > > >>
> > > > >
> > > > >
> > > > >
> > > > > --
> > > > > Matthias Wessendorf
> > > > >
> > > > > further stuff:
> > > > > blog: http://matthiaswessendorf.wordpress.com/
> > > > > sessions: http://www.slideshare.net/mwessendorf
> > > > > mail: matzew-at-apache-dot-org
> > > > >
> > > > >
> > > >
> > > > --
> > > > View this message in context:
> >
> http://www.nabble.com/Can-I-add-components-to-trinidad-sandbox-tp15440908p15451860.html
> > > > Sent from the My Faces - Dev mailing list archive at Nabble.com.
> > > >
> > > >
> > >
> > >
> > >
> > > --
> > > Matthias Wessendorf
> > >
> > > further stuff:
> > > blog: http://matthiaswessendorf.wordpress.com/
> > > sessions: http://www.slideshare.net/mwessendorf
> > > mail: matzew-at-apache-dot-org
> > >
> >
> >
>
>
>
> --
> Matthias Wessendorf
>
> further stuff:
> blog: http://matthiaswessendorf.wordpress.com/
> sessions: http://www.slideshare.net/mwessendorf
> mail: matzew-at-apache-dot-org
>
Re: Can I add components to trinidad-sandbox
Posted by Matthias Wessendorf <ma...@apache.org>.
On Feb 13, 2008 5:32 PM, Andrew Robinson <an...@gmail.com> wrote:
> Instead of a long drawn out debate, why don't we create the sanbox under the
> trinidad folder like tomahawk so that there is a sandbox under the 1.2 trunk
> as well as the 1.0 trunk.
you/we could do that.
I was about to start with the *sandbox*, but got stuck due to some
other things...
-M
>
>
>
> On Feb 13, 2008 2:41 AM, Matthias Wessendorf <ma...@apache.org> wrote:
>
> > Hi Carsten,
> >
> >
> > On Feb 13, 2008 10:12 AM, Carsten Pieper <ca...@continentale.de>
> wrote:
> > >
> > > Just to let you know:
> > >
> > > We love the idea of the Trinidad sandbox - especially with the
> > > newly improved tableFormLayout in it!
> > >
> > > But... we're still on Trinidad 1.0.x, so that we'd prefer the sandbox to
> > > be compatible with both "branches".
> >
> > I think that "JSF 1.1 vs JSF 1.2" is a difficult question.
> >
> > I tend to prefer new features make it into a JSF 1.2 version of the
> sandbox;
> >
> > Would you be interested to make the sandbox 1.1 compatible ?
> > We could apply your patches to a special 1.1 branch, just as one option.
> >
> > -M
> >
> >
> >
> > >
> > > Thanks, Carsten
> > >
> > >
> > >
> > > Matthias Wessendorf-4 wrote:
> > > >
> > > > Hi,
> > > >
> > > > On Feb 12, 2008 8:45 PM, Leonardo Uribe <lu...@gmail.com> wrote:
> > > >> Hi
> > > >>
> > > >> I have another question: trinidad sandbox should be for 1.2 ?
> > > >
> > > > +1 on that.
> > > >
> > > >>
> > > >> My component works if I do a light change on LabelAndMessageRenderer,
> can
> > > >> I
> > > >> change this class too?
> > > >>
> > > >> This is the patch file:
> > > >>
> > > >> Index:
> > > >>
> src/main/java/org/apache/myfaces/trinidadinternal/renderkit/core/xhtml/LabelAndMessageRenderer.java
> > > >> ===================================================================
> > > >> ---
> > > >>
> src/main/java/org/apache/myfaces/trinidadinternal/renderkit/core/xhtml/LabelAndMessageRenderer.java
> > > >> (revision 614757)
> > > >> +++
> > > >>
> src/main/java/org/apache/myfaces/trinidadinternal/renderkit/core/xhtml/LabelAndMessageRenderer.java
> > > >> (working copy)
> > > >> @@ -279,6 +279,27 @@
> > > >> }
> > > >> }
> > > >>
> > > >> + //This part is necessary to make work hspace on
> tr:tableFormLayout
> > > >> + Map<String, Object> requestMap = context.getExternalContext()
> > > >> + .getRequestMap();
> > > >> +
> > > >> + Integer hspaceObject = (Integer) requestMap.get(
> > > >> +
> "org.apache.myfaces.trinidadinternal.TableFormHspace");
> > > >> +
> > > >> + Boolean percentWidthObject = (Boolean) requestMap.get(
> > > >> +
> > > >> "org.apache.myfaces.trinidadinternal.TableFormPercentWidth");
> > > >> +
> > > >> + if (hspaceObject != null){
> > > >> +
> > > >> + rw.startElement("td", null);
> > > >> + if (percentWidthObject != null && percentWidthObject ==
> true){
> > > >> + rw.writeAttribute("width", hspaceObject +"%", null);
> > > >> + }else{
> > > >> + rw.writeAttribute("width", hspaceObject, null);
> > > >> + }
> > > >> + rw.endElement("td");
> > > >> + }
> > > >> +
> > > >> _renderFieldCell(context, arc, component, bean, labelExists,
> > > >> needsPanelFormLayout, isInline);
> > > >>
> > > >> @@ -787,7 +808,8 @@
> > > >> {
> > > >> return "org.apache.myfaces.trinidad.Form".equals(rendererType)
> ||
> > > >>
> "org.apache.myfaces.trinidad.FormLayout".equals(rendererType)
> > > >> ||
> > > >> -
> "org.apache.myfaces.trinidad.rich.Form".equals(rendererType);
> > > >> + "org.apache.myfaces.trinidad.rich.Form".equals(rendererType)
> ||
> > > >> +
> "org.apache.myfaces.trinidad.TableLayout".equals(rendererType);
> > > >> }
> > > >>
> > > >>
> > > >>
> > > >> How does your comp differ from "panelFormLayout" ?
> > > >>
> > > >> An example is this
> > > >>
> > > >> <mycomp:tableFormLayout width="1000"
> > > >> columns="1*;2*;1*;2*">
> > > >> <tr:outputText value="Layout Example:
> Personal
> > > >> Information" >
> > > >> <f:attribute name="spanX" value="4" />
> > > >> </tr:outputText>
> > > >>
> > > >> <tr:selectOneChoice label="Salutation">
> > > >> <f:selectItem itemLabel="1 Option"
> > > >> itemValue="1"
> > > >> />
> > > >> <f:selectItem itemLabel="2 Option"
> > > >> itemValue="2"/>
> > > >> </tr:selectOneChoice>
> > > >>
> > > >> <tr:outputText>
> > > >> <f:attribute name="spanX" value="2" />
> > > >> </tr:outputText>
> > > >>
> > > >> <tr:inputText label="First Name"
> > > >> required="true"/>
> > > >> <tr:inputText label="Last Name"
> > > >> required="true"/>
> > > >>
> > > >> <tr:inputText label="c/o" required="true">
> > > >> <f:attribute name="spanXItem" value="3"
> />
> > > >> </tr:inputText>
> > > >>
> > > >> <tr:inputText label="Street"
> required="true"/>
> > > >> <tr:inputText label="No" required="true"/>
> > > >> <tr:inputText label="ZIP" required="true"/>
> > > >> <tr:inputText label="City" required="true"/>
> > > >> <tr:inputText label="Note" rows="4"
> > > >> required="true">
> > > >> <f:attribute name="spanXItem" value="3"
> />
> > > >> </tr:inputText>
> > > >> </mycomp:tableFormLayout>
> > > >>
> > > >> It calculates widths, heights for each component and make all layout
> > > >> tasks
> > > >> (colspan and others) more easy.
> > > >>
> > > >> You can see an screenshot on TRINIDAD-115
> > > >
> > > > not done yet, thanks for the pointer.
> > > >
> > > > -M
> > > >
> > > >>
> > > >> regards
> > > >>
> > > >> Leonardo Uribe
> > > >>
> > > >
> > > >
> > > >
> > > > --
> > > > Matthias Wessendorf
> > > >
> > > > further stuff:
> > > > blog: http://matthiaswessendorf.wordpress.com/
> > > > sessions: http://www.slideshare.net/mwessendorf
> > > > mail: matzew-at-apache-dot-org
> > > >
> > > >
> > >
> > > --
> > > View this message in context:
> http://www.nabble.com/Can-I-add-components-to-trinidad-sandbox-tp15440908p15451860.html
> > > Sent from the My Faces - Dev mailing list archive at Nabble.com.
> > >
> > >
> >
> >
> >
> > --
> > Matthias Wessendorf
> >
> > further stuff:
> > blog: http://matthiaswessendorf.wordpress.com/
> > sessions: http://www.slideshare.net/mwessendorf
> > mail: matzew-at-apache-dot-org
> >
>
>
--
Matthias Wessendorf
further stuff:
blog: http://matthiaswessendorf.wordpress.com/
sessions: http://www.slideshare.net/mwessendorf
mail: matzew-at-apache-dot-org
Re: Can I add components to trinidad-sandbox
Posted by Andrew Robinson <an...@gmail.com>.
Instead of a long drawn out debate, why don't we create the sanbox under the
trinidad folder like tomahawk so that there is a sandbox under the 1.2 trunk
as well as the 1.0 trunk.
On Feb 13, 2008 2:41 AM, Matthias Wessendorf <ma...@apache.org> wrote:
> Hi Carsten,
>
> On Feb 13, 2008 10:12 AM, Carsten Pieper <ca...@continentale.de>
> wrote:
> >
> > Just to let you know:
> >
> > We love the idea of the Trinidad sandbox - especially with the
> > newly improved tableFormLayout in it!
> >
> > But... we're still on Trinidad 1.0.x, so that we'd prefer the sandbox to
> > be compatible with both "branches".
>
> I think that "JSF 1.1 vs JSF 1.2" is a difficult question.
>
> I tend to prefer new features make it into a JSF 1.2 version of the
> sandbox;
>
> Would you be interested to make the sandbox 1.1 compatible ?
> We could apply your patches to a special 1.1 branch, just as one option.
>
> -M
> >
> > Thanks, Carsten
> >
> >
> >
> > Matthias Wessendorf-4 wrote:
> > >
> > > Hi,
> > >
> > > On Feb 12, 2008 8:45 PM, Leonardo Uribe <lu...@gmail.com> wrote:
> > >> Hi
> > >>
> > >> I have another question: trinidad sandbox should be for 1.2 ?
> > >
> > > +1 on that.
> > >
> > >>
> > >> My component works if I do a light change on LabelAndMessageRenderer,
> can
> > >> I
> > >> change this class too?
> > >>
> > >> This is the patch file:
> > >>
> > >> Index:
> > >>
> src/main/java/org/apache/myfaces/trinidadinternal/renderkit/core/xhtml/LabelAndMessageRenderer.java
> > >> ===================================================================
> > >> ---
> > >>
> src/main/java/org/apache/myfaces/trinidadinternal/renderkit/core/xhtml/LabelAndMessageRenderer.java
> > >> (revision 614757)
> > >> +++
> > >>
> src/main/java/org/apache/myfaces/trinidadinternal/renderkit/core/xhtml/LabelAndMessageRenderer.java
> > >> (working copy)
> > >> @@ -279,6 +279,27 @@
> > >> }
> > >> }
> > >>
> > >> + //This part is necessary to make work hspace on
> tr:tableFormLayout
> > >> + Map<String, Object> requestMap = context.getExternalContext()
> > >> + .getRequestMap();
> > >> +
> > >> + Integer hspaceObject = (Integer) requestMap.get(
> > >> + "org.apache.myfaces.trinidadinternal.TableFormHspace
> ");
> > >> +
> > >> + Boolean percentWidthObject = (Boolean) requestMap.get(
> > >> +
> > >> "org.apache.myfaces.trinidadinternal.TableFormPercentWidth");
> > >> +
> > >> + if (hspaceObject != null){
> > >> +
> > >> + rw.startElement("td", null);
> > >> + if (percentWidthObject != null && percentWidthObject ==
> true){
> > >> + rw.writeAttribute("width", hspaceObject +"%", null);
> > >> + }else{
> > >> + rw.writeAttribute("width", hspaceObject, null);
> > >> + }
> > >> + rw.endElement("td");
> > >> + }
> > >> +
> > >> _renderFieldCell(context, arc, component, bean, labelExists,
> > >> needsPanelFormLayout, isInline);
> > >>
> > >> @@ -787,7 +808,8 @@
> > >> {
> > >> return "org.apache.myfaces.trinidad.Form".equals(rendererType)
> ||
> > >> "org.apache.myfaces.trinidad.FormLayout
> ".equals(rendererType)
> > >> ||
> > >> - "org.apache.myfaces.trinidad.rich.Form
> ".equals(rendererType);
> > >> + "org.apache.myfaces.trinidad.rich.Form".equals(rendererType)
> ||
> > >> + "org.apache.myfaces.trinidad.TableLayout
> ".equals(rendererType);
> > >> }
> > >>
> > >>
> > >>
> > >> How does your comp differ from "panelFormLayout" ?
> > >>
> > >> An example is this
> > >>
> > >> <mycomp:tableFormLayout width="1000"
> > >> columns="1*;2*;1*;2*">
> > >> <tr:outputText value="Layout Example:
> Personal
> > >> Information" >
> > >> <f:attribute name="spanX" value="4" />
> > >> </tr:outputText>
> > >>
> > >> <tr:selectOneChoice label="Salutation">
> > >> <f:selectItem itemLabel="1 Option"
> > >> itemValue="1"
> > >> />
> > >> <f:selectItem itemLabel="2 Option"
> > >> itemValue="2"/>
> > >> </tr:selectOneChoice>
> > >>
> > >> <tr:outputText>
> > >> <f:attribute name="spanX" value="2" />
> > >> </tr:outputText>
> > >>
> > >> <tr:inputText label="First Name"
> > >> required="true"/>
> > >> <tr:inputText label="Last Name"
> > >> required="true"/>
> > >>
> > >> <tr:inputText label="c/o" required="true">
> > >> <f:attribute name="spanXItem" value="3"
> />
> > >> </tr:inputText>
> > >>
> > >> <tr:inputText label="Street"
> required="true"/>
> > >> <tr:inputText label="No" required="true"/>
> > >> <tr:inputText label="ZIP" required="true"/>
> > >> <tr:inputText label="City" required="true"/>
> > >> <tr:inputText label="Note" rows="4"
> > >> required="true">
> > >> <f:attribute name="spanXItem" value="3"
> />
> > >> </tr:inputText>
> > >> </mycomp:tableFormLayout>
> > >>
> > >> It calculates widths, heights for each component and make all layout
> > >> tasks
> > >> (colspan and others) more easy.
> > >>
> > >> You can see an screenshot on TRINIDAD-115
> > >
> > > not done yet, thanks for the pointer.
> > >
> > > -M
> > >
> > >>
> > >> regards
> > >>
> > >> Leonardo Uribe
> > >>
> > >
> > >
> > >
> > > --
> > > Matthias Wessendorf
> > >
> > > further stuff:
> > > blog: http://matthiaswessendorf.wordpress.com/
> > > sessions: http://www.slideshare.net/mwessendorf
> > > mail: matzew-at-apache-dot-org
> > >
> > >
> >
> > --
> > View this message in context:
> http://www.nabble.com/Can-I-add-components-to-trinidad-sandbox-tp15440908p15451860.html
> > Sent from the My Faces - Dev mailing list archive at Nabble.com.
> >
> >
>
>
>
> --
> Matthias Wessendorf
>
> further stuff:
> blog: http://matthiaswessendorf.wordpress.com/
> sessions: http://www.slideshare.net/mwessendorf
> mail: matzew-at-apache-dot-org
>
Re: Can I add components to trinidad-sandbox
Posted by Matthias Wessendorf <ma...@apache.org>.
Hi Carsten,
On Feb 13, 2008 10:12 AM, Carsten Pieper <ca...@continentale.de> wrote:
>
> Just to let you know:
>
> We love the idea of the Trinidad sandbox - especially with the
> newly improved tableFormLayout in it!
>
> But... we're still on Trinidad 1.0.x, so that we'd prefer the sandbox to
> be compatible with both "branches".
I think that "JSF 1.1 vs JSF 1.2" is a difficult question.
I tend to prefer new features make it into a JSF 1.2 version of the sandbox;
Would you be interested to make the sandbox 1.1 compatible ?
We could apply your patches to a special 1.1 branch, just as one option.
-M
>
> Thanks, Carsten
>
>
>
> Matthias Wessendorf-4 wrote:
> >
> > Hi,
> >
> > On Feb 12, 2008 8:45 PM, Leonardo Uribe <lu...@gmail.com> wrote:
> >> Hi
> >>
> >> I have another question: trinidad sandbox should be for 1.2 ?
> >
> > +1 on that.
> >
> >>
> >> My component works if I do a light change on LabelAndMessageRenderer, can
> >> I
> >> change this class too?
> >>
> >> This is the patch file:
> >>
> >> Index:
> >> src/main/java/org/apache/myfaces/trinidadinternal/renderkit/core/xhtml/LabelAndMessageRenderer.java
> >> ===================================================================
> >> ---
> >> src/main/java/org/apache/myfaces/trinidadinternal/renderkit/core/xhtml/LabelAndMessageRenderer.java
> >> (revision 614757)
> >> +++
> >> src/main/java/org/apache/myfaces/trinidadinternal/renderkit/core/xhtml/LabelAndMessageRenderer.java
> >> (working copy)
> >> @@ -279,6 +279,27 @@
> >> }
> >> }
> >>
> >> + //This part is necessary to make work hspace on tr:tableFormLayout
> >> + Map<String, Object> requestMap = context.getExternalContext()
> >> + .getRequestMap();
> >> +
> >> + Integer hspaceObject = (Integer) requestMap.get(
> >> + "org.apache.myfaces.trinidadinternal.TableFormHspace");
> >> +
> >> + Boolean percentWidthObject = (Boolean) requestMap.get(
> >> +
> >> "org.apache.myfaces.trinidadinternal.TableFormPercentWidth");
> >> +
> >> + if (hspaceObject != null){
> >> +
> >> + rw.startElement("td", null);
> >> + if (percentWidthObject != null && percentWidthObject == true){
> >> + rw.writeAttribute("width", hspaceObject +"%", null);
> >> + }else{
> >> + rw.writeAttribute("width", hspaceObject, null);
> >> + }
> >> + rw.endElement("td");
> >> + }
> >> +
> >> _renderFieldCell(context, arc, component, bean, labelExists,
> >> needsPanelFormLayout, isInline);
> >>
> >> @@ -787,7 +808,8 @@
> >> {
> >> return "org.apache.myfaces.trinidad.Form".equals(rendererType) ||
> >> "org.apache.myfaces.trinidad.FormLayout".equals(rendererType)
> >> ||
> >> - "org.apache.myfaces.trinidad.rich.Form".equals(rendererType);
> >> + "org.apache.myfaces.trinidad.rich.Form".equals(rendererType) ||
> >> + "org.apache.myfaces.trinidad.TableLayout".equals(rendererType);
> >> }
> >>
> >>
> >>
> >> How does your comp differ from "panelFormLayout" ?
> >>
> >> An example is this
> >>
> >> <mycomp:tableFormLayout width="1000"
> >> columns="1*;2*;1*;2*">
> >> <tr:outputText value="Layout Example: Personal
> >> Information" >
> >> <f:attribute name="spanX" value="4" />
> >> </tr:outputText>
> >>
> >> <tr:selectOneChoice label="Salutation">
> >> <f:selectItem itemLabel="1 Option"
> >> itemValue="1"
> >> />
> >> <f:selectItem itemLabel="2 Option"
> >> itemValue="2"/>
> >> </tr:selectOneChoice>
> >>
> >> <tr:outputText>
> >> <f:attribute name="spanX" value="2" />
> >> </tr:outputText>
> >>
> >> <tr:inputText label="First Name"
> >> required="true"/>
> >> <tr:inputText label="Last Name"
> >> required="true"/>
> >>
> >> <tr:inputText label="c/o" required="true">
> >> <f:attribute name="spanXItem" value="3" />
> >> </tr:inputText>
> >>
> >> <tr:inputText label="Street" required="true"/>
> >> <tr:inputText label="No" required="true"/>
> >> <tr:inputText label="ZIP" required="true"/>
> >> <tr:inputText label="City" required="true"/>
> >> <tr:inputText label="Note" rows="4"
> >> required="true">
> >> <f:attribute name="spanXItem" value="3" />
> >> </tr:inputText>
> >> </mycomp:tableFormLayout>
> >>
> >> It calculates widths, heights for each component and make all layout
> >> tasks
> >> (colspan and others) more easy.
> >>
> >> You can see an screenshot on TRINIDAD-115
> >
> > not done yet, thanks for the pointer.
> >
> > -M
> >
> >>
> >> regards
> >>
> >> Leonardo Uribe
> >>
> >
> >
> >
> > --
> > Matthias Wessendorf
> >
> > further stuff:
> > blog: http://matthiaswessendorf.wordpress.com/
> > sessions: http://www.slideshare.net/mwessendorf
> > mail: matzew-at-apache-dot-org
> >
> >
>
> --
> View this message in context: http://www.nabble.com/Can-I-add-components-to-trinidad-sandbox-tp15440908p15451860.html
> Sent from the My Faces - Dev mailing list archive at Nabble.com.
>
>
--
Matthias Wessendorf
further stuff:
blog: http://matthiaswessendorf.wordpress.com/
sessions: http://www.slideshare.net/mwessendorf
mail: matzew-at-apache-dot-org
Re: Can I add components to trinidad-sandbox
Posted by Carsten Pieper <ca...@continentale.de>.
Just to let you know:
We love the idea of the Trinidad sandbox - especially with the
newly improved tableFormLayout in it!
But... we're still on Trinidad 1.0.x, so that we'd prefer the sandbox to
be compatible with both "branches".
Thanks, Carsten
Matthias Wessendorf-4 wrote:
>
> Hi,
>
> On Feb 12, 2008 8:45 PM, Leonardo Uribe <lu...@gmail.com> wrote:
>> Hi
>>
>> I have another question: trinidad sandbox should be for 1.2 ?
>
> +1 on that.
>
>>
>> My component works if I do a light change on LabelAndMessageRenderer, can
>> I
>> change this class too?
>>
>> This is the patch file:
>>
>> Index:
>> src/main/java/org/apache/myfaces/trinidadinternal/renderkit/core/xhtml/LabelAndMessageRenderer.java
>> ===================================================================
>> ---
>> src/main/java/org/apache/myfaces/trinidadinternal/renderkit/core/xhtml/LabelAndMessageRenderer.java
>> (revision 614757)
>> +++
>> src/main/java/org/apache/myfaces/trinidadinternal/renderkit/core/xhtml/LabelAndMessageRenderer.java
>> (working copy)
>> @@ -279,6 +279,27 @@
>> }
>> }
>>
>> + //This part is necessary to make work hspace on tr:tableFormLayout
>> + Map<String, Object> requestMap = context.getExternalContext()
>> + .getRequestMap();
>> +
>> + Integer hspaceObject = (Integer) requestMap.get(
>> + "org.apache.myfaces.trinidadinternal.TableFormHspace");
>> +
>> + Boolean percentWidthObject = (Boolean) requestMap.get(
>> +
>> "org.apache.myfaces.trinidadinternal.TableFormPercentWidth");
>> +
>> + if (hspaceObject != null){
>> +
>> + rw.startElement("td", null);
>> + if (percentWidthObject != null && percentWidthObject == true){
>> + rw.writeAttribute("width", hspaceObject +"%", null);
>> + }else{
>> + rw.writeAttribute("width", hspaceObject, null);
>> + }
>> + rw.endElement("td");
>> + }
>> +
>> _renderFieldCell(context, arc, component, bean, labelExists,
>> needsPanelFormLayout, isInline);
>>
>> @@ -787,7 +808,8 @@
>> {
>> return "org.apache.myfaces.trinidad.Form".equals(rendererType) ||
>> "org.apache.myfaces.trinidad.FormLayout".equals(rendererType)
>> ||
>> - "org.apache.myfaces.trinidad.rich.Form".equals(rendererType);
>> + "org.apache.myfaces.trinidad.rich.Form".equals(rendererType) ||
>> + "org.apache.myfaces.trinidad.TableLayout".equals(rendererType);
>> }
>>
>>
>>
>> How does your comp differ from "panelFormLayout" ?
>>
>> An example is this
>>
>> <mycomp:tableFormLayout width="1000"
>> columns="1*;2*;1*;2*">
>> <tr:outputText value="Layout Example: Personal
>> Information" >
>> <f:attribute name="spanX" value="4" />
>> </tr:outputText>
>>
>> <tr:selectOneChoice label="Salutation">
>> <f:selectItem itemLabel="1 Option"
>> itemValue="1"
>> />
>> <f:selectItem itemLabel="2 Option"
>> itemValue="2"/>
>> </tr:selectOneChoice>
>>
>> <tr:outputText>
>> <f:attribute name="spanX" value="2" />
>> </tr:outputText>
>>
>> <tr:inputText label="First Name"
>> required="true"/>
>> <tr:inputText label="Last Name"
>> required="true"/>
>>
>> <tr:inputText label="c/o" required="true">
>> <f:attribute name="spanXItem" value="3" />
>> </tr:inputText>
>>
>> <tr:inputText label="Street" required="true"/>
>> <tr:inputText label="No" required="true"/>
>> <tr:inputText label="ZIP" required="true"/>
>> <tr:inputText label="City" required="true"/>
>> <tr:inputText label="Note" rows="4"
>> required="true">
>> <f:attribute name="spanXItem" value="3" />
>> </tr:inputText>
>> </mycomp:tableFormLayout>
>>
>> It calculates widths, heights for each component and make all layout
>> tasks
>> (colspan and others) more easy.
>>
>> You can see an screenshot on TRINIDAD-115
>
> not done yet, thanks for the pointer.
>
> -M
>
>>
>> regards
>>
>> Leonardo Uribe
>>
>
>
>
> --
> Matthias Wessendorf
>
> further stuff:
> blog: http://matthiaswessendorf.wordpress.com/
> sessions: http://www.slideshare.net/mwessendorf
> mail: matzew-at-apache-dot-org
>
>
--
View this message in context: http://www.nabble.com/Can-I-add-components-to-trinidad-sandbox-tp15440908p15451860.html
Sent from the My Faces - Dev mailing list archive at Nabble.com.
Re: Can I add components to trinidad-sandbox
Posted by Matthias Wessendorf <ma...@apache.org>.
Hi,
On Feb 12, 2008 8:45 PM, Leonardo Uribe <lu...@gmail.com> wrote:
> Hi
>
> I have another question: trinidad sandbox should be for 1.2 ?
+1 on that.
>
> My component works if I do a light change on LabelAndMessageRenderer, can I
> change this class too?
>
> This is the patch file:
>
> Index:
> src/main/java/org/apache/myfaces/trinidadinternal/renderkit/core/xhtml/LabelAndMessageRenderer.java
> ===================================================================
> ---
> src/main/java/org/apache/myfaces/trinidadinternal/renderkit/core/xhtml/LabelAndMessageRenderer.java
> (revision 614757)
> +++
> src/main/java/org/apache/myfaces/trinidadinternal/renderkit/core/xhtml/LabelAndMessageRenderer.java
> (working copy)
> @@ -279,6 +279,27 @@
> }
> }
>
> + //This part is necessary to make work hspace on tr:tableFormLayout
> + Map<String, Object> requestMap = context.getExternalContext()
> + .getRequestMap();
> +
> + Integer hspaceObject = (Integer) requestMap.get(
> + "org.apache.myfaces.trinidadinternal.TableFormHspace");
> +
> + Boolean percentWidthObject = (Boolean) requestMap.get(
> +
> "org.apache.myfaces.trinidadinternal.TableFormPercentWidth");
> +
> + if (hspaceObject != null){
> +
> + rw.startElement("td", null);
> + if (percentWidthObject != null && percentWidthObject == true){
> + rw.writeAttribute("width", hspaceObject +"%", null);
> + }else{
> + rw.writeAttribute("width", hspaceObject, null);
> + }
> + rw.endElement("td");
> + }
> +
> _renderFieldCell(context, arc, component, bean, labelExists,
> needsPanelFormLayout, isInline);
>
> @@ -787,7 +808,8 @@
> {
> return "org.apache.myfaces.trinidad.Form".equals(rendererType) ||
> "org.apache.myfaces.trinidad.FormLayout".equals(rendererType) ||
> - "org.apache.myfaces.trinidad.rich.Form".equals(rendererType);
> + "org.apache.myfaces.trinidad.rich.Form".equals(rendererType) ||
> + "org.apache.myfaces.trinidad.TableLayout".equals(rendererType);
> }
>
>
>
> How does your comp differ from "panelFormLayout" ?
>
> An example is this
>
> <mycomp:tableFormLayout width="1000"
> columns="1*;2*;1*;2*">
> <tr:outputText value="Layout Example: Personal
> Information" >
> <f:attribute name="spanX" value="4" />
> </tr:outputText>
>
> <tr:selectOneChoice label="Salutation">
> <f:selectItem itemLabel="1 Option" itemValue="1"
> />
> <f:selectItem itemLabel="2 Option"
> itemValue="2"/>
> </tr:selectOneChoice>
>
> <tr:outputText>
> <f:attribute name="spanX" value="2" />
> </tr:outputText>
>
> <tr:inputText label="First Name" required="true"/>
> <tr:inputText label="Last Name" required="true"/>
>
> <tr:inputText label="c/o" required="true">
> <f:attribute name="spanXItem" value="3" />
> </tr:inputText>
>
> <tr:inputText label="Street" required="true"/>
> <tr:inputText label="No" required="true"/>
> <tr:inputText label="ZIP" required="true"/>
> <tr:inputText label="City" required="true"/>
> <tr:inputText label="Note" rows="4"
> required="true">
> <f:attribute name="spanXItem" value="3" />
> </tr:inputText>
> </mycomp:tableFormLayout>
>
> It calculates widths, heights for each component and make all layout tasks
> (colspan and others) more easy.
>
> You can see an screenshot on TRINIDAD-115
not done yet, thanks for the pointer.
-M
>
> regards
>
> Leonardo Uribe
>
--
Matthias Wessendorf
further stuff:
blog: http://matthiaswessendorf.wordpress.com/
sessions: http://www.slideshare.net/mwessendorf
mail: matzew-at-apache-dot-org
Re: Can I add components to trinidad-sandbox
Posted by Leonardo Uribe <lu...@gmail.com>.
Hi
I have another question: trinidad sandbox should be for 1.2 ?
My component works if I do a light change on LabelAndMessageRenderer, can I
change this class too?
This is the patch file:
Index:
src/main/java/org/apache/myfaces/trinidadinternal/renderkit/core/xhtml/LabelAndMessageRenderer.java
===================================================================
---
src/main/java/org/apache/myfaces/trinidadinternal/renderkit/core/xhtml/LabelAndMessageRenderer.java
(revision 614757)
+++
src/main/java/org/apache/myfaces/trinidadinternal/renderkit/core/xhtml/LabelAndMessageRenderer.java
(working copy)
@@ -279,6 +279,27 @@
}
}
+ //This part is necessary to make work hspace on tr:tableFormLayout
+ Map<String, Object> requestMap = context.getExternalContext()
+ .getRequestMap();
+
+ Integer hspaceObject = (Integer) requestMap.get(
+ "org.apache.myfaces.trinidadinternal.TableFormHspace");
+
+ Boolean percentWidthObject = (Boolean) requestMap.get(
+ "org.apache.myfaces.trinidadinternal.TableFormPercentWidth");
+
+ if (hspaceObject != null){
+
+ rw.startElement("td", null);
+ if (percentWidthObject != null && percentWidthObject == true){
+ rw.writeAttribute("width", hspaceObject +"%", null);
+ }else{
+ rw.writeAttribute("width", hspaceObject, null);
+ }
+ rw.endElement("td");
+ }
+
_renderFieldCell(context, arc, component, bean, labelExists,
needsPanelFormLayout, isInline);
@@ -787,7 +808,8 @@
{
return "org.apache.myfaces.trinidad.Form".equals(rendererType) ||
"org.apache.myfaces.trinidad.FormLayout".equals(rendererType) ||
- "org.apache.myfaces.trinidad.rich.Form".equals(rendererType);
+ "org.apache.myfaces.trinidad.rich.Form".equals(rendererType) ||
+ "org.apache.myfaces.trinidad.TableLayout".equals(rendererType);
}
How does your comp differ from "panelFormLayout" ?
An example is this
<mycomp:tableFormLayout width="1000"
columns="1*;2*;1*;2*">
<tr:outputText value="Layout Example: Personal
Information" >
<f:attribute name="spanX" value="4" />
</tr:outputText>
<tr:selectOneChoice label="Salutation">
<f:selectItem itemLabel="1 Option" itemValue="1"
/>
<f:selectItem itemLabel="2 Option"
itemValue="2"/>
</tr:selectOneChoice>
<tr:outputText>
<f:attribute name="spanX" value="2" />
</tr:outputText>
<tr:inputText label="First Name" required="true"/>
<tr:inputText label="Last Name" required="true"/>
<tr:inputText label="c/o" required="true">
<f:attribute name="spanXItem" value="3" />
</tr:inputText>
<tr:inputText label="Street" required="true"/>
<tr:inputText label="No" required="true"/>
<tr:inputText label="ZIP" required="true"/>
<tr:inputText label="City" required="true"/>
<tr:inputText label="Note" rows="4" required="true">
<f:attribute name="spanXItem" value="3" />
</tr:inputText>
</mycomp:tableFormLayout>
It calculates widths, heights for each component and make all layout tasks
(colspan and others) more easy.
You can see an screenshot on TRINIDAD-115
regards
Leonardo Uribe
Re: Can I add components to trinidad-sandbox
Posted by Matthias Wessendorf <ma...@apache.org>.
Hi,
On Feb 12, 2008 8:26 PM, Leonardo Uribe <lu...@gmail.com> wrote:
> Hi
>
> I have noted that now exists this on svn repo
>
> http://svn.apache.org/repos/asf/myfaces/trinidad-sandbox/
I never had the time to finish this.
>
> I have a component to be added (tableFormLayout), but I don't know what
> prefix use (trs, trhs, ) and if someone is working on other components
sure, you can add new bits.
How does your comp differ from "panelFormLayout" ?
trs is fine, IMO
>
> Should I wait to the module projects will be created?
just go ahead and set up the *required* structure.
-M
>
> regards
>
> Leonardo Uribe
>
--
Matthias Wessendorf
further stuff:
blog: http://matthiaswessendorf.wordpress.com/
sessions: http://www.slideshare.net/mwessendorf
mail: matzew-at-apache-dot-org