You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Nitiraj Rathore <ni...@gmail.com> on 2017/03/09 10:00:47 UTC
Review Request 57453: Fix up tez view version
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57453/
-----------------------------------------------------------
Review request for Ambari, Alejandro Fernandez, DIPAYAN BHOWMICK, Pallav Kulshreshtha, Rohit Choudhary, Sreenath Somarajapuram, and Ashwin Rajeev.
Bugs: AMBARI-20370
https://issues.apache.org/jira/browse/AMBARI-20370
Repository: ambari
Description
-------
tez view version and build removed and short url of auto instance used for property tez.tez-ui.history-url.base in tez-site
Removed change of tez version from AbstractUpgradeCatalog.
UpgardeCatalog250 now contains code to change the previous value of tez.tez-ui.history-url.base to http://HOST:PORT/#/main/view/TEZ/tez_cluster_instance
changed stack_advisor.py in 2.2 and 2.3 for this change to reflect during installation
Diffs
-----
ambari-server/src/main/java/org/apache/ambari/server/upgrade/AbstractUpgradeCatalog.java 9be541f
ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog250.java 00d1c31
ambari-server/src/main/resources/stacks/HDP/2.2/services/stack_advisor.py d45cf96
ambari-server/src/main/resources/stacks/HDP/2.3/services/stack_advisor.py 6d0ce38
ambari-server/src/test/java/org/apache/ambari/server/upgrade/AbstractUpgradeCatalogTest.java 5fa7cac
ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog250Test.java 1a87433
ambari-server/src/test/python/stacks/2.2/common/test_stack_advisor.py 5fce011
ambari-server/src/test/python/stacks/2.3/common/test_stack_advisor.py b1ec05b
Diff: https://reviews.apache.org/r/57453/diff/1/
Testing
-------
Tested the upgrade from 2.4.0.2 to 2.5.0.0.
Tested installation of fresh 2.5.0.0
Added test cases for changes in UpgardeCatalog250.
updated test_stack_advisor.py test cases.
Thanks,
Nitiraj Rathore
Re: Review Request 57453: Fix up tez view version
Posted by Ashwin Rajeev <ar...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57453/#review168915
-----------------------------------------------------------
Ship it!
Ship It!
- Ashwin Rajeev
On March 14, 2017, 1:59 a.m., Nitiraj Rathore wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57453/
> -----------------------------------------------------------
>
> (Updated March 14, 2017, 1:59 a.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, DIPAYAN BHOWMICK, Pallav Kulshreshtha, Rohit Choudhary, Sreenath Somarajapuram, and Ashwin Rajeev.
>
>
> Bugs: AMBARI-20370
> https://issues.apache.org/jira/browse/AMBARI-20370
>
>
> Repository: ambari
>
>
> Description
> -------
>
> tez view version and build removed and short url of auto instance used for property tez.tez-ui.history-url.base in tez-site
> Removed change of tez version from AbstractUpgradeCatalog.
> UpgardeCatalog250 now contains code to change the previous value of tez.tez-ui.history-url.base to http://HOST:PORT/#/main/view/TEZ/tez_cluster_instance
> changed stack_advisor.py in 2.2 and 2.3 for this change to reflect during installation
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/AbstractUpgradeCatalog.java 9be541f
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog250.java e3afc33
> ambari-server/src/main/resources/stacks/HDP/2.2/services/stack_advisor.py d45cf96
> ambari-server/src/main/resources/stacks/HDP/2.3/services/stack_advisor.py 6d0ce38
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/AbstractUpgradeCatalogTest.java 5fa7cac
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog250Test.java ad21331
> ambari-server/src/test/python/stacks/2.2/common/test_stack_advisor.py 5fce011
> ambari-server/src/test/python/stacks/2.3/common/test_stack_advisor.py b1ec05b
>
>
> Diff: https://reviews.apache.org/r/57453/diff/2/
>
>
> Testing
> -------
>
> Tested the upgrade from 2.4.0.2 to 2.5.0.0.
> Tested installation of fresh 2.5.0.0
> Added test cases for changes in UpgardeCatalog250.
> updated test_stack_advisor.py test cases.
>
>
> Thanks,
>
> Nitiraj Rathore
>
>
Re: Review Request 57453: Fix up tez view version
Posted by Nitiraj Rathore <ni...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57453/
-----------------------------------------------------------
(Updated March 14, 2017, 1:59 a.m.)
Review request for Ambari, Alejandro Fernandez, DIPAYAN BHOWMICK, Pallav Kulshreshtha, Rohit Choudhary, Sreenath Somarajapuram, and Ashwin Rajeev.
Changes
-------
removed conflicts and uploaded updated patch
Bugs: AMBARI-20370
https://issues.apache.org/jira/browse/AMBARI-20370
Repository: ambari
Description
-------
tez view version and build removed and short url of auto instance used for property tez.tez-ui.history-url.base in tez-site
Removed change of tez version from AbstractUpgradeCatalog.
UpgardeCatalog250 now contains code to change the previous value of tez.tez-ui.history-url.base to http://HOST:PORT/#/main/view/TEZ/tez_cluster_instance
changed stack_advisor.py in 2.2 and 2.3 for this change to reflect during installation
Diffs (updated)
-----
ambari-server/src/main/java/org/apache/ambari/server/upgrade/AbstractUpgradeCatalog.java 9be541f
ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog250.java e3afc33
ambari-server/src/main/resources/stacks/HDP/2.2/services/stack_advisor.py d45cf96
ambari-server/src/main/resources/stacks/HDP/2.3/services/stack_advisor.py 6d0ce38
ambari-server/src/test/java/org/apache/ambari/server/upgrade/AbstractUpgradeCatalogTest.java 5fa7cac
ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog250Test.java ad21331
ambari-server/src/test/python/stacks/2.2/common/test_stack_advisor.py 5fce011
ambari-server/src/test/python/stacks/2.3/common/test_stack_advisor.py b1ec05b
Diff: https://reviews.apache.org/r/57453/diff/2/
Changes: https://reviews.apache.org/r/57453/diff/1-2/
Testing
-------
Tested the upgrade from 2.4.0.2 to 2.5.0.0.
Tested installation of fresh 2.5.0.0
Added test cases for changes in UpgardeCatalog250.
updated test_stack_advisor.py test cases.
Thanks,
Nitiraj Rathore
Re: Review Request 57453: Fix up tez view version
Posted by Ashwin Rajeev <ar...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57453/#review168427
-----------------------------------------------------------
Ship it!
Ship It!
- Ashwin Rajeev
On March 9, 2017, 10 a.m., Nitiraj Rathore wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57453/
> -----------------------------------------------------------
>
> (Updated March 9, 2017, 10 a.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, DIPAYAN BHOWMICK, Pallav Kulshreshtha, Rohit Choudhary, Sreenath Somarajapuram, and Ashwin Rajeev.
>
>
> Bugs: AMBARI-20370
> https://issues.apache.org/jira/browse/AMBARI-20370
>
>
> Repository: ambari
>
>
> Description
> -------
>
> tez view version and build removed and short url of auto instance used for property tez.tez-ui.history-url.base in tez-site
> Removed change of tez version from AbstractUpgradeCatalog.
> UpgardeCatalog250 now contains code to change the previous value of tez.tez-ui.history-url.base to http://HOST:PORT/#/main/view/TEZ/tez_cluster_instance
> changed stack_advisor.py in 2.2 and 2.3 for this change to reflect during installation
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/AbstractUpgradeCatalog.java 9be541f
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog250.java 00d1c31
> ambari-server/src/main/resources/stacks/HDP/2.2/services/stack_advisor.py d45cf96
> ambari-server/src/main/resources/stacks/HDP/2.3/services/stack_advisor.py 6d0ce38
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/AbstractUpgradeCatalogTest.java 5fa7cac
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog250Test.java 1a87433
> ambari-server/src/test/python/stacks/2.2/common/test_stack_advisor.py 5fce011
> ambari-server/src/test/python/stacks/2.3/common/test_stack_advisor.py b1ec05b
>
>
> Diff: https://reviews.apache.org/r/57453/diff/1/
>
>
> Testing
> -------
>
> Tested the upgrade from 2.4.0.2 to 2.5.0.0.
> Tested installation of fresh 2.5.0.0
> Added test cases for changes in UpgardeCatalog250.
> updated test_stack_advisor.py test cases.
>
>
> Thanks,
>
> Nitiraj Rathore
>
>
Re: Review Request 57453: Fix up tez view version
Posted by DIPAYAN BHOWMICK <di...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57453/#review168739
-----------------------------------------------------------
Ship it!
Ship It!
- DIPAYAN BHOWMICK
On March 9, 2017, 10 a.m., Nitiraj Rathore wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57453/
> -----------------------------------------------------------
>
> (Updated March 9, 2017, 10 a.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, DIPAYAN BHOWMICK, Pallav Kulshreshtha, Rohit Choudhary, Sreenath Somarajapuram, and Ashwin Rajeev.
>
>
> Bugs: AMBARI-20370
> https://issues.apache.org/jira/browse/AMBARI-20370
>
>
> Repository: ambari
>
>
> Description
> -------
>
> tez view version and build removed and short url of auto instance used for property tez.tez-ui.history-url.base in tez-site
> Removed change of tez version from AbstractUpgradeCatalog.
> UpgardeCatalog250 now contains code to change the previous value of tez.tez-ui.history-url.base to http://HOST:PORT/#/main/view/TEZ/tez_cluster_instance
> changed stack_advisor.py in 2.2 and 2.3 for this change to reflect during installation
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/AbstractUpgradeCatalog.java 9be541f
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog250.java 00d1c31
> ambari-server/src/main/resources/stacks/HDP/2.2/services/stack_advisor.py d45cf96
> ambari-server/src/main/resources/stacks/HDP/2.3/services/stack_advisor.py 6d0ce38
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/AbstractUpgradeCatalogTest.java 5fa7cac
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog250Test.java 1a87433
> ambari-server/src/test/python/stacks/2.2/common/test_stack_advisor.py 5fce011
> ambari-server/src/test/python/stacks/2.3/common/test_stack_advisor.py b1ec05b
>
>
> Diff: https://reviews.apache.org/r/57453/diff/1/
>
>
> Testing
> -------
>
> Tested the upgrade from 2.4.0.2 to 2.5.0.0.
> Tested installation of fresh 2.5.0.0
> Added test cases for changes in UpgardeCatalog250.
> updated test_stack_advisor.py test cases.
>
>
> Thanks,
>
> Nitiraj Rathore
>
>