You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Greg Solovyev (Code Review)" <ge...@cloudera.org> on 2020/06/23 22:03:18 UTC
[kudu-CR] [docs] Add a section about using Gradle checkstyle
Greg Solovyev has uploaded this change for review. ( http://gerrit.cloudera.org:8080/16105
Change subject: [docs] Add a section about using Gradle checkstyle
......................................................................
[docs] Add a section about using Gradle checkstyle
Coming from Ant/Maven world, I was not aware of Gradle
checkStyle plugin and didn't use it before submitting
a patch to Gerrit. Knowing about checkStyle would have
saved one Gerrit iteration.
To save time for future first time Java committers, I added
a section about using Gradle checkstyle task to check
Java code style.
Pre-rendered on my fork: https://github.com/grishick/kudu/blob/master/docs/contributing.adoc#java-code-style
Change-Id: Ica45e5fce418fe40fbdcd354bb0c98dc0a653a65
---
M docs/contributing.adoc
1 file changed, 11 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/05/16105/1
--
To view, visit http://gerrit.cloudera.org:8080/16105
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ica45e5fce418fe40fbdcd354bb0c98dc0a653a65
Gerrit-Change-Number: 16105
Gerrit-PatchSet: 1
Gerrit-Owner: Greg Solovyev <gs...@cloudera.com>
[kudu-CR] [docs] Add a section about using Gradle checkstyle
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/16105 )
Change subject: [docs] Add a section about using Gradle checkstyle
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/16105
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ica45e5fce418fe40fbdcd354bb0c98dc0a653a65
Gerrit-Change-Number: 16105
Gerrit-PatchSet: 1
Gerrit-Owner: Greg Solovyev <gs...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 23 Jun 2020 22:22:30 +0000
Gerrit-HasComments: No
[kudu-CR] [docs] Add a section about using Gradle checkstyle
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/16105 )
Change subject: [docs] Add a section about using Gradle checkstyle
......................................................................
[docs] Add a section about using Gradle checkstyle
Coming from Ant/Maven world, I was not aware of Gradle
checkStyle plugin and didn't use it before submitting
a patch to Gerrit. Knowing about checkStyle would have
saved one Gerrit iteration.
To save time for future first time Java committers, I added
a section about using Gradle checkstyle task to check
Java code style.
Pre-rendered on my fork: https://github.com/grishick/kudu/blob/master/docs/contributing.adoc#java-code-style
Change-Id: Ica45e5fce418fe40fbdcd354bb0c98dc0a653a65
Reviewed-on: http://gerrit.cloudera.org:8080/16105
Tested-by: Kudu Jenkins
Reviewed-by: Alexey Serbin <as...@cloudera.com>
---
M docs/contributing.adoc
1 file changed, 11 insertions(+), 0 deletions(-)
Approvals:
Kudu Jenkins: Verified
Alexey Serbin: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/16105
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ica45e5fce418fe40fbdcd354bb0c98dc0a653a65
Gerrit-Change-Number: 16105
Gerrit-PatchSet: 2
Gerrit-Owner: Greg Solovyev <gs...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)