You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by GitBox <gi...@apache.org> on 2020/06/03 02:37:13 UTC
[GitHub] [dubbo-go] ZYB-J opened a new pull request #583: modify_registry_panic_msg
ZYB-J opened a new pull request #583:
URL: https://github.com/apache/dubbo-go/pull/583
<!-- Thanks for sending a pull request!
-->
**What this PR does**:
modify_registry_panic_msg
**Which issue(s) this PR fixes**:
Fixes #
**Special notes for your reviewer**:
**Does this PR introduce a user-facing change?**:
no
```release-note
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] zouyx merged pull request #583: Rft: modify registry panic msg
Posted by GitBox <gi...@apache.org>.
zouyx merged pull request #583:
URL: https://github.com/apache/dubbo-go/pull/583
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] codecov-commenter commented on pull request #583: modify_registry_panic_msg
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #583:
URL: https://github.com/apache/dubbo-go/pull/583#issuecomment-637938956
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/583?src=pr&el=h1) Report
> Merging [#583](https://codecov.io/gh/apache/dubbo-go/pull/583?src=pr&el=desc) into [develop](https://codecov.io/gh/apache/dubbo-go/commit/8a3c02c9b7737a12712451b16a3cdc8ce46a5c7d&el=desc) will **decrease** coverage by `0.84%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/dubbo-go/pull/583?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## develop #583 +/- ##
===========================================
- Coverage 67.20% 66.36% -0.85%
===========================================
Files 174 184 +10
Lines 9261 9709 +448
===========================================
+ Hits 6224 6443 +219
- Misses 2432 2624 +192
- Partials 605 642 +37
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/583?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [common/extension/registry.go](https://codecov.io/gh/apache/dubbo-go/pull/583/diff?src=pr&el=tree#diff-Y29tbW9uL2V4dGVuc2lvbi9yZWdpc3RyeS5nbw==) | `0.00% <0.00%> (ø)` | |
| [config\_center/nacos/facade.go](https://codecov.io/gh/apache/dubbo-go/pull/583/diff?src=pr&el=tree#diff-Y29uZmlnX2NlbnRlci9uYWNvcy9mYWNhZGUuZ28=) | `37.50% <0.00%> (-25.00%)` | :arrow_down: |
| [registry/zookeeper/registry.go](https://codecov.io/gh/apache/dubbo-go/pull/583/diff?src=pr&el=tree#diff-cmVnaXN0cnkvem9va2VlcGVyL3JlZ2lzdHJ5Lmdv) | `46.15% <0.00%> (-9.30%)` | :arrow_down: |
| [protocol/dubbo/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/583/diff?src=pr&el=tree#diff-cHJvdG9jb2wvZHViYm8vbGlzdGVuZXIuZ28=) | `57.52% <0.00%> (-5.38%)` | :arrow_down: |
| [common/url.go](https://codecov.io/gh/apache/dubbo-go/pull/583/diff?src=pr&el=tree#diff-Y29tbW9uL3VybC5nbw==) | `65.83% <0.00%> (-5.33%)` | :arrow_down: |
| [protocol/dubbo/pool.go](https://codecov.io/gh/apache/dubbo-go/pull/583/diff?src=pr&el=tree#diff-cHJvdG9jb2wvZHViYm8vcG9vbC5nbw==) | `76.81% <0.00%> (-4.47%)` | :arrow_down: |
| [config\_center/nacos/impl.go](https://codecov.io/gh/apache/dubbo-go/pull/583/diff?src=pr&el=tree#diff-Y29uZmlnX2NlbnRlci9uYWNvcy9pbXBsLmdv) | `71.08% <0.00%> (-4.31%)` | :arrow_down: |
| [config\_center/apollo/impl.go](https://codecov.io/gh/apache/dubbo-go/pull/583/diff?src=pr&el=tree#diff-Y29uZmlnX2NlbnRlci9hcG9sbG8vaW1wbC5nbw==) | `82.71% <0.00%> (-4.30%)` | :arrow_down: |
| [remoting/zookeeper/facade.go](https://codecov.io/gh/apache/dubbo-go/pull/583/diff?src=pr&el=tree#diff-cmVtb3Rpbmcvem9va2VlcGVyL2ZhY2FkZS5nbw==) | `70.27% <0.00%> (-4.02%)` | :arrow_down: |
| [config/provider\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/583/diff?src=pr&el=tree#diff-Y29uZmlnL3Byb3ZpZGVyX2NvbmZpZy5nbw==) | `55.88% <0.00%> (-3.50%)` | :arrow_down: |
| ... and [71 more](https://codecov.io/gh/apache/dubbo-go/pull/583/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/583?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/583?src=pr&el=footer). Last update [8a3c02c...ad60db4](https://codecov.io/gh/apache/dubbo-go/pull/583?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org