[GitHub] [airflow] itayB edited a comment on pull request #20801: changing execution_date to run_id

[GitBox <gi...@apache.org>]

itayB edited a comment on pull request #20801:
URL: https://github.com/apache/airflow/pull/20801#issuecomment-1010995914


   I'm just not sure if it's a bug or misconfiguration.
   I'm working with remote logging and Kubernetes executor.
   Airflow webserver's log page is still sending log [requests](https://github.com/apache/airflow/blob/main/airflow/www/views.py#L1292) with `execution_date` rather than `run_id`. Inspection via browser show:
   ```
   https://airflow-audience-webserver.use1.dynamicyield.com/get_logs_with_metadata?dag_id=sparkjobs-8764248&task_id=daily&execution_date=2022-01-11T10:50:00+00:00&try_number=1&metadata={"end_of_log":false,"last_log_timestamp":"2022-01-12T11:48:42.713060+00:00","offset":"0"}
   ```
   and in the web-server side:
   ```
   10.1.113.221 - - [12/Jan/2022:12:05:06 +0000] "GET /get_logs_with_metadata?dag_id=sparkjobs-8764248&task_id=daily&execution_date=2022-01-11T10%3A50%3A00%2B00%3A00&try_number=1&metadata=%7B%22end_of_log%22%3Afalse%2C%22last_log_timestamp%22%3A%222022-01-12T12%3A05%3A03.678921%2B00%3A00%22%2C%22offset%22%3A%220%22%7D HTTP/1.1" 200 116 "https://airflow-audience-webserver.dev-use1.dynamicyield.com/log?dag_id=sparkjobs-8764248&task_id=daily&execution_date=2022-01-11T10%3A50%3A00%2B00%3A00" "Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/96.0.4664.110 Safari/537.36"
   ```
   
   On the other hand, `execution_date` info was dropped from (Kubernetes) executors - it was marked as a label in the pod before v2.2.x. `run_id` label was added instead.
   
   - Is there a bug in the web client that doesn't contain/send `run_id` in the log requests?
   - Is there a configuration change to make it send the new `run_id`?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org