[GitHub] AlphaGarden edited a comment on issue #7312: [FLINK-11169][runtime] fix the problem of not being reloaded for jobmanager's…

[GitBox <gi...@apache.org>]

AlphaGarden edited a comment on issue #7312:  [FLINK-11169][runtime] fix the problem of not being reloaded for jobmanager's…
URL: https://github.com/apache/flink/pull/7312#issuecomment-453243892
 
 
   > I think we can add a new internal field `shouldSetCacheHeaders` (or something like this) and when creating the `StaticFileServerHandler` we set this appropriately in the constructor. `StaticFileServerHandler` is only used in very few places. This is where it is used for the log/stdout files:
   > 
   > [flink/flink-runtime/src/main/java/org/apache/flink/runtime/webmonitor/WebMonitorEndpoint.java](https://github.com/apache/flink/blob/3f231ac46537654aebdd73b0f42aa823386bf901/flink-runtime/src/main/java/org/apache/flink/runtime/webmonitor/WebMonitorEndpoint.java#L689)
   > 
   > Line 689 in [3f231ac](/apache/flink/commit/3f231ac46537654aebdd73b0f42aa823386bf901)
   > 
   >  private ChannelInboundHandler createStaticFileHandler( 
   > . Also, this method should be called `createLogFileHandler()`.
   
   Yeah, I think your assumption is much more reasonable, let me check it out and try to make a refinement for the current PR.  Just to make sure I don't misunderstand your idea,  does this mean that we need to extract all functions, or behaviors for different static files like log, stdout files up to the place where these functions are called, with the purpose of achieving the abstraction of `StaticFileServerHandler`?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services