You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cordova.apache.org by GitBox <gi...@apache.org> on 2019/07/17 20:34:43 UTC
[GitHub] [cordova-plugin-wkwebview-engine] dpogue opened a new pull request
#107: Revert "CB-13987: (ios) Fix WKWebView doesn't layout properly at
launch on iPhoneX"
dpogue opened a new pull request #107: Revert "CB-13987: (ios) Fix WKWebView doesn't layout properly at launch on iPhoneX"
URL: https://github.com/apache/cordova-plugin-wkwebview-engine/pull/107
Reverts apache/cordova-plugin-wkwebview-engine#45
This removes developer control over the handling of safe areas using the `viewport-fit` meta tag.
The **correct** way to fix unexpected gaps and layout issues lies at the HTML and CSS level:
* Set `viewport-fit=cover` directive in the `viewport` meta tag to make the webview contents extend into the safe area insets:
```html
<meta name="viewport" content="width=device-width, initial-scale=1.0, viewport-fit=cover">
```
* If necessary, use `100vh` rather than `100%` to make your app container fill the screen:
```css
body {
min-height: 100vh;
}
```
* Use CSS `env(safe-area-inset-*)` variables to add padding to avoid overlapping status bar text:
```css
header {
height: 44px;
padding-top: env(safe-area-inset-top);
}
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org