You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Austin Nobis (Code Review)" <ge...@cloudera.org> on 2019/03/20 17:49:33 UTC

[Impala-ASF-CR] IMPALA-8326: Fix CreateDropRoleStmt::toSql

Austin Nobis has uploaded a new patch set (#3). ( http://gerrit.cloudera.org:8080/12813 )

Change subject: IMPALA-8326: Fix CreateDropRoleStmt::toSql
......................................................................

IMPALA-8326: Fix CreateDropRoleStmt::toSql

Previously the CreateDropRoleStmt::toSql method would incorrectly
order the stringified SQL statement as <role_name>ROLE CREATE/DROP.
This patch will properly order the statementas CREATE/DROP ROLE
<role_name>.

Testing:
- Ran all FE tests
- Added a new test to ToSqlTest for CreateDropRoleStmt

Change-Id: I25e4e1f680a6992779a47b5e6ad5092f27ba390a
---
M fe/src/main/java/org/apache/impala/analysis/CreateDropRoleStmt.java
M fe/src/test/java/org/apache/impala/analysis/ToSqlTest.java
2 files changed, 15 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/13/12813/3
-- 
To view, visit http://gerrit.cloudera.org:8080/12813
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I25e4e1f680a6992779a47b5e6ad5092f27ba390a
Gerrit-Change-Number: 12813
Gerrit-PatchSet: 3
Gerrit-Owner: Austin Nobis <an...@cloudera.com>
Gerrit-Reviewer: Austin Nobis <an...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>