You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2021/05/13 19:55:12 UTC

[GitHub] [tvm] areusch opened a new pull request #8037: Mark zephyr install world-writable in docker image to unblock #7995.

areusch opened a new pull request #8037:
URL: https://github.com/apache/tvm/pull/8037


   Unclear what happened here, but upon rebuilding ci-qemu, lots of:
   ```
   :~/tests/micro/zephyr/test_zephyr_qemu_x86_workspace/2021-05-13T17-30-31/build/utvm_rpc_server/__tvm_build$ make
   cmake -E touch_nocreate: failed to update "zephyr/misc/generated/syscalls_links/include_usb_class".
   zephyr/CMakeFiles/parse_syscalls_target.dir/build.make:521: recipe for target 'zephyr/misc/generated/syscalls_links/include_usb_class' failed
   make[2]: *** [zephyr/misc/generated/syscalls_links/include_usb_class] Error 1
   CMakeFiles/Makefile2:2048: recipe for target 'zephyr/CMakeFiles/parse_syscalls_target.dir/all' failed
   make[1]: *** [zephyr/CMakeFiles/parse_syscalls_target.dir/all] Error 2
   Makefile:90: recipe for target 'all' failed
   make: *** [all] Error 2
   ```
   
   marking Zephyr world-writable, which should resolve the need for make to touch the syscalls dependencies. This isn't strictly ideal, since a test could make modifications to Zephyr and corrupt following tests, but we have this issue everywhere and I believe Zephyr assumes it is writable when building.
   
   Also remove some commented lines in the install script.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] areusch commented on pull request #8037: Mark zephyr install world-writable in docker image to unblock #7995.

Posted by GitBox <gi...@apache.org>.
areusch commented on pull request #8037:
URL: https://github.com/apache/tvm/pull/8037#issuecomment-840795987


   @mehrdadh @gromero @leandron 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] mehrdadh commented on a change in pull request #8037: Mark zephyr install world-writable in docker image to unblock #7995.

Posted by GitBox <gi...@apache.org>.
mehrdadh commented on a change in pull request #8037:
URL: https://github.com/apache/tvm/pull/8037#discussion_r632083515



##########
File path: docker/install/ubuntu_install_zephyr.sh
##########
@@ -41,26 +41,19 @@ sudo apt-get update
 
 sudo apt-get install -y cmake
 
-#mkdir /opt/west
-#python3.6 -mvenv /opt/west  # NOTE: include .6 to make a python3.6 link for west/cmake.
-#/opt/west/bin/pip3 install west
 pip3 install west
 
-#cat <<EOF | tee /usr/local/bin/west >/dev/null
-##!/bin/bash -e
-#
-#source /opt/west/bin/activate
-#export ZEPHYR_BASE=/opt/zephyrproject/zephyr
-#west "\$@"
-#EOF
-#chmod a+x /usr/local/bin/west
-
 # Init ZephyrProject
 ZEPHYR_PROJECT_PATH=/opt/zephyrproject
 ZEPHYR_INIT_SCRIPT=$(find -name "ubuntu_init_zephyr_project.sh")
 bash ${ZEPHYR_INIT_SCRIPT} ${ZEPHYR_PROJECT_PATH} v2.5-branch
 cd ${ZEPHYR_PROJECT_PATH}
 
+# As part of the build process, Zephyr needs to touch some symlinks in zephyr/misc/generated/syscalls_links (this path is relative to the
+# build directory for a project). Mark the zephyr installation world-writable since this is a docker
+# container
+chmod -R o+w /opt/zephyrproject

Review comment:
       maybe change it to ZEPHYR_PROJECT_PATH?

##########
File path: Jenkinsfile
##########
@@ -44,13 +44,13 @@
 //
 
 // NOTE: these lines are scanned by docker/dev_common.sh. Please update the regex as needed. -->
-ci_lint = "tlcpack/ci-lint:v0.62"
-ci_gpu = "tlcpack/ci-gpu:v0.72"
-ci_cpu = "tlcpack/ci-cpu:v0.73"
-ci_wasm = "tlcpack/ci-wasm:v0.70"
-ci_i386 = "tlcpack/ci-i386:v0.72-t0"
-ci_qemu = "tlcpack/ci-qemu:v0.04"
-ci_arm = "tlcpack/ci-arm:v0.03"
+ci_lint = "tkonolige/ci-lint:latest"

Review comment:
       revert these to tlcpack?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] tqchen merged pull request #8037: Mark zephyr install world-writable in docker image to unblock #7995.

Posted by GitBox <gi...@apache.org>.
tqchen merged pull request #8037:
URL: https://github.com/apache/tvm/pull/8037


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] mehrdadh commented on pull request #8037: Mark zephyr install world-writable in docker image to unblock #7995.

Posted by GitBox <gi...@apache.org>.
mehrdadh commented on pull request #8037:
URL: https://github.com/apache/tvm/pull/8037#issuecomment-840807474


   @areusch I'm working on reproducing the issue.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] areusch edited a comment on pull request #8037: Mark zephyr install world-writable in docker image to unblock #7995.

Posted by GitBox <gi...@apache.org>.
areusch edited a comment on pull request #8037:
URL: https://github.com/apache/tvm/pull/8037#issuecomment-840795987


   @mehrdadh @gromero @leandron @tkonolige


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] areusch commented on a change in pull request #8037: Mark zephyr install world-writable in docker image to unblock #7995.

Posted by GitBox <gi...@apache.org>.
areusch commented on a change in pull request #8037:
URL: https://github.com/apache/tvm/pull/8037#discussion_r632115584



##########
File path: docker/install/ubuntu_install_zephyr.sh
##########
@@ -41,26 +41,19 @@ sudo apt-get update
 
 sudo apt-get install -y cmake
 
-#mkdir /opt/west
-#python3.6 -mvenv /opt/west  # NOTE: include .6 to make a python3.6 link for west/cmake.
-#/opt/west/bin/pip3 install west
 pip3 install west
 
-#cat <<EOF | tee /usr/local/bin/west >/dev/null
-##!/bin/bash -e
-#
-#source /opt/west/bin/activate
-#export ZEPHYR_BASE=/opt/zephyrproject/zephyr
-#west "\$@"
-#EOF
-#chmod a+x /usr/local/bin/west
-
 # Init ZephyrProject
 ZEPHYR_PROJECT_PATH=/opt/zephyrproject
 ZEPHYR_INIT_SCRIPT=$(find -name "ubuntu_init_zephyr_project.sh")
 bash ${ZEPHYR_INIT_SCRIPT} ${ZEPHYR_PROJECT_PATH} v2.5-branch
 cd ${ZEPHYR_PROJECT_PATH}
 
+# As part of the build process, Zephyr needs to touch some symlinks in zephyr/misc/generated/syscalls_links (this path is relative to the
+# build directory for a project). Mark the zephyr installation world-writable since this is a docker
+# container
+chmod -R o+w /opt/zephyrproject

Review comment:
       done

##########
File path: Jenkinsfile
##########
@@ -44,13 +44,13 @@
 //
 
 // NOTE: these lines are scanned by docker/dev_common.sh. Please update the regex as needed. -->
-ci_lint = "tlcpack/ci-lint:v0.62"
-ci_gpu = "tlcpack/ci-gpu:v0.72"
-ci_cpu = "tlcpack/ci-cpu:v0.73"
-ci_wasm = "tlcpack/ci-wasm:v0.70"
-ci_i386 = "tlcpack/ci-i386:v0.72-t0"
-ci_qemu = "tlcpack/ci-qemu:v0.04"
-ci_arm = "tlcpack/ci-arm:v0.03"
+ci_lint = "tkonolige/ci-lint:latest"

Review comment:
       oops, based on the wrong thing, reverted

##########
File path: Jenkinsfile
##########
@@ -44,13 +44,13 @@
 //
 
 // NOTE: these lines are scanned by docker/dev_common.sh. Please update the regex as needed. -->
-ci_lint = "tlcpack/ci-lint:v0.62"
-ci_gpu = "tlcpack/ci-gpu:v0.72"
-ci_cpu = "tlcpack/ci-cpu:v0.73"
-ci_wasm = "tlcpack/ci-wasm:v0.70"
-ci_i386 = "tlcpack/ci-i386:v0.72-t0"
-ci_qemu = "tlcpack/ci-qemu:v0.04"
-ci_arm = "tlcpack/ci-arm:v0.03"
+ci_lint = "tkonolige/ci-lint:latest"

Review comment:
       oops, based on the wrong thing, reverted




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org