[GitHub] geode issue #691: GEODE-3260: Refactoring FunctionCommands

[PurelyApplied <gi...@git.apache.org>]

Github user PurelyApplied commented on the issue:

    https://github.com/apache/geode/pull/691
  
    +1.
    
    A far-from-critical nitpick: there are several places in `ExecuteFunctionCommand` and one in `DestroyFunctionCommand` that are of the form
    
    ```
        result = ResultBuilder.[...];
        return result;
    ```
    
    In other instances, the result is returned directly
    
    ```
       return ResultBuilder.[...];
    ```
    
    I'd change those few assign-and-immediately-return to just return the object directly.  You might then be able to delete the declaration of the variable as well.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---