You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by Jesús Camacho Rodríguez <jc...@hortonworks.com> on 2017/10/19 00:52:58 UTC
Review Request 63133: HIVE-17054
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63133/
-----------------------------------------------------------
Review request for hive and Ashutosh Chauhan.
Bugs: HIVE-17054
https://issues.apache.org/jira/browse/HIVE-17054
Repository: hive-git
Description
-------
HIVE-17054
Diffs
-----
ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/RelOptHiveTable.java 044bba1f71199cbbbd996c7e88e1eed1c0a15c21
ql/src/test/queries/clientpositive/groupby_join_pushdown.q a6e25685561e022db8b35e484801d874b22a03ce
ql/src/test/results/clientpositive/groupby_join_pushdown.q.out 95d499afef65271edbd3418b67f95691639208a2
Diff: https://reviews.apache.org/r/63133/diff/1/
Testing
-------
Thanks,
Jesús Camacho Rodríguez
Re: Review Request 63133: HIVE-17054
Posted by Jesús Camacho Rodríguez <jc...@hortonworks.com>.
> On Oct. 19, 2017, 5:59 p.m., Ashutosh Chauhan wrote:
> > ql/src/test/results/clientpositive/groupby_join_pushdown.q.out
> > Lines 1517 (patched)
> > <https://reviews.apache.org/r/63133/diff/1/?file=1863194#file1863194line1517>
> >
> > sorry misread the plan.
No worries!
- Jesús
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63133/#review188718
-----------------------------------------------------------
On Oct. 19, 2017, 12:52 a.m., Jesús Camacho Rodríguez wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63133/
> -----------------------------------------------------------
>
> (Updated Oct. 19, 2017, 12:52 a.m.)
>
>
> Review request for hive and Ashutosh Chauhan.
>
>
> Bugs: HIVE-17054
> https://issues.apache.org/jira/browse/HIVE-17054
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> HIVE-17054
>
>
> Diffs
> -----
>
> ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/RelOptHiveTable.java 044bba1f71199cbbbd996c7e88e1eed1c0a15c21
> ql/src/test/queries/clientpositive/groupby_join_pushdown.q a6e25685561e022db8b35e484801d874b22a03ce
> ql/src/test/results/clientpositive/groupby_join_pushdown.q.out 95d499afef65271edbd3418b67f95691639208a2
>
>
> Diff: https://reviews.apache.org/r/63133/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jesús Camacho Rodríguez
>
>
Re: Review Request 63133: HIVE-17054
Posted by Ashutosh Chauhan <ha...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63133/#review188718
-----------------------------------------------------------
ql/src/test/results/clientpositive/groupby_join_pushdown.q.out
Lines 1517 (patched)
<https://reviews.apache.org/r/63133/#comment265741>
sorry misread the plan.
- Ashutosh Chauhan
On Oct. 19, 2017, 12:52 a.m., Jesús Camacho Rodríguez wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63133/
> -----------------------------------------------------------
>
> (Updated Oct. 19, 2017, 12:52 a.m.)
>
>
> Review request for hive and Ashutosh Chauhan.
>
>
> Bugs: HIVE-17054
> https://issues.apache.org/jira/browse/HIVE-17054
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> HIVE-17054
>
>
> Diffs
> -----
>
> ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/RelOptHiveTable.java 044bba1f71199cbbbd996c7e88e1eed1c0a15c21
> ql/src/test/queries/clientpositive/groupby_join_pushdown.q a6e25685561e022db8b35e484801d874b22a03ce
> ql/src/test/results/clientpositive/groupby_join_pushdown.q.out 95d499afef65271edbd3418b67f95691639208a2
>
>
> Diff: https://reviews.apache.org/r/63133/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jesús Camacho Rodríguez
>
>
Re: Review Request 63133: HIVE-17054
Posted by Jesús Camacho Rodríguez <jc...@hortonworks.com>.
> On Oct. 19, 2017, 5:33 p.m., Ashutosh Chauhan wrote:
> > ql/src/test/queries/clientpositive/groupby_join_pushdown.q
> > Lines 69 (patched)
> > <https://reviews.apache.org/r/63133/diff/1/?file=1863193#file1863193line69>
> >
> > Comment says in both cases optimization didn't trigger. Incorrect comment?
It is correct: it will not be triggered for PKs and for UNIQUE (L65 drops the PK constraint and L67 creates a UNIQUE constraint).
Btw, the plan with the GBs pushed is just above the new plans.
> On Oct. 19, 2017, 5:33 p.m., Ashutosh Chauhan wrote:
> > ql/src/test/results/clientpositive/groupby_join_pushdown.q.out
> > Lines 1517 (patched)
> > <https://reviews.apache.org/r/63133/diff/1/?file=1863194#file1863194line1517>
> >
> > Is this expected? Either GBy needs to be in complete mode or there needs to be another reducer following this.
Stage 2 contains the Reducer to follow this, result is expected as GBy ops are not pushed to the inputs because column is already unique.
> On Oct. 19, 2017, 5:33 p.m., Ashutosh Chauhan wrote:
> > ql/src/test/results/clientpositive/groupby_join_pushdown.q.out
> > Lines 1632 (patched)
> > <https://reviews.apache.org/r/63133/diff/1/?file=1863194#file1863194line1632>
> >
> > Is this expected? Either GBy needs to be in complete mode or there needs to be another reducer following this.
Same as above.
- Jesús
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63133/#review188704
-----------------------------------------------------------
On Oct. 19, 2017, 12:52 a.m., Jesús Camacho Rodríguez wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63133/
> -----------------------------------------------------------
>
> (Updated Oct. 19, 2017, 12:52 a.m.)
>
>
> Review request for hive and Ashutosh Chauhan.
>
>
> Bugs: HIVE-17054
> https://issues.apache.org/jira/browse/HIVE-17054
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> HIVE-17054
>
>
> Diffs
> -----
>
> ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/RelOptHiveTable.java 044bba1f71199cbbbd996c7e88e1eed1c0a15c21
> ql/src/test/queries/clientpositive/groupby_join_pushdown.q a6e25685561e022db8b35e484801d874b22a03ce
> ql/src/test/results/clientpositive/groupby_join_pushdown.q.out 95d499afef65271edbd3418b67f95691639208a2
>
>
> Diff: https://reviews.apache.org/r/63133/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jesús Camacho Rodríguez
>
>
Re: Review Request 63133: HIVE-17054
Posted by Ashutosh Chauhan <ha...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63133/#review188704
-----------------------------------------------------------
ql/src/test/queries/clientpositive/groupby_join_pushdown.q
Lines 69 (patched)
<https://reviews.apache.org/r/63133/#comment265717>
Comment says in both cases optimization didn't trigger. Incorrect comment?
ql/src/test/results/clientpositive/groupby_join_pushdown.q.out
Lines 1517 (patched)
<https://reviews.apache.org/r/63133/#comment265715>
Is this expected? Either GBy needs to be in complete mode or there needs to be another reducer following this.
ql/src/test/results/clientpositive/groupby_join_pushdown.q.out
Lines 1632 (patched)
<https://reviews.apache.org/r/63133/#comment265716>
Is this expected? Either GBy needs to be in complete mode or there needs to be another reducer following this.
- Ashutosh Chauhan
On Oct. 19, 2017, 12:52 a.m., Jesús Camacho Rodríguez wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63133/
> -----------------------------------------------------------
>
> (Updated Oct. 19, 2017, 12:52 a.m.)
>
>
> Review request for hive and Ashutosh Chauhan.
>
>
> Bugs: HIVE-17054
> https://issues.apache.org/jira/browse/HIVE-17054
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> HIVE-17054
>
>
> Diffs
> -----
>
> ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/RelOptHiveTable.java 044bba1f71199cbbbd996c7e88e1eed1c0a15c21
> ql/src/test/queries/clientpositive/groupby_join_pushdown.q a6e25685561e022db8b35e484801d874b22a03ce
> ql/src/test/results/clientpositive/groupby_join_pushdown.q.out 95d499afef65271edbd3418b67f95691639208a2
>
>
> Diff: https://reviews.apache.org/r/63133/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jesús Camacho Rodríguez
>
>