[GitHub] [felix-atomos] tjwatson commented on issue #15: more flexible substrate builder

[GitBox <gi...@apache.org>]

tjwatson commented on issue #15: more flexible substrate builder
URL: https://github.com/apache/felix-atomos/pull/15#issuecomment-600250645
 
 
   Some superficial comments while you are in draft mode on this PR.  In the end I think we will want a general plugin that will be able to do substrate stuff, but it may over time provide help building other deployment types other than substrate native-image.
   
   For example, I would like a plugin that can be used to create the Atomos bundles.index and be able to use that to create a flat uber JAR with all the bundles/framework/atomos runtime.  With that in mind, if we are going to create a sub module for the maven plugin then I would keep the sub module more general than `atomos.substrate`.  I would recommend using a submodule with a name like `atomos.maven.plugin`.  I also think the general convention for the artifact ID for maven plugins is to use a dashed `-` name.  I recommend for the actual plugin we use an artifact ID like `atomos-maven-plugin` where the GID is `org.apache.felix`

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services