[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #6635: In PinotDataType, trim the string before converting to other types

[GitBox <gi...@apache.org>]

Jackie-Jiang commented on a change in pull request #6635:
URL: https://github.com/apache/incubator-pinot/pull/6635#discussion_r587041269



##########
File path: pinot-common/src/main/java/org/apache/pinot/common/utils/PinotDataType.java
##########
@@ -342,7 +344,7 @@ public String toString(Object value) {
 
     @Override
     public byte[] toBytes(Object value) {
-      return BytesUtils.toBytes((String) value);
+      return BytesUtils.toBytes(((String) value).trim());

Review comment:
       String with spaces cannot be parsed as hex-encoded bytes




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org