You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by "vaibhawvipul (via GitHub)" <gi...@apache.org> on 2024/07/08 09:38:15 UTC
[PR] feat: Add cargo machete [iceberg-rust]
vaibhawvipul opened a new pull request, #448:
URL: https://github.com/apache/iceberg-rust/pull/448
- adding cargo machete to check unused dependencies
- CI fails on error
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] feat: Add cargo machete [iceberg-rust]
Posted by "vaibhawvipul (via GitHub)" <gi...@apache.org>.
vaibhawvipul commented on code in PR #448:
URL: https://github.com/apache/iceberg-rust/pull/448#discussion_r1668606957
##########
.github/workflows/ci.yml:
##########
@@ -50,6 +50,9 @@ jobs:
- name: Cargo sort
run: make cargo-sort
+ - name: Cargo Machete
+ uses: bnjbvr/cargo-machete@v0.6.2
Review Comment:
Thank you for this. I have made the change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] feat: Add cargo machete [iceberg-rust]
Posted by "liurenjie1024 (via GitHub)" <gi...@apache.org>.
liurenjie1024 commented on code in PR #448:
URL: https://github.com/apache/iceberg-rust/pull/448#discussion_r1668596960
##########
.github/workflows/ci.yml:
##########
@@ -50,6 +50,9 @@ jobs:
- name: Cargo sort
run: make cargo-sort
+ - name: Cargo Machete
+ uses: bnjbvr/cargo-machete@v0.6.2
Review Comment:
Could we add some commands in Makefile like what we did for `make cargo-sort`? There are two advantages of this approach:
1. It makes local reproduce easier.
2. This github action is not allowed by AFS infra.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] feat: Add cargo machete [iceberg-rust]
Posted by "vaibhawvipul (via GitHub)" <gi...@apache.org>.
vaibhawvipul commented on code in PR #448:
URL: https://github.com/apache/iceberg-rust/pull/448#discussion_r1668336619
##########
.github/workflows/ci.yml:
##########
@@ -50,6 +50,12 @@ jobs:
- name: Cargo sort
run: make cargo-sort
+ - name: Cargo Machete
+ uses: bnjbvr/cargo-machete@main
+ with:
+ args: --with-metadata
+ continue-on-error: false
Review Comment:
@Xuanwo Should we fail the ci or remove the dependencies using `--fix`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] feat: Add cargo machete [iceberg-rust]
Posted by "Xuanwo (via GitHub)" <gi...@apache.org>.
Xuanwo commented on code in PR #448:
URL: https://github.com/apache/iceberg-rust/pull/448#discussion_r1668419649
##########
.github/workflows/ci.yml:
##########
@@ -50,6 +50,12 @@ jobs:
- name: Cargo sort
run: make cargo-sort
+ - name: Cargo Machete
+ uses: bnjbvr/cargo-machete@main
Review Comment:
Please always use tagged version instead of `main`.
##########
.github/workflows/ci.yml:
##########
@@ -50,6 +50,12 @@ jobs:
- name: Cargo sort
run: make cargo-sort
+ - name: Cargo Machete
+ uses: bnjbvr/cargo-machete@main
+ with:
+ args: --with-metadata
+ continue-on-error: false
Review Comment:
Please remove this if we using default value.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] feat: Add cargo machete [iceberg-rust]
Posted by "liurenjie1024 (via GitHub)" <gi...@apache.org>.
liurenjie1024 commented on PR #448:
URL: https://github.com/apache/iceberg-rust/pull/448#issuecomment-2216135691
> > due to ASF infra policy, this third-party github action is not allowed. I've left some suggestion to improve.
>
> I'm going to submit a ticket to the ASF infra. We can wait for a bit.
Cool, let wait for a moment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] feat: Add cargo machete [iceberg-rust]
Posted by "Xuanwo (via GitHub)" <gi...@apache.org>.
Xuanwo commented on PR #448:
URL: https://github.com/apache/iceberg-rust/pull/448#issuecomment-2214493240
> due to ASF infra policy, this third-party github action is not allowed. I've left some suggestion to improve.
I'm going to submit a ticket to the ASF infra. We can wait for a bit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] feat: Add cargo machete [iceberg-rust]
Posted by "liurenjie1024 (via GitHub)" <gi...@apache.org>.
liurenjie1024 merged PR #448:
URL: https://github.com/apache/iceberg-rust/pull/448
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] feat: Add cargo machete [iceberg-rust]
Posted by "Xuanwo (via GitHub)" <gi...@apache.org>.
Xuanwo commented on PR #448:
URL: https://github.com/apache/iceberg-rust/pull/448#issuecomment-2216198479
> Cool, let wait for a moment.
Apologies, I missed some discussion about using `cargo install` directly. I'm fine with merging this PR first and switching to GitHub Action versions once it's approved.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] feat: Add cargo machete [iceberg-rust]
Posted by "vaibhawvipul (via GitHub)" <gi...@apache.org>.
vaibhawvipul commented on PR #448:
URL: https://github.com/apache/iceberg-rust/pull/448#issuecomment-2213690965
> Thanks a lot for your contribution. However, the ASF has it's own limitation about actions that can use:
>
> > bnjbvr/cargo-machete@main is not allowed to be used in apache/iceberg-rust.
>
> We will raise a ticket to the ASF infra to review and allow this action.
I used that repo because that is why the github readme recommends for cargo machete.
we can also run cargo machete on our own and parse its output. please let me know if that would make the process easier @Xuanwo
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] feat: Add cargo machete [iceberg-rust]
Posted by "Xuanwo (via GitHub)" <gi...@apache.org>.
Xuanwo commented on code in PR #448:
URL: https://github.com/apache/iceberg-rust/pull/448#discussion_r1668391151
##########
.github/workflows/ci.yml:
##########
@@ -50,6 +50,12 @@ jobs:
- name: Cargo sort
run: make cargo-sort
+ - name: Cargo Machete
+ uses: bnjbvr/cargo-machete@main
+ with:
+ args: --with-metadata
+ continue-on-error: false
Review Comment:
> remove the dependencies using
Hi, please fail the ci as we can contributors to remove the unused deps.
##########
.github/workflows/ci.yml:
##########
@@ -50,6 +50,12 @@ jobs:
- name: Cargo sort
run: make cargo-sort
+ - name: Cargo Machete
+ uses: bnjbvr/cargo-machete@main
+ with:
+ args: --with-metadata
+ continue-on-error: false
Review Comment:
> remove the dependencies using
Hi, please fail the ci as we want contributors to remove the unused deps.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] feat: Add cargo machete [iceberg-rust]
Posted by "vaibhawvipul (via GitHub)" <gi...@apache.org>.
vaibhawvipul commented on PR #448:
URL: https://github.com/apache/iceberg-rust/pull/448#issuecomment-2214045057
> Thanks @vaibhawvipul for this pr, due to ASF infra policy, this third-party github action is not allowed. I've left some suggestion to improve.
Thank you.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] feat: Add cargo machete [iceberg-rust]
Posted by "vaibhawvipul (via GitHub)" <gi...@apache.org>.
vaibhawvipul commented on code in PR #448:
URL: https://github.com/apache/iceberg-rust/pull/448#discussion_r1668401338
##########
.github/workflows/ci.yml:
##########
@@ -50,6 +50,12 @@ jobs:
- name: Cargo sort
run: make cargo-sort
+ - name: Cargo Machete
+ uses: bnjbvr/cargo-machete@main
+ with:
+ args: --with-metadata
+ continue-on-error: false
Review Comment:
sure, then we can merge this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org