You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2020/05/29 06:19:12 UTC
[GitHub] [camel] zhfeng opened a new pull request #3869: CAMEL-14805: Fix the camel-dataset doInit issue
zhfeng opened a new pull request #3869:
URL: https://github.com/apache/camel/pull/3869
[ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/CAMEL) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes.
[ ] Each commit in the pull request should have a meaningful subject line and body.
[ ] If you're unsure, you can format the pull request title like `[CAMEL-XXX] Fixes bug in camel-file component`, where you replace `CAMEL-XXX` with the appropriate JIRA issue.
[ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
[ ] Run `mvn clean install -Psourcecheck` in your module with source check enabled to make sure basic checks pass and there are no checkstyle violations. A more thorough check will be performed on your pull request automatically.
Below are the contribution guidelines:
https://github.com/apache/camel/blob/master/CONTRIBUTING.md
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] davsclaus commented on pull request #3869: CAMEL-14805: Fix the camel-dataset doInit issue
Posted by GitBox <gi...@apache.org>.
davsclaus commented on pull request #3869:
URL: https://github.com/apache/camel/pull/3869#issuecomment-635804410
Hmm I am not liking this as you mess around the lifecycle of camel components by manually calling doInit from a constructor and adding true|false flags.
The dataset / mock are used for testing so there is no much point in doing this anyway as they are not part of a production build and optimized via quarkus. So lets keep it as is and close this PR
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] zhfeng closed pull request #3869: CAMEL-14805: Fix the camel-dataset doInit issue
Posted by GitBox <gi...@apache.org>.
zhfeng closed pull request #3869:
URL: https://github.com/apache/camel/pull/3869
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] zhfeng commented on pull request #3869: CAMEL-14805: Fix the camel-dataset doInit issue
Posted by GitBox <gi...@apache.org>.
zhfeng commented on pull request #3869:
URL: https://github.com/apache/camel/pull/3869#issuecomment-635808865
yeah - if this is only used for testing, I'm happy to keep it as is.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org