You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2021/03/25 17:47:11 UTC

[GitHub] [incubator-nuttx] patacongo opened a new pull request #3182: Continue development of Userspace pthread callbacks.

patacongo opened a new pull request #3182:
URL: https://github.com/apache/incubator-nuttx/pull/3182


   ## Summary
   
   1. Move pthread_exit() to user-space (at libs/libc/pthread/pthread_exit.c).  The old pthread_exit is renamed nx_pthread_exit().  Initially, the userspace pthread_exit() only calls nx_pthread_exit() but will eventually perform pthread clean up and data destructor calls.
   
   ## Impact
   
   ## Testing
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-nuttx] patacongo commented on pull request #3182: Continue development of Userspace pthread callbacks.

Posted by GitBox <gi...@apache.org>.
patacongo commented on pull request #3182:
URL: https://github.com/apache/incubator-nuttx/pull/3182#issuecomment-807177309


   This PR is part of a larger work in progress.  Notice that it does not merge to master but to the working feature/pthread-user branch.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-nuttx] patacongo commented on pull request #3182: Continue development of Userspace pthread callbacks.

Posted by GitBox <gi...@apache.org>.
patacongo commented on pull request #3182:
URL: https://github.com/apache/incubator-nuttx/pull/3182#issuecomment-807935123


   From PR #3170
   
   I am beginning to think that the best way to implement per-process globals might be the same way that we already implement other per-process, application data like file descriptor, streams, etc.  Allocate then with umm_malloc(), but retain them in the group structure with the system call to access them.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #3182: Continue development of Userspace pthread callbacks.

Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on pull request #3182:
URL: https://github.com/apache/incubator-nuttx/pull/3182#issuecomment-808217792


   This PR fix the issue described here: https://github.com/apache/incubator-nuttx/issues/1263


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-nuttx] patacongo closed pull request #3182: Continue development of Userspace pthread callbacks.

Posted by GitBox <gi...@apache.org>.
patacongo closed pull request #3182:
URL: https://github.com/apache/incubator-nuttx/pull/3182


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-nuttx] xiaoxiang781216 edited a comment on pull request #3182: Continue development of Userspace pthread callbacks.

Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 edited a comment on pull request #3182:
URL: https://github.com/apache/incubator-nuttx/pull/3182#issuecomment-807956083


   > From PR #3170
   > 
   > I am beginning to think that the best way to implement per-process globals might be the same way that we already implement other per-process, application data like file descriptor, streams, etc. Allocate then with umm_malloc(), but retain them in the group structure with the system call to access them.
   
   Yes, it's another approach, but why not move all pure userspace stuff to the main stack? So we don't have to put some special FILE function inside the kernel space.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-nuttx] xiaoxiang781216 edited a comment on pull request #3182: Continue development of Userspace pthread callbacks.

Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 edited a comment on pull request #3182:
URL: https://github.com/apache/incubator-nuttx/pull/3182#issuecomment-807956083


   > From PR #3170
   > 
   > I am beginning to think that the best way to implement per-process globals might be the same way that we already implement other per-process, application data like file descriptor, streams, etc. Allocate then with umm_malloc(), but retain them in the group structure with the system call to access them.
   
   Yes, it's another approach, but why not move all pure userspace stuff to the main stack? So we don't have to put some FILE function inside the kernel space.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-nuttx] patacongo commented on pull request #3182: Continue development of Userspace pthread callbacks.

Posted by GitBox <gi...@apache.org>.
patacongo commented on pull request #3182:
URL: https://github.com/apache/incubator-nuttx/pull/3182#issuecomment-808245709


   I am not going to complete this change.  I am not enjoying having all of my designs being micromanaged in this way and other than enjoyment, I have no motivation to do any of this.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #3182: Continue development of Userspace pthread callbacks.

Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on pull request #3182:
URL: https://github.com/apache/incubator-nuttx/pull/3182#issuecomment-807956083


   > From PR #3170
   > 
   > I am beginning to think that the best way to implement per-process globals might be the same way that we already implement other per-process, application data like file descriptor, streams, etc. Allocate then with umm_malloc(), but retain them in the group structure with the system call to access them.
   
   Yes, it's another approach. But why not move all pure userspace stuff to the main thread stack?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org