You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@maven.apache.org by GitBox <gi...@apache.org> on 2018/09/05 10:30:23 UTC

[GitHub] famod commented on issue #40: MENFORCER-317 - Fix RequireFileChecksum ignores configured message

famod commented on issue #40: MENFORCER-317 - Fix RequireFileChecksum ignores configured message
URL: https://github.com/apache/maven-enforcer/pull/40#issuecomment-418681667
 
 
   @khmarbaise Your are welcome!
   
   One thing that crossed my mind though: First I wanted change the rule to use the configured message also (when the given file does not exist)[https://github.com/apache/maven-enforcer/blob/master/enforcer-rules/src/main/java/org/apache/maven/plugins/enforcer/RequireFileChecksum.java#L72].
   But then I decided against this because that might be slighty out of scope because the is also `RequireFilesExist`.
   
   On the other hand it would reduce the "configuration noise" if `RequireFileChecksum` could also check for file existence, using the configured message.
   
   WDYT?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services