[GitHub] mdindoffer commented on issue #295: Drop usage of FileInput/OutputStreams - modules a* -> c*

[GitBox <gi...@apache.org>]

mdindoffer commented on issue #295: Drop usage of FileInput/OutputStreams - modules a* -> c*
URL: https://github.com/apache/incubator-netbeans/pull/295#issuecomment-347322722
 
 
   @emilianbold Done manually. Sure there may be a place for a java hint in the future, but this was partly an experiment.  Also, the code is kinda fragile and tangled up in some places, so I prefer to do this stuff manually.
   The idea was to apply this change throughout the whole repo in one go, but it proved to be more time consuming than I thought. Yes, the speedup that seems to be present at the boot probably originates from the core. And maybe autoupdate too? If it checks for updates at startup, not entirely sure. However, the point is, if there's a benefit observable in one use case (boot), it should manifest itself in other use cases too, even if negligibly. I also planned to tackle code that touches file searching & replacing and benchmark that. I think the api.search* module (which I plowed through) houses most of the relevant code for this, but not all. However I am not that much familiar with the NB cluster structure to say that for sure.
   "but don't like so much" - so, are you against this FI/OS change in general?
   
   @lbruun 
   I did not touch the JVM / GC params apart from the Xmx and gc logging. The XXs you list are defaults for x64 Java 8.
   The IDE hint seems like a good idea. But as you mentioned, the real life effect can be negligible for most of the use cases nowadays.
   I will address the comments and then run some more tests.
   BTW [this post](https://arnaudroger.github.io/blog/2017/03/20/faster-reader-inpustream-in-java.html) also provides some nice graphs

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services