You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by "lhotari (via GitHub)" <gi...@apache.org> on 2025/09/04 10:51:48 UTC
[PR] [improve][test] Improve integration test profiling test example [pulsar]
lhotari opened a new pull request, #24701:
URL: https://github.com/apache/pulsar/pull/24701
### Motivation & Modifications
A previous PR #24688 added an example test for profiling integration tests with Async Profiler.
Improvements:
- collecting more details from the `pulsar-perf produce` and `pulsar-perf consume` containers
- store the latency histogram to the `tests/integration/target` directory
- store stdout & stderr to a log file in the same directory
- gracefully shutdown the containers so that the latency histogram files don't get truncated
- collect topic stats and internal stats in pretty printed JSON to stdout and to files stored in `tests/integration/target`
- collect broker metrics and store to `tests/integration/target`
- metrics can be used to validate PIP-430 in this test so that all reads come from the cache in the tailing read scenario setup with `pulsar-perf consume` and `pulsar perf produce`
- switch to use smaller message size without batching to stress test PIP-430 changes
- configure `dispatcherMaxReadBatchSize` to `1000` in broker to get past issue #24695
- this PR can be used to reduce issue #24695 by commenting out the setting
- improve integration test startup scripts
- fix an issue with invalid replacements in `conf/pulsar_env.sh`
- always add parameters to capture heap dumps on OOME
- install `jq` to test container images so that it can be used in pretty printing topic stats retrieved with `curl`
### Documentation
<!-- DO NOT REMOVE THIS SECTION. CHECK THE PROPER BOX ONLY. -->
- [ ] `doc` <!-- Your PR contains doc changes. -->
- [ ] `doc-required` <!-- Your PR changes impact docs and you will update later -->
- [x] `doc-not-needed` <!-- Your PR changes do not impact docs -->
- [ ] `doc-complete` <!-- Docs have been already added -->
### Matching PR in forked repository
PR in forked repository: <!-- ENTER URL HERE -->
<!--
After opening this PR, the build in apache/pulsar will fail and instructions will
be provided for opening a PR in the PR author's forked repository.
apache/pulsar pull requests should be first tested in your own fork since the
apache/pulsar CI based on GitHub Actions has constrained resources and quota.
GitHub Actions provides separate quota for pull requests that are executed in
a forked repository.
The tests will be run in the forked repository until all PR review comments have
been handled, the tests pass and the PR is approved by a reviewer.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [improve][test] Improve integration test profiling test example [pulsar]
Posted by "lhotari (via GitHub)" <gi...@apache.org>.
lhotari merged PR #24701:
URL: https://github.com/apache/pulsar/pull/24701
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [improve][test] Improve integration test profiling test example [pulsar]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #24701:
URL: https://github.com/apache/pulsar/pull/24701#issuecomment-3253387854
## [Codecov](https://app.codecov.io/gh/apache/pulsar/pull/24701?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 74.19%. Comparing base ([`2e6a8eb`](https://app.codecov.io/gh/apache/pulsar/commit/2e6a8eb1f200ca687064058a101963713b896fe2?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`89c82a9`](https://app.codecov.io/gh/apache/pulsar/commit/89c82a94f4c183ffe99ee0db23ab44b5e45c6900?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 2 commits behind head on master.
<details><summary>Additional details and impacted files</summary>
[](https://app.codecov.io/gh/apache/pulsar/pull/24701?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
```diff
@@ Coverage Diff @@
## master #24701 +/- ##
============================================
- Coverage 74.33% 74.19% -0.15%
+ Complexity 33534 33458 -76
============================================
Files 1895 1895
Lines 147954 147968 +14
Branches 17130 17134 +4
============================================
- Hits 109978 109780 -198
- Misses 29256 29420 +164
- Partials 8720 8768 +48
```
| [Flag](https://app.codecov.io/gh/apache/pulsar/pull/24701/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [inttests](https://app.codecov.io/gh/apache/pulsar/pull/24701/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `26.39% <ø> (-0.27%)` | :arrow_down: |
| [systests](https://app.codecov.io/gh/apache/pulsar/pull/24701/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `22.66% <ø> (-0.09%)` | :arrow_down: |
| [unittests](https://app.codecov.io/gh/apache/pulsar/pull/24701/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `73.69% <ø> (-0.15%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
[see 93 files with indirect coverage changes](https://app.codecov.io/gh/apache/pulsar/pull/24701/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
- :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org