You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/02/04 16:15:53 UTC

[GitHub] [arrow-datafusion] mkmik opened a new pull request #1747: fix: Case insensitive unquoted identifiers

mkmik opened a new pull request #1747:
URL: https://github.com/apache/arrow-datafusion/pull/1747


   # Which issue does this PR close?
   
   Closes #1746
   
    # Rationale for this change
   
   See #1746
   
   # What changes are included in this PR?
   
   The unquoted sql identifiers a converted to lowercase prior to being used as column references in `sql_expr_to_logical_expr`. We already do the same there when referencing function names.
   
   This PR also adds a test.
   
   # Are there any user-facing changes?
   
   Yes, this change breaks backwards compatibility since it converts to lower case all unquoted column references.
   
   Please discuss in #1746


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-datafusion] alamb merged pull request #1747: fix: Case insensitive unquoted identifiers in SQL

Posted by GitBox <gi...@apache.org>.
alamb merged pull request #1747:
URL: https://github.com/apache/arrow-datafusion/pull/1747


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-datafusion] mkmik commented on pull request #1747: fix: Case insensitive unquoted identifiers in SQL

Posted by GitBox <gi...@apache.org>.
mkmik commented on pull request #1747:
URL: https://github.com/apache/arrow-datafusion/pull/1747#issuecomment-1031348601


   @alamb thanks; I factored out the normalization step in a utility function and called it from a few more places.
   
   I added tests that cover all of the column references I can think of (e.g. aliases, order by, where, group by). I wouldn't be surprised if I missed some, but perhaps we can treat such cases as new bugs.
   
   I specifically didn't cover table name reference normalization here and instead opened #1771 to track that.
   
   PTAL


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org