You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2022/05/10 09:56:24 UTC
[GitHub] [iotdb] liuminghui233 opened a new pull request, #5858: [IOTDB-3079] Implememtation of complete LogicalPlanner
liuminghui233 opened a new pull request, #5858:
URL: https://github.com/apache/iotdb/pull/5858
In this PR, I implememtation of complete LogicalPlanner to support most query statements.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] JackieTien97 commented on a diff in pull request #5858: [IOTDB-3079] Implememtation of complete LogicalPlanner
Posted by GitBox <gi...@apache.org>.
JackieTien97 commented on code in PR #5858:
URL: https://github.com/apache/iotdb/pull/5858#discussion_r870897918
##########
server/src/main/java/org/apache/iotdb/db/mpp/plan/planner/LocalExecutionPlanner.java:
##########
@@ -138,10 +138,12 @@ public static LocalExecutionPlanner getInstance() {
public DataDriver plan(
PlanNode plan,
TypeProvider types,
+ Map<String, List<Integer>> deviceToMeasurementIndexesMap,
Review Comment:
You could put this field into DeviceMergeNode.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] JackieTien97 merged pull request #5858: [IOTDB-3079] Implememtation of complete LogicalPlanner
Posted by GitBox <gi...@apache.org>.
JackieTien97 merged PR #5858:
URL: https://github.com/apache/iotdb/pull/5858
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] liuminghui233 commented on a diff in pull request #5858: [IOTDB-3079] Implememtation of complete LogicalPlanner
Posted by GitBox <gi...@apache.org>.
liuminghui233 commented on code in PR #5858:
URL: https://github.com/apache/iotdb/pull/5858#discussion_r871145461
##########
server/src/main/java/org/apache/iotdb/db/mpp/plan/planner/LocalExecutionPlanner.java:
##########
@@ -138,10 +138,12 @@ public static LocalExecutionPlanner getInstance() {
public DataDriver plan(
PlanNode plan,
TypeProvider types,
+ Map<String, List<Integer>> deviceToMeasurementIndexesMap,
Review Comment:
fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org