You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@activemq.apache.org by cl...@apache.org on 2024/07/22 22:59:14 UTC

(activemq-artemis) branch main updated: NO-JIRA Making test more resilient

This is an automated email from the ASF dual-hosted git repository.

clebertsuconic pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/activemq-artemis.git


The following commit(s) were added to refs/heads/main by this push:
     new 41ec279e22 NO-JIRA Making test more resilient
41ec279e22 is described below

commit 41ec279e2240fd4a84e1c0e7902623682bc5e785
Author: Clebert Suconic <cl...@apache.org>
AuthorDate: Mon Jul 22 18:55:17 2024 -0400

    NO-JIRA Making test more resilient
---
 .../cluster/bridge/PageCounterOnBridgeFailoverTest.java      | 12 ++----------
 1 file changed, 2 insertions(+), 10 deletions(-)

diff --git a/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/cluster/bridge/PageCounterOnBridgeFailoverTest.java b/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/cluster/bridge/PageCounterOnBridgeFailoverTest.java
index 85111e2dd4..3c54162c03 100644
--- a/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/cluster/bridge/PageCounterOnBridgeFailoverTest.java
+++ b/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/cluster/bridge/PageCounterOnBridgeFailoverTest.java
@@ -44,8 +44,6 @@ import java.util.HashMap;
 import java.util.List;
 import java.util.Map;
 
-import static org.junit.jupiter.api.Assertions.assertEquals;
-
 public class PageCounterOnBridgeFailoverTest extends FailoverTestBase {
    private static final Logger logger = LoggerFactory.getLogger(MethodHandles.lookup().lookupClass());
 
@@ -97,16 +95,10 @@ public class PageCounterOnBridgeFailoverTest extends FailoverTestBase {
          logger.info("Waiting for dc1Backup1 to be alive");
          Wait.waitFor(dc1Backup1::isActive, 15000);
          logger.info("dc1Backup1 isAlive");
-         long messageCountNodeDC1 = getMessageCount(dc1Backup1, queueName0);
          long messageCountNodeDC2 = getMessageCount(dc2Primary1, queueName0);
-         logger.info("Count in post office: " + (messageCountNodeDC1 + messageCountNodeDC2) + "messageCountNodeDC1:" + messageCountNodeDC1 + ", messageCountNodeDC2:" + messageCountNodeDC2 + " should be equal to: " + messageSent);
          dc1Backup1.getClusterManager().deployBridge(bridgeConfiguration);
-         Wait.waitFor(() -> getMessageCount(dc2Primary1, queueName0) == messageSent);
-         messageCountNodeDC1 = getMessageCount(dc1Backup1, queueName0);
-         messageCountNodeDC2 = getMessageCount(dc2Primary1, queueName0);
-         logger.info("Count in post office: " + (messageCountNodeDC1 + messageCountNodeDC2) + "messageCountNodeDC1:" + messageCountNodeDC1 + ", messageCountNodeDC2:" + messageCountNodeDC2 + " should be equal to: " + messageSent);
-         assertEquals(messageSent, messageCountNodeDC2);
-         assertEquals(0, messageCountNodeDC1);
+         Wait.assertEquals(messageSent, () -> getMessageCount(dc2Primary1, queueName0));
+         Wait.assertEquals(0, () -> getMessageCount(dc1Backup1, queueName0));
       } finally {
          dc2Primary1.stop();
       }


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@activemq.apache.org
For additional commands, e-mail: commits-help@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact