You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by "strongduanmu (via GitHub)" <gi...@apache.org> on 2026/09/24 02:53:37 UTC

[PR] Minor refactor in MD5AssistedEncryptAlgorithm and ProjectionsSegmentBinder [shardingsphere]

strongduanmu opened a new pull request, #39944:
URL: https://github.com/apache/shardingsphere/pull/39944

   Fixes #ISSUSE_ID.
   
   Changes proposed in this pull request:
     - Minor refactor in MD5AssistedEncryptAlgorithm and ProjectionsSegmentBinder
   
   ---
   
   Before committing this PR, I'm sure that I have checked the following options:
   - [ ] My code follows the [code of conduct](https://shardingsphere.apache.org/community/en/involved/conduct/code/) of this project.
   - [ ] I have self-reviewed the commit code.
   - [ ] I have (or in comment I request) added corresponding labels for the pull request.
   - [ ] I have passed maven check locally : `./mvnw clean install -B -T1C -Dmaven.javadoc.skip -Dmaven.jacoco.skip -e`.
   - [ ] I have made corresponding changes to the documentation.
   - [ ] I have added corresponding unit tests for my changes.
   - [ ] I have updated the Release Notes of the current development version. For more details, see [Update Release Note](https://shardingsphere.apache.org/community/en/involved/contribute/contributor/)
   - [ ] I have disclosed the tool and affected files or scope for any material AI assistance, as required by the [AI-assisted contribution policy].
   
   [AI-assisted contribution policy]: https://github.com/apache/shardingsphere/blob/master/AI_POLICY.md
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Minor refactor in MD5AssistedEncryptAlgorithm and ProjectionsSegmentBinder [shardingsphere]

Posted by "FlyingZC (via GitHub)" <gi...@apache.org>.
FlyingZC merged PR #39944:
URL: https://github.com/apache/shardingsphere/pull/39944


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Minor refactor in MD5AssistedEncryptAlgorithm and ProjectionsSegmentBinder [shardingsphere]

Posted by "strongduanmu (via GitHub)" <gi...@apache.org>.
strongduanmu commented on PR #39944:
URL: https://github.com/apache/shardingsphere/pull/39944#issuecomment-5806796853

     ### Result
   
     **Review Result: Mergeable**
   
     No other critical blocking issues were found within the user-confirmed review scope.
   
     ### Evidence
   
     - The latest PR head remains `035042683e62e2e434caa5f51fd4a9ce9aa45f18`; all four changed files remain unchanged.
     - Exact-file Spotless and Checkstyle verification passed with exit code `0`.
     - The MD5 default encoder configuration normalization and its corresponding test are consistent with the existing call contract.
   
     ### Coverage
   
     - Code Correctness Review; this conclusion covers code scope only.
     - All changed files, root causes, blast radius, and test/runtime paths were reviewed.
     - Tests and the full local CI were not rerun as requested. GitHub CI was not reviewed.
     - Jev was not used; there were 0 MCP calls. Efficiency changes cannot be measured accurately, and no related problems were found.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org