You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by "zyfeier (via GitHub)" <gi...@apache.org> on 2023/08/02 12:38:52 UTC

[GitHub] [nuttx-apps] zyfeier opened a new pull request, #1881: adb: support adb boardctl when not composite device

zyfeier opened a new pull request, #1881:
URL: https://github.com/apache/nuttx-apps/pull/1881

   ## Summary
   
   support adb boardctl when not composite device.
   
   ## Impact
   
   adbd
   
   ## Testing
   
   sim:usbdev


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [nuttx-apps] xiaoxiang781216 merged pull request #1881: adb: support adb boardctl when not composite device

Posted by "xiaoxiang781216 (via GitHub)" <gi...@apache.org>.
xiaoxiang781216 merged PR #1881:
URL: https://github.com/apache/nuttx-apps/pull/1881


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [nuttx-apps] acassis commented on pull request #1881: adb: support adb boardctl when not composite device

Posted by "acassis (via GitHub)" <gi...@apache.org>.
acassis commented on PR #1881:
URL: https://github.com/apache/nuttx-apps/pull/1881#issuecomment-1665675168

   @zyfeier I think you will need to update the bluepill board config:
   ```
   adb_main.c: In function 'adbd_main':
   Error: adb_main.c:91:20: error: 'BOARDIOC_USBDEV_ADB' undeclared (first use in this function); did you mean 'BOARDIOC_USBDEV_NONE'?
      91 |   uint8_t usbdev = BOARDIOC_USBDEV_ADB;
         |                    ^~~~~~~~~~~~~~~~~~~
         |                    BOARDIOC_USBDEV_NONE
   adb_main.c:91:20: note: each undeclared identifier is reported only once for each function it appears in
   ```
   
   Do you have a board to test? Let me know, case you don't have it I can test here


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [nuttx-apps] xiaoxiang781216 commented on pull request #1881: adb: support adb boardctl when not composite device

Posted by "xiaoxiang781216 (via GitHub)" <gi...@apache.org>.
xiaoxiang781216 commented on PR #1881:
URL: https://github.com/apache/nuttx-apps/pull/1881#issuecomment-1665683169

   @acassis BOARDIOC_USBDEV_ADB is defined here: https://github.com/apache/nuttx/pull/10085


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org