You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@geode.apache.org by "Ernest Burghardt (Jira)" <ji...@apache.org> on 2020/01/13 20:06:00 UTC
[jira] [Updated] (GEODE-7695) Remove checking for StartupMessage
type from Membership
[ https://issues.apache.org/jira/browse/GEODE-7695?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ernest Burghardt updated GEODE-7695:
------------------------------------
Description:
{color:#808080}During creation of the Membership module a new marker interface was created to remove a dependency on StartupMessage{color}
{color:#808080}We decided to move this {color}{color:#808080}checking out of membership. Even if we leave this marker in, the javadocs above don't really describe what this is doing or why someone would add this marker to a message.{color}
{color:#808080}in JGroupsMessenger.java{color}
{color:#808080}// admin-only VMs don't have caches, so we ignore cache operations{color}{color:#808080}// multicast to them, avoiding deserialization cost and classpath{color}{color:#808080}// problems{color}{color:#cc7832}if {color}(({color:#9876aa}services{color}.getConfig()
.getVmKind() == MemberIdentifier.{color:#9876aa}ADMIN_ONLY_DM_TYPE{color})
&& (msg {color:#cc7832}instanceof {color}CacheOperationMessageMarker)) {
{color:#cc7832}return;{color}}
was:
{color:#808080}During creation of the Membership module a new marker interface was created to remove a dependency on StartupMessage{color}
{color:#808080}We decided to move this {color}{color:#808080}checking out of membership. Even if we leave this marker in, the javadocs above don't really describe what this is doing or why someone would add this marker to a message.{color}
{color:#808080}// admin-only VMs don't have caches, so we ignore cache operations
{color}{color:#808080}// multicast to them, avoiding deserialization cost and classpath
{color}{color:#808080}// problems
{color}{color:#cc7832}if {color}(({color:#9876aa}services{color}.getConfig()
.getVmKind() == MemberIdentifier.{color:#9876aa}ADMIN_ONLY_DM_TYPE{color})
&& (msg {color:#cc7832}instanceof {color}CacheOperationMessageMarker)) {
{color:#cc7832}return;
{color}}
> Remove checking for StartupMessage type from Membership
> -------------------------------------------------------
>
> Key: GEODE-7695
> URL: https://issues.apache.org/jira/browse/GEODE-7695
> Project: Geode
> Issue Type: Improvement
> Components: membership
> Reporter: Ernest Burghardt
> Priority: Major
>
> {color:#808080}During creation of the Membership module a new marker interface was created to remove a dependency on StartupMessage{color}
> {color:#808080}We decided to move this {color}{color:#808080}checking out of membership. Even if we leave this marker in, the javadocs above don't really describe what this is doing or why someone would add this marker to a message.{color}
>
> {color:#808080}in JGroupsMessenger.java{color}
> {color:#808080}// admin-only VMs don't have caches, so we ignore cache operations{color}{color:#808080}// multicast to them, avoiding deserialization cost and classpath{color}{color:#808080}// problems{color}{color:#cc7832}if {color}(({color:#9876aa}services{color}.getConfig()
> .getVmKind() == MemberIdentifier.{color:#9876aa}ADMIN_ONLY_DM_TYPE{color})
> && (msg {color:#cc7832}instanceof {color}CacheOperationMessageMarker)) {
> {color:#cc7832}return;{color}}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)