You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@solr.apache.org by "nick-boss-tech (via GitHub)" <gi...@apache.org> on 2026/10/01 22:17:40 UTC

[PR] SOLR-18119: Fail Changes.html generation when python3 is missing instead of skipping it [solr]

nick-boss-tech opened a new pull request, #4999:
URL: https://github.com/apache/solr/pull/4999

   🤖 *AI text below* 🤖 *(posted on behalf of Nick Shanin)*
   
   https://issues.apache.org/jira/browse/SOLR-18119
   
   `ChangesToHtmlTask` quietly skipped generating `Changes.html` when `python3` was not found, logging only a warning. Downstream tasks (e.g. broken-link checks) then failed confusingly far from the real cause.
   
   This resolves `python3` via `project.externalTool("python3")` and fails fast with a clear `GradleException` naming the resolved path and telling the user to install Python 3 or pass `-Ppython3.exe=/path/to/python`. The resolved interpreter is also used for the `--version` probe and the generation exec, instead of a bare `"python3"` string.
   
   Tests: build-script change with no unit-test target; verified via `git diff --check` and the local validation sweep.
   
   Changelog: `changelog/unreleased/SOLR-18119.yml` (fixed)
   
   ### AI assistance
   
   AI agents assisted with research, implementation, review, and drafting. Nick Shanin directed the work and takes responsibility for this contribution.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org


Re: [PR] SOLR-18119: Fail Changes.html generation when python3 is missing instead of skipping it [solr]

Posted by "nick-boss-tech (via GitHub)" <gi...@apache.org>.
nick-boss-tech commented on PR #4999:
URL: https://github.com/apache/solr/pull/4999#issuecomment-5997193995

   Renamed to py3Executable in both places and removed the changelog entry; thanks for the review.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org


Re: [PR] SOLR-18119: Fail Changes.html generation when python3 is missing instead of skipping it [solr]

Posted by "nick-boss-tech (via GitHub)" <gi...@apache.org>.
nick-boss-tech closed pull request #4999: SOLR-18119: Fail Changes.html generation when python3 is missing instead of skipping it
URL: https://github.com/apache/solr/pull/4999


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org


Re: [PR] SOLR-18119: Fail Changes.html generation when python3 is missing instead of skipping it [solr]

Posted by "janhoy (via GitHub)" <gi...@apache.org>.
janhoy commented on PR #4999:
URL: https://github.com/apache/solr/pull/4999#issuecomment-5958330696

   Thanks. I think this is a good approach.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org


Re: [PR] SOLR-18119: Fail Changes.html generation when python3 is missing instead of skipping it [solr]

Posted by "janhoy (via GitHub)" <gi...@apache.org>.
janhoy commented on code in PR #4999:
URL: https://github.com/apache/solr/pull/4999#discussion_r4183828888


##########
gradle/documentation/changes-to-html.gradle:
##########
@@ -65,16 +65,17 @@ abstract class ChangesToHtmlTask extends DefaultTask {
   def script
 
   def toHtml() {
-    def output = new ByteArrayOutputStream()
-
-    // Check if Python is available
-    if (!pythonExists()) {
-      logger.warn("WARNING: Python is not installed, skipping creating Changes.html")
-      return
+    def python3 = project.externalTool("python3")

Review Comment:
   I prefer a variable name like `py3Executable` to describe what it holds



##########
gradle/documentation/changes-to-html.gradle:
##########
@@ -105,9 +106,9 @@ abstract class ChangesToHtmlTask extends DefaultTask {
     }
   }
 
-  def pythonExists() {
+  def pythonExists(String python3) {

Review Comment:
   Same here, use `py3Excecutable` as var name



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org


Re: [PR] SOLR-18119: Fail Changes.html generation when python3 is missing instead of skipping it [solr]

Posted by "dsmiley (via GitHub)" <gi...@apache.org>.
dsmiley commented on PR #4999:
URL: https://github.com/apache/solr/pull/4999#issuecomment-6051941279

   I commented in JIRA as in the big picture I wonder if we want gradle to invoke Python at all.  The details of this PR then become moot.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org


Re: [PR] SOLR-18119: Fail Changes.html generation when python3 is missing instead of skipping it [solr]

Posted by "janhoy (via GitHub)" <gi...@apache.org>.
janhoy commented on PR #4999:
URL: https://github.com/apache/solr/pull/4999#issuecomment-6006634464

   @dsmiley This change will fail the (documentation) build if python3 is not installed. This is reported as a bug by Hoss in the JIRA, and I agree it is better to fail the build. 
   
   I ping you since you care about minimizing number of required runtimes for developers. We have tons of python scripts, but as a requirement for gradle build I think there is only one, `checkJavadocLinks.py`. But perhaps we can fully remove the requirement and thus also make those gradle targets work on any CI machine with a JDK. I have confirmed with Claude that it is possible to wire in [GraalPy](https://graalpy.org) in our build such that if no `python3` is installed or provided, we can use GraalPy as a fallback, automatically downloading the runtime and executing the `changes2html.py` script using it. The build could then also use the same techique for `checkJavadocLinks.py`.
   
   Wdyt? That solution would, if chosen, invalidate this PR.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org


Re: [PR] SOLR-18119: Fail Changes.html generation when python3 is missing instead of skipping it [solr]

Posted by "nick-boss-tech (via GitHub)" <gi...@apache.org>.
nick-boss-tech commented on PR #4999:
URL: https://github.com/apache/solr/pull/4999#issuecomment-6355917640

   Already handled in other PRa. Closing. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org