[GitHub] [ozone] linyiqun commented on a change in pull request #1696: HDDS-4582 Update `quota in counts` to `quota in namespace`

[GitBox <gi...@apache.org>]

linyiqun commented on a change in pull request #1696:
URL: https://github.com/apache/ozone/pull/1696#discussion_r542088595



##########
File path: hadoop-ozone/dist/src/main/smoketest/basic/ozone-shell-lib.robot
##########
@@ -48,12 +48,12 @@ Test ozone shell
                     Should Be Equal     ${result}       DISK
     ${result} =     Execute             ozone sh bucket info ${protocol}${server}/${volume}/bb1 | jq -r '. | select(.name=="bb1") | .quotaInBytes'
                     Should Be Equal     ${result}       10995116277760
-    ${result} =     Execute             ozone sh bucket info ${protocol}${server}/${volume}/bb1 | jq -r '. | select(.name=="bb1") | .quotaInCounts'
+    ${result} =     Execute             ozone sh bucket info ${protocol}${server}/${volume}/bb1 | jq -r '. | select(.name=="bb1") | .quotaInNamespace'
                     Should Be Equal     ${result}       100
                     Execute             ozone sh bucket setquota ${protocol}${server}/${volume}/bb1 --space-quota 1TB --count-quota 1000

Review comment:
       Once option --count-quota is updated to --namespace-quota, this file also needed to be updated.

##########
File path: hadoop-ozone/tools/src/main/java/org/apache/hadoop/ozone/shell/SetSpaceQuotaOptions.java
##########
@@ -32,14 +32,14 @@
   @CommandLine.Option(names = {"--count-quota"},
       description = "For volume this parameter represents the number of " +

Review comment:
       Can you also rename '--count-quota' to '--namespace-quota'?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org