You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@celix.apache.org by "PengZheng (via GitHub)" <gi...@apache.org> on 2023/12/25 07:20:54 UTC
[PR] Hotfix/mac os ninja build (celix)
PengZheng opened a new pull request, #705:
URL: https://github.com/apache/celix/pull/705
These days `macos-build-brew` timeouts frequently, see #704.
I observe it does not happen for `macos-build-conan`.
The obvious difference between these two builds is the usage of ninja/make.
Without a mac at hand, I will switch `macos-build-brew` to use ninja to avoid these annoying issues.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@celix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Hotfix/mac os ninja build (celix)
Posted by "PengZheng (via GitHub)" <gi...@apache.org>.
PengZheng merged PR #705:
URL: https://github.com/apache/celix/pull/705
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@celix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Hotfix/mac os ninja build (celix)
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #705:
URL: https://github.com/apache/celix/pull/705#issuecomment-1868819609
## [Codecov](https://app.codecov.io/gh/apache/celix/pull/705?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
All modified and coverable lines are covered by tests :white_check_mark:
> Comparison is base [(`d62eeef`)](https://app.codecov.io/gh/apache/celix/commit/d62eeefbc69d0d19d8f290bc33f0d514af9adc41?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) 88.26% compared to head [(`88f1cdb`)](https://app.codecov.io/gh/apache/celix/pull/705?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) 88.31%.
> :exclamation: Current head 88f1cdb differs from pull request most recent head b737015. Consider uploading reports for the commit b737015 to get more accurate results
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #705 +/- ##
==========================================
+ Coverage 88.26% 88.31% +0.05%
==========================================
Files 215 215
Lines 24562 24562
==========================================
+ Hits 21679 21693 +14
+ Misses 2883 2869 -14
```
</details>
[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/celix/pull/705?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@celix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org