[jira] [Commented] (AIRFLOW-6091) BigQueryCursor doesn't properly clean buffer, page_token and all_pages_loaded before starting .execute() method

["ASF GitHub Bot (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/AIRFLOW-6091?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16996213#comment-16996213 ] 

ASF GitHub Bot commented on AIRFLOW-6091:
-----------------------------------------

potiuk commented on pull request #6683: [AIRFLOW-6091] Add flushing in execute method for BigQueryCursor
URL: https://github.com/apache/airflow/pull/6683
 
 
   
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> BigQueryCursor doesn't properly clean buffer, page_token and all_pages_loaded before starting .execute() method
> ---------------------------------------------------------------------------------------------------------------
>
>                 Key: AIRFLOW-6091
>                 URL: https://issues.apache.org/jira/browse/AIRFLOW-6091
>             Project: Apache Airflow
>          Issue Type: Bug
>          Components: hooks
>    Affects Versions: 1.10.6
>            Reporter: Tomasz Żukowski
>            Assignee: Tomasz Żukowski
>            Priority: Major
>
> There are two cases when it might be dangerous:
>  * If you run cursor.execute() and cursor.fetchall() and then once again cursor.execute() for another query cursor.fetchall() will return empty list because will be still set to True
>  * If you run cursor.execute() and cursor.fetchone() or fetchmany() and don't read whole results and then run cursor.execute() with different query next call to next will return data from old job which will be still stored in buffer.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)