You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@samza.apache.org by GitBox <gi...@apache.org> on 2019/05/22 19:18:47 UTC

[GitHub] [samza] mynameborat commented on a change in pull request #1046: SAMZA-2211: [Cleanup] Move RunLoop to container package

mynameborat commented on a change in pull request #1046: SAMZA-2211: [Cleanup] Move RunLoop to container package
URL: https://github.com/apache/samza/pull/1046#discussion_r286630223
 
 

 ##########
 File path: samza-core/src/main/java/org/apache/samza/task/EpochTimeScheduler.java
 ##########
 @@ -81,7 +81,7 @@ private EpochTimeScheduler(ScheduledExecutorService executor) {
     }
   }
 
-  void registerListener(TimerListener listener) {
+  public void registerListener(TimerListener listener) {
 
 Review comment:
   I noticed we have a scheduler package and CallbackSchedulerImpl is the main consumer of this class. 
   Ended up moving it there. Let me know if you think we consolidate scheduler and container package.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services