You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/07/16 19:00:58 UTC
[GitHub] [incubator-superset] codecov-commenter commented on pull request #10347: feat: update dataset editor modal
codecov-commenter commented on pull request #10347:
URL: https://github.com/apache/incubator-superset/pull/10347#issuecomment-659607908
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10347?src=pr&el=h1) Report
> Merging [#10347](https://codecov.io/gh/apache/incubator-superset/pull/10347?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/e4c9c7364bbcecdbbe008ce5e6ce9065c28b3dfc&el=desc) will **decrease** coverage by `0.72%`.
> The diff coverage is `83.33%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/10347?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #10347 +/- ##
==========================================
- Coverage 70.61% 69.89% -0.73%
==========================================
Files 601 196 -405
Lines 32225 18952 -13273
Branches 3257 0 -3257
==========================================
- Hits 22757 13247 -9510
+ Misses 9365 5705 -3660
+ Partials 103 0 -103
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `?` | |
| #javascript | `?` | |
| #python | `69.89% <83.33%> (-0.04%)` | :arrow_down: |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/10347?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/datasets/api.py](https://codecov.io/gh/apache/incubator-superset/pull/10347/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YXNldHMvYXBpLnB5) | `92.02% <ø> (ø)` | |
| [superset/connectors/druid/models.py](https://codecov.io/gh/apache/incubator-superset/pull/10347/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9kcnVpZC9tb2RlbHMucHk=) | `82.48% <66.66%> (-0.06%)` | :arrow_down: |
| [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/incubator-superset/pull/10347/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `89.18% <100.00%> (-0.70%)` | :arrow_down: |
| [superset/db\_engine\_specs/sqlite.py](https://codecov.io/gh/apache/incubator-superset/pull/10347/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3NxbGl0ZS5weQ==) | `64.51% <0.00%> (-9.68%)` | :arrow_down: |
| [superset/db\_engine\_specs/postgres.py](https://codecov.io/gh/apache/incubator-superset/pull/10347/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3Bvc3RncmVzLnB5) | `97.36% <0.00%> (-2.64%)` | :arrow_down: |
| [superset/result\_set.py](https://codecov.io/gh/apache/incubator-superset/pull/10347/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVzdWx0X3NldC5weQ==) | `96.63% <0.00%> (-1.69%)` | :arrow_down: |
| [superset/sql\_lab.py](https://codecov.io/gh/apache/incubator-superset/pull/10347/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX2xhYi5weQ==) | `77.92% <0.00%> (-0.44%)` | :arrow_down: |
| [superset/sql\_parse.py](https://codecov.io/gh/apache/incubator-superset/pull/10347/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3BhcnNlLnB5) | `99.30% <0.00%> (-0.01%)` | :arrow_down: |
| [superset/errors.py](https://codecov.io/gh/apache/incubator-superset/pull/10347/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXJyb3JzLnB5) | `100.00% <0.00%> (ø)` | |
| ... and [402 more](https://codecov.io/gh/apache/incubator-superset/pull/10347/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10347?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10347?src=pr&el=footer). Last update [e4c9c73...079b221](https://codecov.io/gh/apache/incubator-superset/pull/10347?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org