You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by "apupier (via GitHub)" <gi...@apache.org> on 2026/06/10 09:00:30 UTC

[PR] CAMEL-23194: Fix JMS shutdown deadlock that hangs CI builds [camel]

apupier opened a new pull request, #23904:
URL: https://github.com/apache/camel/pull/23904

   Root cause: deadlock between BaseService.lock and Spring's lifecycleMonitor during CamelContext shutdown in afterAll.
   
   Thread 1 (afterAll -> context.stop()):
     AbstractCamelContext.doStop()
       -> JmsProducer.doStop()
         -> ReplyManagerSupport.doStop()
           -> DefaultMessageListenerContainer.doShutdown()
             -> Object.wait() <- blocked, waiting for listener thread
   
   Thread 2 (QueueReplyManager listener):
     DestinationResolverDelegate.resolveDestinationName()
       -> BaseService.lock <- blocked, held by Thread 1
   
   Introduced by CAMEL-20199 (Oct 2024) which migrated synchronized blocks to ReentrantLock. Before: BaseService.stop() used synchronized(lock) on a private Object, while the inner class used synchronized(QueueReplyManager.this) on the instance monitor — two independent locks. After: both became QueueReplyManager.this.lock (the same inherited ReentrantLock), creating the circular wait.
   
   Fix: DestinationResolverDelegate now uses a dedicated ReentrantLock instead of BaseService.lock, restoring the original two-lock design. Added volatile + fast-path for the destination field.
   
   Applied to both camel-jms and camel-sjms which share the same pattern via their respective QueueReplyManager classes.
   
   # Description
   
   currently most if the 4.18.x builds ends up stucked until timeout, see [CAMEL-23710](https://issues.apache.org/jira/browse/CAMEL-23710)
   
   # Target
   
   - [ ] I checked that the commit is targeting the correct branch (Camel 4 uses the `main` branch)
   
   # Tracking
   - [ ] If this is a large change, bug fix, or code improvement, I checked there is a [JIRA issue](https://issues.apache.org/jira/browse/CAMEL) filed for the change (usually before you start working on it).
   
   <!--
   # *Note*: trivial changes like, typos, minor documentation fixes and other small items do not require a JIRA issue. In this case your pull request should address just this issue, without pulling in other changes.
   -->
   
   # Apache Camel coding standards and style
   
   - [ ] I checked that each commit in the pull request has a meaningful subject line and body.
   
   <!--
   If you're unsure, you can format the pull request title like `[CAMEL-XXX] Fixes bug in camel-file component`, where you replace `CAMEL-XXX` with the appropriate JIRA issue.
   -->
   
   - [ ] I have run `mvn clean install -DskipTests` locally from root folder and I have committed all auto-generated changes.
   
   <!--
   You can run the aforementioned command in your module so that the build auto-formats your code. This will also be verified as part of the checks and your PR may be rejected if if there are uncommited changes after running `mvn clean install -DskipTests`.
   
   You can learn more about the contribution guidelines at https://github.com/apache/camel/blob/main/CONTRIBUTING.md
   -->
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] CAMEL-23194: Fix JMS shutdown deadlock that hangs CI builds [camel]

Posted by "apupier (via GitHub)" <gi...@apache.org>.
apupier merged PR #23904:
URL: https://github.com/apache/camel/pull/23904


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org