You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@commons.apache.org by pa...@apache.org on 2018/11/20 17:21:46 UTC
[3/6] [lang] Make whitespace use after tokens consistent and add a
checkstyle rule to enforce it.
http://git-wip-us.apache.org/repos/asf/commons-lang/blob/89cbfa54/src/main/java/org/apache/commons/lang3/text/translate/OctalUnescaper.java
----------------------------------------------------------------------
diff --git a/src/main/java/org/apache/commons/lang3/text/translate/OctalUnescaper.java b/src/main/java/org/apache/commons/lang3/text/translate/OctalUnescaper.java
index e8ac357..77c9ca6 100644
--- a/src/main/java/org/apache/commons/lang3/text/translate/OctalUnescaper.java
+++ b/src/main/java/org/apache/commons/lang3/text/translate/OctalUnescaper.java
@@ -42,7 +42,7 @@ public class OctalUnescaper extends CharSequenceTranslator {
public int translate(final CharSequence input, final int index, final Writer out) throws IOException {
final int remaining = input.length() - index - 1; // how many characters left, ignoring the first \
final StringBuilder builder = new StringBuilder();
- if(input.charAt(index) == '\\' && remaining > 0 && isOctalDigit(input.charAt(index + 1)) ) {
+ if (input.charAt(index) == '\\' && remaining > 0 && isOctalDigit(input.charAt(index + 1)) ) {
final int next = index + 1;
final int next2 = index + 2;
final int next3 = index + 3;
@@ -50,9 +50,9 @@ public class OctalUnescaper extends CharSequenceTranslator {
// we know this is good as we checked it in the if block above
builder.append(input.charAt(next));
- if(remaining > 1 && isOctalDigit(input.charAt(next2))) {
+ if (remaining > 1 && isOctalDigit(input.charAt(next2))) {
builder.append(input.charAt(next2));
- if(remaining > 2 && isZeroToThree(input.charAt(next)) && isOctalDigit(input.charAt(next3))) {
+ if (remaining > 2 && isZeroToThree(input.charAt(next)) && isOctalDigit(input.charAt(next3))) {
builder.append(input.charAt(next3));
}
}
http://git-wip-us.apache.org/repos/asf/commons-lang/blob/89cbfa54/src/main/java/org/apache/commons/lang3/text/translate/UnicodeEscaper.java
----------------------------------------------------------------------
diff --git a/src/main/java/org/apache/commons/lang3/text/translate/UnicodeEscaper.java b/src/main/java/org/apache/commons/lang3/text/translate/UnicodeEscaper.java
index 5771d15..5ccac6a 100644
--- a/src/main/java/org/apache/commons/lang3/text/translate/UnicodeEscaper.java
+++ b/src/main/java/org/apache/commons/lang3/text/translate/UnicodeEscaper.java
@@ -37,7 +37,7 @@ public class UnicodeEscaper extends CodePointTranslator {
/**
* <p>Constructs a <code>UnicodeEscaper</code> for all characters. </p>
*/
- public UnicodeEscaper(){
+ public UnicodeEscaper() {
this(0, Integer.MAX_VALUE, true);
}
http://git-wip-us.apache.org/repos/asf/commons-lang/blob/89cbfa54/src/main/java/org/apache/commons/lang3/time/DateUtils.java
----------------------------------------------------------------------
diff --git a/src/main/java/org/apache/commons/lang3/time/DateUtils.java b/src/main/java/org/apache/commons/lang3/time/DateUtils.java
index e917bf9..cbad16d 100644
--- a/src/main/java/org/apache/commons/lang3/time/DateUtils.java
+++ b/src/main/java/org/apache/commons/lang3/time/DateUtils.java
@@ -1662,7 +1662,7 @@ public class DateUtils {
* @since 2.4
*/
private static long getFragment(final Calendar calendar, final int fragment, final TimeUnit unit) {
- if(calendar == null) {
+ if (calendar == null) {
throw new IllegalArgumentException("The date must not be null");
}
@@ -1701,7 +1701,7 @@ public class DateUtils {
case Calendar.SECOND:
result += unit.convert(calendar.get(Calendar.MILLISECOND), TimeUnit.MILLISECONDS);
break;
- case Calendar.MILLISECOND: break;//never useful
+ case Calendar.MILLISECOND: break; //never useful
default: throw new IllegalArgumentException("The fragment " + fragment + " is not supported");
}
return result;
http://git-wip-us.apache.org/repos/asf/commons-lang/blob/89cbfa54/src/main/java/org/apache/commons/lang3/time/DurationFormatUtils.java
----------------------------------------------------------------------
diff --git a/src/main/java/org/apache/commons/lang3/time/DurationFormatUtils.java b/src/main/java/org/apache/commons/lang3/time/DurationFormatUtils.java
index 8c6e20a..5ed08c7 100644
--- a/src/main/java/org/apache/commons/lang3/time/DurationFormatUtils.java
+++ b/src/main/java/org/apache/commons/lang3/time/DurationFormatUtils.java
@@ -344,7 +344,7 @@ public class DurationFormatUtils {
} else {
// there are no M's in the format string
- if( !Token.containsTokenWithValue(tokens, y) ) {
+ if ( !Token.containsTokenWithValue(tokens, y) ) {
int target = end.get(Calendar.YEAR);
if (months < 0) {
// target is end-year -1
@@ -369,7 +369,7 @@ public class DurationFormatUtils {
years = 0;
}
- while( start.get(Calendar.MONTH) != end.get(Calendar.MONTH) ) {
+ while ( start.get(Calendar.MONTH) != end.get(Calendar.MONTH) ) {
days += start.getActualMaximum(Calendar.DAY_OF_MONTH);
start.add(Calendar.MONTH, 1);
}
http://git-wip-us.apache.org/repos/asf/commons-lang/blob/89cbfa54/src/main/java/org/apache/commons/lang3/time/FastDateParser.java
----------------------------------------------------------------------
diff --git a/src/main/java/org/apache/commons/lang3/time/FastDateParser.java b/src/main/java/org/apache/commons/lang3/time/FastDateParser.java
index ed0301e..783acb8 100644
--- a/src/main/java/org/apache/commons/lang3/time/FastDateParser.java
+++ b/src/main/java/org/apache/commons/lang3/time/FastDateParser.java
@@ -79,7 +79,7 @@ public class FastDateParser implements DateParser, Serializable {
*/
private static final long serialVersionUID = 3L;
- static final Locale JAPANESE_IMPERIAL = new Locale("ja","JP","JP");
+ static final Locale JAPANESE_IMPERIAL = new Locale("ja", "JP", "JP");
// defining fields
private final String pattern;
@@ -135,10 +135,10 @@ public class FastDateParser implements DateParser, Serializable {
final Calendar definingCalendar = Calendar.getInstance(timeZone, locale);
int centuryStartYear;
- if(centuryStart!=null) {
+ if (centuryStart!=null) {
definingCalendar.setTime(centuryStart);
centuryStartYear= definingCalendar.get(Calendar.YEAR);
- } else if(locale.equals(JAPANESE_IMPERIAL)) {
+ } else if (locale.equals(JAPANESE_IMPERIAL)) {
centuryStartYear= 0;
} else {
// from 80 years ago to 20 years from now
@@ -161,9 +161,9 @@ public class FastDateParser implements DateParser, Serializable {
patterns = new ArrayList<>();
final StrategyParser fm = new StrategyParser(definingCalendar);
- for(;;) {
+ for (;;) {
final StrategyAndWidth field = fm.getNextStrategy();
- if(field==null) {
+ if (field==null) {
break;
}
patterns.add(field);
@@ -186,7 +186,7 @@ public class FastDateParser implements DateParser, Serializable {
}
int getMaxWidth(final ListIterator<StrategyAndWidth> lt) {
- if(!strategy.isNumber() || !lt.hasNext()) {
+ if (!strategy.isNumber() || !lt.hasNext()) {
return 0;
}
final Strategy nextStrategy = lt.next().strategy;
@@ -448,7 +448,7 @@ public class FastDateParser implements DateParser, Serializable {
sb.append(c);
}
}
- if(sb.charAt(sb.length() - 1) == '.') {
+ if (sb.charAt(sb.length() - 1) == '.') {
// trailing '.' is optional
sb.append('?');
}
@@ -719,7 +719,7 @@ public class FastDateParser implements DateParser, Serializable {
void setCalendar(final FastDateParser parser, final Calendar cal, final String value) {
final String lowerCase = value.toLowerCase(locale);
Integer iVal = lKeyValues.get(lowerCase);
- if(iVal == null) {
+ if (iVal == null) {
// match missing the optional trailing period
iVal = lKeyValues.get(lowerCase + '.');
}
http://git-wip-us.apache.org/repos/asf/commons-lang/blob/89cbfa54/src/main/java/org/apache/commons/lang3/time/FastDatePrinter.java
----------------------------------------------------------------------
diff --git a/src/main/java/org/apache/commons/lang3/time/FastDatePrinter.java b/src/main/java/org/apache/commons/lang3/time/FastDatePrinter.java
index eaf95e8..a5edb28 100644
--- a/src/main/java/org/apache/commons/lang3/time/FastDatePrinter.java
+++ b/src/main/java/org/apache/commons/lang3/time/FastDatePrinter.java
@@ -488,7 +488,7 @@ public class FastDatePrinter implements DatePrinter, Serializable {
public StringBuffer format(final long millis, final StringBuffer buf) {
final Calendar c = newCalendar();
c.setTimeInMillis(millis);
- return (StringBuffer) applyRules(c, (Appendable)buf);
+ return (StringBuffer) applyRules(c, (Appendable) buf);
}
/* (non-Javadoc)
@@ -498,7 +498,7 @@ public class FastDatePrinter implements DatePrinter, Serializable {
public StringBuffer format(final Date date, final StringBuffer buf) {
final Calendar c = newCalendar();
c.setTime(date);
- return (StringBuffer) applyRules(c, (Appendable)buf);
+ return (StringBuffer) applyRules(c, (Appendable) buf);
}
/* (non-Javadoc)
@@ -536,8 +536,8 @@ public class FastDatePrinter implements DatePrinter, Serializable {
@Override
public <B extends Appendable> B format(Calendar calendar, final B buf) {
// do not pass in calendar directly, this will cause TimeZone of FastDatePrinter to be ignored
- if(!calendar.getTimeZone().equals(mTimeZone)) {
- calendar = (Calendar)calendar.clone();
+ if (!calendar.getTimeZone().equals(mTimeZone)) {
+ calendar = (Calendar) calendar.clone();
calendar.setTimeZone(mTimeZone);
}
return applyRules(calendar, buf);
@@ -555,7 +555,7 @@ public class FastDatePrinter implements DatePrinter, Serializable {
*/
@Deprecated
protected StringBuffer applyRules(final Calendar calendar, final StringBuffer buf) {
- return (StringBuffer) applyRules(calendar, (Appendable)buf);
+ return (StringBuffer) applyRules(calendar, (Appendable) buf);
}
/**
@@ -678,8 +678,8 @@ public class FastDatePrinter implements DatePrinter, Serializable {
* @param value the value to append digits from.
*/
private static void appendDigits(final Appendable buffer, final int value) throws IOException {
- buffer.append((char)(value / 10 + '0'));
- buffer.append((char)(value % 10 + '0'));
+ buffer.append((char) (value / 10 + '0'));
+ buffer.append((char) (value % 10 + '0'));
}
private static final int MAX_DIGITS = 10; // log10(Integer.MAX_VALUE) ~= 9.3
@@ -939,7 +939,7 @@ public class FastDatePrinter implements DatePrinter, Serializable {
@Override
public final void appendTo(final Appendable buffer, final int value) throws IOException {
if (value < 10) {
- buffer.append((char)(value + '0'));
+ buffer.append((char) (value + '0'));
} else if (value < 100) {
appendDigits(buffer, value);
} else {
@@ -984,7 +984,7 @@ public class FastDatePrinter implements DatePrinter, Serializable {
@Override
public final void appendTo(final Appendable buffer, final int value) throws IOException {
if (value < 10) {
- buffer.append((char)(value + '0'));
+ buffer.append((char) (value + '0'));
} else {
appendDigits(buffer, value);
}
@@ -1562,7 +1562,7 @@ public class FastDatePrinter implements DatePrinter, Serializable {
return true;
}
if (obj instanceof TimeZoneDisplayKey) {
- final TimeZoneDisplayKey other = (TimeZoneDisplayKey)obj;
+ final TimeZoneDisplayKey other = (TimeZoneDisplayKey) obj;
return
mTimeZone.equals(other.mTimeZone) &&
mStyle == other.mStyle &&
http://git-wip-us.apache.org/repos/asf/commons-lang/blob/89cbfa54/src/main/java/org/apache/commons/lang3/time/FormatCache.java
----------------------------------------------------------------------
diff --git a/src/main/java/org/apache/commons/lang3/time/FormatCache.java b/src/main/java/org/apache/commons/lang3/time/FormatCache.java
index 1cb711a..075cdc7 100644
--- a/src/main/java/org/apache/commons/lang3/time/FormatCache.java
+++ b/src/main/java/org/apache/commons/lang3/time/FormatCache.java
@@ -32,7 +32,7 @@ import org.apache.commons.lang3.Validate;
*
* @since 3.0
*/
-// TODO: Before making public move from getDateTimeInstance(Integer,...) to int; or some other approach.
+// TODO: Before making public move from getDateTimeInstance(Integer, ...) to int; or some other approach.
abstract class FormatCache<F extends Format> {
/**
@@ -201,7 +201,7 @@ abstract class FormatCache<F extends Format> {
} else {
formatter = DateFormat.getDateTimeInstance(dateStyle.intValue(), timeStyle.intValue(), locale);
}
- pattern = ((SimpleDateFormat)formatter).toPattern();
+ pattern = ((SimpleDateFormat) formatter).toPattern();
final String previous = cDateTimeInstanceCache.putIfAbsent(key, pattern);
if (previous != null) {
// even though it doesn't matter if another thread put the pattern
@@ -240,7 +240,7 @@ abstract class FormatCache<F extends Format> {
// Eliminate the usual boilerplate because
// this inner static class is only used in a generic ConcurrentHashMap
// which will not compare against other Object types
- return Arrays.equals(keys, ((MultipartKey)obj).keys);
+ return Arrays.equals(keys, ((MultipartKey) obj).keys);
}
/**
@@ -248,10 +248,10 @@ abstract class FormatCache<F extends Format> {
*/
@Override
public int hashCode() {
- if(hashCode==0) {
+ if (hashCode==0) {
int rc= 0;
- for(final Object key : keys) {
- if(key!=null) {
+ for (final Object key : keys) {
+ if (key!=null) {
rc= rc*7 + key.hashCode();
}
}
http://git-wip-us.apache.org/repos/asf/commons-lang/blob/89cbfa54/src/test/java/org/apache/commons/lang3/ArrayUtilsAddTest.java
----------------------------------------------------------------------
diff --git a/src/test/java/org/apache/commons/lang3/ArrayUtilsAddTest.java b/src/test/java/org/apache/commons/lang3/ArrayUtilsAddTest.java
index bbd1c8a..5396d43 100644
--- a/src/test/java/org/apache/commons/lang3/ArrayUtilsAddTest.java
+++ b/src/test/java/org/apache/commons/lang3/ArrayUtilsAddTest.java
@@ -34,12 +34,12 @@ import org.junit.jupiter.api.Test;
public class ArrayUtilsAddTest {
@Test
- public void testJira567(){
+ public void testJira567() {
Number[] n;
// Valid array construction
n = ArrayUtils.addAll(new Number[]{Integer.valueOf(1)}, new Long[]{Long.valueOf(2)});
- assertEquals(2,n.length);
- assertEquals(Number.class,n.getClass().getComponentType());
+ assertEquals(2, n.length);
+ assertEquals(Number.class, n.getClass().getComponentType());
// Invalid - can't store Long in Integer array
assertThrows(IllegalArgumentException.class,
() -> ArrayUtils.addAll(new Integer[]{Integer.valueOf(1)}, new Long[]{Long.valueOf(2)}));
@@ -63,17 +63,17 @@ public class ArrayUtilsAddTest {
@Test
public void testAddObjectArrayByte() {
byte[] newArray;
- newArray = ArrayUtils.add((byte[])null, (byte)0);
+ newArray = ArrayUtils.add((byte[]) null, (byte) 0);
assertTrue(Arrays.equals(new byte[]{0}, newArray));
assertEquals(Byte.TYPE, newArray.getClass().getComponentType());
- newArray = ArrayUtils.add((byte[])null, (byte)1);
+ newArray = ArrayUtils.add((byte[]) null, (byte) 1);
assertTrue(Arrays.equals(new byte[]{1}, newArray));
assertEquals(Byte.TYPE, newArray.getClass().getComponentType());
final byte[] array1 = new byte[]{1, 2, 3};
- newArray = ArrayUtils.add(array1, (byte)0);
+ newArray = ArrayUtils.add(array1, (byte) 0);
assertTrue(Arrays.equals(new byte[]{1, 2, 3, 0}, newArray));
assertEquals(Byte.TYPE, newArray.getClass().getComponentType());
- newArray = ArrayUtils.add(array1, (byte)4);
+ newArray = ArrayUtils.add(array1, (byte) 4);
assertTrue(Arrays.equals(new byte[]{1, 2, 3, 4}, newArray));
assertEquals(Byte.TYPE, newArray.getClass().getComponentType());
}
@@ -81,17 +81,17 @@ public class ArrayUtilsAddTest {
@Test
public void testAddObjectArrayChar() {
char[] newArray;
- newArray = ArrayUtils.add((char[])null, (char)0);
+ newArray = ArrayUtils.add((char[]) null, (char) 0);
assertTrue(Arrays.equals(new char[]{0}, newArray));
assertEquals(Character.TYPE, newArray.getClass().getComponentType());
- newArray = ArrayUtils.add((char[])null, (char)1);
+ newArray = ArrayUtils.add((char[]) null, (char) 1);
assertTrue(Arrays.equals(new char[]{1}, newArray));
assertEquals(Character.TYPE, newArray.getClass().getComponentType());
final char[] array1 = new char[]{1, 2, 3};
- newArray = ArrayUtils.add(array1, (char)0);
+ newArray = ArrayUtils.add(array1, (char) 0);
assertTrue(Arrays.equals(new char[]{1, 2, 3, 0}, newArray));
assertEquals(Character.TYPE, newArray.getClass().getComponentType());
- newArray = ArrayUtils.add(array1, (char)4);
+ newArray = ArrayUtils.add(array1, (char) 4);
assertTrue(Arrays.equals(new char[]{1, 2, 3, 4}, newArray));
assertEquals(Character.TYPE, newArray.getClass().getComponentType());
}
@@ -99,10 +99,10 @@ public class ArrayUtilsAddTest {
@Test
public void testAddObjectArrayDouble() {
double[] newArray;
- newArray = ArrayUtils.add((double[])null, 0);
+ newArray = ArrayUtils.add((double[]) null, 0);
assertTrue(Arrays.equals(new double[]{0}, newArray));
assertEquals(Double.TYPE, newArray.getClass().getComponentType());
- newArray = ArrayUtils.add((double[])null, 1);
+ newArray = ArrayUtils.add((double[]) null, 1);
assertTrue(Arrays.equals(new double[]{1}, newArray));
assertEquals(Double.TYPE, newArray.getClass().getComponentType());
final double[] array1 = new double[]{1, 2, 3};
@@ -117,10 +117,10 @@ public class ArrayUtilsAddTest {
@Test
public void testAddObjectArrayFloat() {
float[] newArray;
- newArray = ArrayUtils.add((float[])null, 0);
+ newArray = ArrayUtils.add((float[]) null, 0);
assertTrue(Arrays.equals(new float[]{0}, newArray));
assertEquals(Float.TYPE, newArray.getClass().getComponentType());
- newArray = ArrayUtils.add((float[])null, 1);
+ newArray = ArrayUtils.add((float[]) null, 1);
assertTrue(Arrays.equals(new float[]{1}, newArray));
assertEquals(Float.TYPE, newArray.getClass().getComponentType());
final float[] array1 = new float[]{1, 2, 3};
@@ -135,10 +135,10 @@ public class ArrayUtilsAddTest {
@Test
public void testAddObjectArrayInt() {
int[] newArray;
- newArray = ArrayUtils.add((int[])null, 0);
+ newArray = ArrayUtils.add((int[]) null, 0);
assertTrue(Arrays.equals(new int[]{0}, newArray));
assertEquals(Integer.TYPE, newArray.getClass().getComponentType());
- newArray = ArrayUtils.add((int[])null, 1);
+ newArray = ArrayUtils.add((int[]) null, 1);
assertTrue(Arrays.equals(new int[]{1}, newArray));
assertEquals(Integer.TYPE, newArray.getClass().getComponentType());
final int[] array1 = new int[]{1, 2, 3};
@@ -153,10 +153,10 @@ public class ArrayUtilsAddTest {
@Test
public void testAddObjectArrayLong() {
long[] newArray;
- newArray = ArrayUtils.add((long[])null, 0);
+ newArray = ArrayUtils.add((long[]) null, 0);
assertTrue(Arrays.equals(new long[]{0}, newArray));
assertEquals(Long.TYPE, newArray.getClass().getComponentType());
- newArray = ArrayUtils.add((long[])null, 1);
+ newArray = ArrayUtils.add((long[]) null, 1);
assertTrue(Arrays.equals(new long[]{1}, newArray));
assertEquals(Long.TYPE, newArray.getClass().getComponentType());
final long[] array1 = new long[]{1, 2, 3};
@@ -171,17 +171,17 @@ public class ArrayUtilsAddTest {
@Test
public void testAddObjectArrayShort() {
short[] newArray;
- newArray = ArrayUtils.add((short[])null, (short)0);
+ newArray = ArrayUtils.add((short[]) null, (short) 0);
assertTrue(Arrays.equals(new short[]{0}, newArray));
assertEquals(Short.TYPE, newArray.getClass().getComponentType());
- newArray = ArrayUtils.add((short[])null, (short)1);
+ newArray = ArrayUtils.add((short[]) null, (short) 1);
assertTrue(Arrays.equals(new short[]{1}, newArray));
assertEquals(Short.TYPE, newArray.getClass().getComponentType());
final short[] array1 = new short[]{1, 2, 3};
- newArray = ArrayUtils.add(array1, (short)0);
+ newArray = ArrayUtils.add(array1, (short) 0);
assertTrue(Arrays.equals(new short[]{1, 2, 3, 0}, newArray));
assertEquals(Short.TYPE, newArray.getClass().getComponentType());
- newArray = ArrayUtils.add(array1, (short)4);
+ newArray = ArrayUtils.add(array1, (short) 4);
assertTrue(Arrays.equals(new short[]{1, 2, 3, 4}, newArray));
assertEquals(Short.TYPE, newArray.getClass().getComponentType());
}
@@ -191,7 +191,7 @@ public class ArrayUtilsAddTest {
Object[] newArray;
//show that not casting is okay
- newArray = ArrayUtils.add((Object[])null, "a");
+ newArray = ArrayUtils.add((Object[]) null, "a");
assertTrue(Arrays.equals(new String[]{"a"}, newArray));
assertTrue(Arrays.equals(new Object[]{"a"}, newArray));
assertEquals(String.class, newArray.getClass().getComponentType());
@@ -224,7 +224,7 @@ public class ArrayUtilsAddTest {
@Test
@SuppressWarnings("deprecation")
- public void testLANG571(){
+ public void testLANG571() {
final String[] stringArray=null;
final String aString=null;
assertThrows(IllegalArgumentException.class, () -> ArrayUtils.add(stringArray, aString));
@@ -353,7 +353,7 @@ public class ArrayUtilsAddTest {
@Test
public void testAddObjectAtIndex() {
Object[] newArray;
- newArray = ArrayUtils.add((Object[])null, 0, "a");
+ newArray = ArrayUtils.add((Object[]) null, 0, "a");
assertTrue(Arrays.equals(new String[]{"a"}, newArray));
assertTrue(Arrays.equals(new Object[]{"a"}, newArray));
assertEquals(String.class, newArray.getClass().getComponentType());
http://git-wip-us.apache.org/repos/asf/commons-lang/blob/89cbfa54/src/test/java/org/apache/commons/lang3/ArrayUtilsInsertTest.java
----------------------------------------------------------------------
diff --git a/src/test/java/org/apache/commons/lang3/ArrayUtilsInsertTest.java b/src/test/java/org/apache/commons/lang3/ArrayUtilsInsertTest.java
index 689e79d..134982c 100644
--- a/src/test/java/org/apache/commons/lang3/ArrayUtilsInsertTest.java
+++ b/src/test/java/org/apache/commons/lang3/ArrayUtilsInsertTest.java
@@ -31,8 +31,8 @@ public class ArrayUtilsInsertTest {
@Test
public void testInsertBooleans() {
- final boolean[] array = {true,false,true};
- final boolean[] values = {false,true,false};
+ final boolean[] array = {true, false, true};
+ final boolean[] values = {false, true, false};
final boolean[] result = ArrayUtils.insert(42, array, null);
assertArrayEquals(array, result);
@@ -45,19 +45,19 @@ public class ArrayUtilsInsertTest {
assertThrows(IndexOutOfBoundsException.class, () -> ArrayUtils.insert(-1, array, array));
assertThrows(IndexOutOfBoundsException.class, () -> ArrayUtils.insert(array.length + 1, array, array));
- assertArrayEquals(new boolean[]{false,true,false,true}, ArrayUtils.insert(0, array, false));
- assertArrayEquals(new boolean[]{true,false,false,true}, ArrayUtils.insert(1, array, false));
- assertArrayEquals(new boolean[]{true,false,true,false}, ArrayUtils.insert(array.length, array, false));
- assertArrayEquals(new boolean[]{false,true,false,true,false,true}, ArrayUtils.insert(0, array, values));
- assertArrayEquals(new boolean[]{true,false,true,false,false,true}, ArrayUtils.insert(1, array, values));
- assertArrayEquals(new boolean[]{true,false,true,false,true,false}, ArrayUtils.insert(array.length, array, values));
+ assertArrayEquals(new boolean[]{false, true, false, true}, ArrayUtils.insert(0, array, false));
+ assertArrayEquals(new boolean[]{true, false, false, true}, ArrayUtils.insert(1, array, false));
+ assertArrayEquals(new boolean[]{true, false, true, false}, ArrayUtils.insert(array.length, array, false));
+ assertArrayEquals(new boolean[]{false, true, false, true, false, true}, ArrayUtils.insert(0, array, values));
+ assertArrayEquals(new boolean[]{true, false, true, false, false, true}, ArrayUtils.insert(1, array, values));
+ assertArrayEquals(new boolean[]{true, false, true, false, true, false}, ArrayUtils.insert(array.length, array, values));
}
@Test
public void testInsertBytes() {
- final byte[] array = {1,2,3};
- final byte[] values = {4,5,6};
+ final byte[] array = {1, 2, 3};
+ final byte[] values = {4, 5, 6};
final byte[] result = ArrayUtils.insert(42, array, null);
assertArrayEquals(array, result);
@@ -70,18 +70,18 @@ public class ArrayUtilsInsertTest {
assertThrows(IndexOutOfBoundsException.class, () -> ArrayUtils.insert(-1, array, array));
assertThrows(IndexOutOfBoundsException.class, () -> ArrayUtils.insert(array.length + 1, array, array));
- assertArrayEquals(new byte[]{0,1,2,3}, ArrayUtils.insert(0, array, (byte) 0));
- assertArrayEquals(new byte[]{1,0,2,3}, ArrayUtils.insert(1, array, (byte) 0));
- assertArrayEquals(new byte[]{1,2,3,0}, ArrayUtils.insert(array.length, array, (byte) 0));
- assertArrayEquals(new byte[]{4,5,6,1,2,3}, ArrayUtils.insert(0, array, values));
- assertArrayEquals(new byte[]{1,4,5,6,2,3}, ArrayUtils.insert(1, array, values));
- assertArrayEquals(new byte[]{1,2,3,4,5,6}, ArrayUtils.insert(array.length, array, values));
+ assertArrayEquals(new byte[]{0, 1, 2, 3}, ArrayUtils.insert(0, array, (byte) 0));
+ assertArrayEquals(new byte[]{1, 0, 2, 3}, ArrayUtils.insert(1, array, (byte) 0));
+ assertArrayEquals(new byte[]{1, 2, 3, 0}, ArrayUtils.insert(array.length, array, (byte) 0));
+ assertArrayEquals(new byte[]{4, 5, 6, 1, 2, 3}, ArrayUtils.insert(0, array, values));
+ assertArrayEquals(new byte[]{1, 4, 5, 6, 2, 3}, ArrayUtils.insert(1, array, values));
+ assertArrayEquals(new byte[]{1, 2, 3, 4, 5, 6}, ArrayUtils.insert(array.length, array, values));
}
@Test
public void testInsertChars() {
- final char[] array = {'a','b','c'};
- final char[] values = {'d','e','f'};
+ final char[] array = {'a', 'b', 'c'};
+ final char[] values = {'d', 'e', 'f'};
final char[] result = ArrayUtils.insert(42, array, null);
assertArrayEquals(array, result);
@@ -94,18 +94,18 @@ public class ArrayUtilsInsertTest {
assertThrows(IndexOutOfBoundsException.class, () -> ArrayUtils.insert(-1, array, array));
assertThrows(IndexOutOfBoundsException.class, () -> ArrayUtils.insert(array.length + 1, array, array));
- assertArrayEquals(new char[]{'z','a','b','c'}, ArrayUtils.insert(0, array, 'z'));
- assertArrayEquals(new char[]{'a','z','b','c'}, ArrayUtils.insert(1, array, 'z'));
- assertArrayEquals(new char[]{'a','b','c','z'}, ArrayUtils.insert(array.length, array, 'z'));
- assertArrayEquals(new char[]{'d','e','f','a','b','c'}, ArrayUtils.insert(0, array, values));
- assertArrayEquals(new char[]{'a','d','e','f','b','c'}, ArrayUtils.insert(1, array, values));
- assertArrayEquals(new char[]{'a','b','c','d','e','f'}, ArrayUtils.insert(array.length, array, values));
+ assertArrayEquals(new char[]{'z', 'a', 'b', 'c'}, ArrayUtils.insert(0, array, 'z'));
+ assertArrayEquals(new char[]{'a', 'z', 'b', 'c'}, ArrayUtils.insert(1, array, 'z'));
+ assertArrayEquals(new char[]{'a', 'b', 'c', 'z'}, ArrayUtils.insert(array.length, array, 'z'));
+ assertArrayEquals(new char[]{'d', 'e', 'f', 'a', 'b', 'c'}, ArrayUtils.insert(0, array, values));
+ assertArrayEquals(new char[]{'a', 'd', 'e', 'f', 'b', 'c'}, ArrayUtils.insert(1, array, values));
+ assertArrayEquals(new char[]{'a', 'b', 'c', 'd', 'e', 'f'}, ArrayUtils.insert(array.length, array, values));
}
@Test
public void testInsertDoubles() {
- final double[] array = {1,2,3};
- final double[] values = {4,5,6};
+ final double[] array = {1, 2, 3};
+ final double[] values = {4, 5, 6};
final double delta = 0.000001;
final double[] result = ArrayUtils.insert(42, array, null);
@@ -119,18 +119,18 @@ public class ArrayUtilsInsertTest {
assertThrows(IndexOutOfBoundsException.class, () -> ArrayUtils.insert(-1, array, array));
assertThrows(IndexOutOfBoundsException.class, () -> ArrayUtils.insert(array.length + 1, array, array));
- assertArrayEquals(new double[]{0,1,2,3}, ArrayUtils.insert(0, array, 0), delta);
- assertArrayEquals(new double[]{1,0,2,3}, ArrayUtils.insert(1, array, 0), delta);
- assertArrayEquals(new double[]{1,2,3,0}, ArrayUtils.insert(array.length, array, 0), delta);
- assertArrayEquals(new double[]{4,5,6,1,2,3}, ArrayUtils.insert(0, array, values), delta);
- assertArrayEquals(new double[]{1,4,5,6,2,3}, ArrayUtils.insert(1, array, values), delta);
- assertArrayEquals(new double[]{1,2,3,4,5,6}, ArrayUtils.insert(array.length, array, values), delta);
+ assertArrayEquals(new double[]{0, 1, 2, 3}, ArrayUtils.insert(0, array, 0), delta);
+ assertArrayEquals(new double[]{1, 0, 2, 3}, ArrayUtils.insert(1, array, 0), delta);
+ assertArrayEquals(new double[]{1, 2, 3, 0}, ArrayUtils.insert(array.length, array, 0), delta);
+ assertArrayEquals(new double[]{4, 5, 6, 1, 2, 3}, ArrayUtils.insert(0, array, values), delta);
+ assertArrayEquals(new double[]{1, 4, 5, 6, 2, 3}, ArrayUtils.insert(1, array, values), delta);
+ assertArrayEquals(new double[]{1, 2, 3, 4, 5, 6}, ArrayUtils.insert(array.length, array, values), delta);
}
@Test
public void testInsertFloats() {
- final float[] array = {1,2,3};
- final float[] values = {4,5,6};
+ final float[] array = {1, 2, 3};
+ final float[] values = {4, 5, 6};
final float delta = 0.000001f;
final float[] result = ArrayUtils.insert(42, array, null);
@@ -144,18 +144,18 @@ public class ArrayUtilsInsertTest {
assertThrows(IndexOutOfBoundsException.class, () -> ArrayUtils.insert(-1, array, array));
assertThrows(IndexOutOfBoundsException.class, () -> ArrayUtils.insert(array.length + 1, array, array));
- assertArrayEquals(new float[]{0,1,2,3}, ArrayUtils.insert(0, array, 0), delta);
- assertArrayEquals(new float[]{1,0,2,3}, ArrayUtils.insert(1, array, 0), delta);
- assertArrayEquals(new float[]{1,2,3,0}, ArrayUtils.insert(array.length, array, 0), delta);
- assertArrayEquals(new float[]{4,5,6,1,2,3}, ArrayUtils.insert(0, array, values), delta);
- assertArrayEquals(new float[]{1,4,5,6,2,3}, ArrayUtils.insert(1, array, values), delta);
- assertArrayEquals(new float[]{1,2,3,4,5,6}, ArrayUtils.insert(array.length, array, values), delta);
+ assertArrayEquals(new float[]{0, 1, 2, 3}, ArrayUtils.insert(0, array, 0), delta);
+ assertArrayEquals(new float[]{1, 0, 2, 3}, ArrayUtils.insert(1, array, 0), delta);
+ assertArrayEquals(new float[]{1, 2, 3, 0}, ArrayUtils.insert(array.length, array, 0), delta);
+ assertArrayEquals(new float[]{4, 5, 6, 1, 2, 3}, ArrayUtils.insert(0, array, values), delta);
+ assertArrayEquals(new float[]{1, 4, 5, 6, 2, 3}, ArrayUtils.insert(1, array, values), delta);
+ assertArrayEquals(new float[]{1, 2, 3, 4, 5, 6}, ArrayUtils.insert(array.length, array, values), delta);
}
@Test
public void testInsertInts() {
- final int[] array = {1,2,3};
- final int[] values = {4,5,6};
+ final int[] array = {1, 2, 3};
+ final int[] values = {4, 5, 6};
final int[] result = ArrayUtils.insert(42, array, null);
assertArrayEquals(array, result);
@@ -168,19 +168,19 @@ public class ArrayUtilsInsertTest {
assertThrows(IndexOutOfBoundsException.class, () -> ArrayUtils.insert(-1, array, array));
assertThrows(IndexOutOfBoundsException.class, () -> ArrayUtils.insert(array.length + 1, array, array));
- assertArrayEquals(new int[]{0,1,2,3}, ArrayUtils.insert(0, array, 0));
- assertArrayEquals(new int[]{1,0,2,3}, ArrayUtils.insert(1, array, 0));
- assertArrayEquals(new int[]{1,2,3,0}, ArrayUtils.insert(array.length, array, 0));
- assertArrayEquals(new int[]{4,5,6,1,2,3}, ArrayUtils.insert(0, array, values));
- assertArrayEquals(new int[]{1,4,5,6,2,3}, ArrayUtils.insert(1, array, values));
- assertArrayEquals(new int[]{1,2,3,4,5,6}, ArrayUtils.insert(array.length, array, values));
+ assertArrayEquals(new int[]{0, 1, 2, 3}, ArrayUtils.insert(0, array, 0));
+ assertArrayEquals(new int[]{1, 0, 2, 3}, ArrayUtils.insert(1, array, 0));
+ assertArrayEquals(new int[]{1, 2, 3, 0}, ArrayUtils.insert(array.length, array, 0));
+ assertArrayEquals(new int[]{4, 5, 6, 1, 2, 3}, ArrayUtils.insert(0, array, values));
+ assertArrayEquals(new int[]{1, 4, 5, 6, 2, 3}, ArrayUtils.insert(1, array, values));
+ assertArrayEquals(new int[]{1, 2, 3, 4, 5, 6}, ArrayUtils.insert(array.length, array, values));
}
@Test
public void testInsertLongs() {
- final long[] array = {1,2,3};
- final long[] values = {4,5,6};
+ final long[] array = {1, 2, 3};
+ final long[] values = {4, 5, 6};
final long[] result = ArrayUtils.insert(42, array, null);
assertArrayEquals(array, result);
@@ -193,19 +193,19 @@ public class ArrayUtilsInsertTest {
assertThrows(IndexOutOfBoundsException.class, () -> ArrayUtils.insert(-1, array, array));
assertThrows(IndexOutOfBoundsException.class, () -> ArrayUtils.insert(array.length + 1, array, array));
- assertArrayEquals(new long[]{0,1,2,3}, ArrayUtils.insert(0, array, 0));
- assertArrayEquals(new long[]{1,0,2,3}, ArrayUtils.insert(1, array, 0));
- assertArrayEquals(new long[]{1,2,3,0}, ArrayUtils.insert(array.length, array, 0));
- assertArrayEquals(new long[]{4,5,6,1,2,3}, ArrayUtils.insert(0, array, values));
- assertArrayEquals(new long[]{1,4,5,6,2,3}, ArrayUtils.insert(1, array, values));
- assertArrayEquals(new long[]{1,2,3,4,5,6}, ArrayUtils.insert(array.length, array, values));
+ assertArrayEquals(new long[]{0, 1, 2, 3}, ArrayUtils.insert(0, array, 0));
+ assertArrayEquals(new long[]{1, 0, 2, 3}, ArrayUtils.insert(1, array, 0));
+ assertArrayEquals(new long[]{1, 2, 3, 0}, ArrayUtils.insert(array.length, array, 0));
+ assertArrayEquals(new long[]{4, 5, 6, 1, 2, 3}, ArrayUtils.insert(0, array, values));
+ assertArrayEquals(new long[]{1, 4, 5, 6, 2, 3}, ArrayUtils.insert(1, array, values));
+ assertArrayEquals(new long[]{1, 2, 3, 4, 5, 6}, ArrayUtils.insert(array.length, array, values));
}
@Test
public void testInsertShorts() {
- final short[] array = {1,2,3};
- final short[] values = {4,5,6};
+ final short[] array = {1, 2, 3};
+ final short[] values = {4, 5, 6};
final short[] result = ArrayUtils.insert(42, array, null);
assertArrayEquals(array, result);
@@ -218,19 +218,19 @@ public class ArrayUtilsInsertTest {
assertThrows(IndexOutOfBoundsException.class, () -> ArrayUtils.insert(-1, array, array));
assertThrows(IndexOutOfBoundsException.class, () -> ArrayUtils.insert(array.length + 1, array, array));
- assertArrayEquals(new short[]{0,1,2,3}, ArrayUtils.insert(0, array, (short) 0));
- assertArrayEquals(new short[]{1,0,2,3}, ArrayUtils.insert(1, array, (short) 0));
- assertArrayEquals(new short[]{1,2,3,0}, ArrayUtils.insert(array.length, array, (short) 0));
- assertArrayEquals(new short[]{4,5,6,1,2,3}, ArrayUtils.insert(0, array, values));
- assertArrayEquals(new short[]{1,4,5,6,2,3}, ArrayUtils.insert(1, array, values));
- assertArrayEquals(new short[]{1,2,3,4,5,6}, ArrayUtils.insert(array.length, array, values));
+ assertArrayEquals(new short[]{0, 1, 2, 3}, ArrayUtils.insert(0, array, (short) 0));
+ assertArrayEquals(new short[]{1, 0, 2, 3}, ArrayUtils.insert(1, array, (short) 0));
+ assertArrayEquals(new short[]{1, 2, 3, 0}, ArrayUtils.insert(array.length, array, (short) 0));
+ assertArrayEquals(new short[]{4, 5, 6, 1, 2, 3}, ArrayUtils.insert(0, array, values));
+ assertArrayEquals(new short[]{1, 4, 5, 6, 2, 3}, ArrayUtils.insert(1, array, values));
+ assertArrayEquals(new short[]{1, 2, 3, 4, 5, 6}, ArrayUtils.insert(array.length, array, values));
}
@Test
public void testInsertGenericArray() {
- final String[] array = {"a","b","c"};
- final String[] values = {"d","e","f"};
+ final String[] array = {"a", "b", "c"};
+ final String[] values = {"d", "e", "f"};
final String[] result = ArrayUtils.insert(42, array, (String[]) null);
assertArrayEquals(array, result);
@@ -243,11 +243,11 @@ public class ArrayUtilsInsertTest {
assertThrows(IndexOutOfBoundsException.class, () -> ArrayUtils.insert(-1, array, array));
assertThrows(IndexOutOfBoundsException.class, () -> ArrayUtils.insert(array.length + 1, array, array));
- assertArrayEquals(new String[]{"z","a","b","c"}, ArrayUtils.insert(0, array, "z"));
- assertArrayEquals(new String[]{"a","z","b","c"}, ArrayUtils.insert(1, array, "z"));
- assertArrayEquals(new String[]{"a","b","c","z"}, ArrayUtils.insert(array.length, array, "z"));
- assertArrayEquals(new String[]{"d","e","f","a","b","c"}, ArrayUtils.insert(0, array, values));
- assertArrayEquals(new String[]{"a","d","e","f","b","c"}, ArrayUtils.insert(1, array, values));
- assertArrayEquals(new String[]{"a","b","c","d","e","f"}, ArrayUtils.insert(array.length, array, values));
+ assertArrayEquals(new String[]{"z", "a", "b", "c"}, ArrayUtils.insert(0, array, "z"));
+ assertArrayEquals(new String[]{"a", "z", "b", "c"}, ArrayUtils.insert(1, array, "z"));
+ assertArrayEquals(new String[]{"a", "b", "c", "z"}, ArrayUtils.insert(array.length, array, "z"));
+ assertArrayEquals(new String[]{"d", "e", "f", "a", "b", "c"}, ArrayUtils.insert(0, array, values));
+ assertArrayEquals(new String[]{"a", "d", "e", "f", "b", "c"}, ArrayUtils.insert(1, array, values));
+ assertArrayEquals(new String[]{"a", "b", "c", "d", "e", "f"}, ArrayUtils.insert(array.length, array, values));
}
}
http://git-wip-us.apache.org/repos/asf/commons-lang/blob/89cbfa54/src/test/java/org/apache/commons/lang3/ArrayUtilsRemoveTest.java
----------------------------------------------------------------------
diff --git a/src/test/java/org/apache/commons/lang3/ArrayUtilsRemoveTest.java b/src/test/java/org/apache/commons/lang3/ArrayUtilsRemoveTest.java
index d8ce365..9b5eba0 100644
--- a/src/test/java/org/apache/commons/lang3/ArrayUtilsRemoveTest.java
+++ b/src/test/java/org/apache/commons/lang3/ArrayUtilsRemoveTest.java
@@ -52,8 +52,8 @@ public class ArrayUtilsRemoveTest {
}
@Test
- public void testRemoveNumberArray(){
- final Number[] inarray = {Integer.valueOf(1),Long.valueOf(2),Byte.valueOf((byte) 3)};
+ public void testRemoveNumberArray() {
+ final Number[] inarray = {Integer.valueOf(1), Long.valueOf(2), Byte.valueOf((byte) 3)};
assertEquals(3, inarray.length);
Number[] outarray;
outarray = ArrayUtils.remove(inarray, 1);
http://git-wip-us.apache.org/repos/asf/commons-lang/blob/89cbfa54/src/test/java/org/apache/commons/lang3/ArrayUtilsTest.java
----------------------------------------------------------------------
diff --git a/src/test/java/org/apache/commons/lang3/ArrayUtilsTest.java b/src/test/java/org/apache/commons/lang3/ArrayUtilsTest.java
index c504409..7d83ed0 100644
--- a/src/test/java/org/apache/commons/lang3/ArrayUtilsTest.java
+++ b/src/test/java/org/apache/commons/lang3/ArrayUtilsTest.java
@@ -942,9 +942,9 @@ public class ArrayUtilsTest {
public void testSubarrChar() {
final char[] nullArray = null;
final char[] array = {'a', 'b', 'c', 'd', 'e', 'f'};
- final char[] leftSubarray = {'a', 'b', 'c', 'd',};
- final char[] midSubarray = {'b', 'c', 'd', 'e',};
- final char[] rightSubarray = {'c', 'd', 'e', 'f',};
+ final char[] leftSubarray = {'a', 'b', 'c', 'd'};
+ final char[] midSubarray = {'b', 'c', 'd', 'e'};
+ final char[] rightSubarray = {'c', 'd', 'e', 'f'};
assertTrue(ArrayUtils.isEquals(leftSubarray, ArrayUtils.subarray(array, 0, 4)), "0 start, mid end");
assertTrue(ArrayUtils.isEquals(array, ArrayUtils.subarray(array, 0, array.length)), "0 start, length end");
@@ -1022,8 +1022,8 @@ public class ArrayUtilsTest {
public void testSubarrayDouble() {
final double[] nullArray = null;
final double[] array = {10.123, 11.234, 12.345, 13.456, 14.567, 15.678};
- final double[] leftSubarray = {10.123, 11.234, 12.345, 13.456,};
- final double[] midSubarray = {11.234, 12.345, 13.456, 14.567,};
+ final double[] leftSubarray = {10.123, 11.234, 12.345, 13.456};
+ final double[] midSubarray = {11.234, 12.345, 13.456, 14.567};
final double[] rightSubarray = {12.345, 13.456, 14.567, 15.678};
assertTrue(ArrayUtils.isEquals(leftSubarray, ArrayUtils.subarray(array, 0, 4)), "0 start, mid end");
@@ -1079,7 +1079,7 @@ public class ArrayUtilsTest {
assertEquals(ArrayUtils.EMPTY_FLOAT_ARRAY, ArrayUtils.subarray(array, 3, 3), "start == end");
assertTrue(ArrayUtils.isEquals(leftSubarray, ArrayUtils.subarray(array, -2, 4)),
"start undershoot, normal end");
- assertEquals(ArrayUtils.EMPTY_FLOAT_ARRAY, ArrayUtils.subarray(array, 33, 4),"start overshoot, any end");
+ assertEquals(ArrayUtils.EMPTY_FLOAT_ARRAY, ArrayUtils.subarray(array, 33, 4), "start overshoot, any end");
assertTrue(ArrayUtils.isEquals(rightSubarray, ArrayUtils.subarray(array, 2, 33)),
"normal start, end overshoot");
assertTrue(ArrayUtils.isEquals(array, ArrayUtils.subarray(array, -2, 12)), "start undershoot, end overshoot");
@@ -4821,7 +4821,7 @@ public class ArrayUtilsTest {
}
@Test
- public void testIsArrayIndexValid(){
+ public void testIsArrayIndexValid() {
assertFalse(ArrayUtils.isArrayIndexValid(null, 0));
String[] array = new String[1];
http://git-wip-us.apache.org/repos/asf/commons-lang/blob/89cbfa54/src/test/java/org/apache/commons/lang3/BooleanUtilsTest.java
----------------------------------------------------------------------
diff --git a/src/test/java/org/apache/commons/lang3/BooleanUtilsTest.java b/src/test/java/org/apache/commons/lang3/BooleanUtilsTest.java
index dddb416..c25c22e 100644
--- a/src/test/java/org/apache/commons/lang3/BooleanUtilsTest.java
+++ b/src/test/java/org/apache/commons/lang3/BooleanUtilsTest.java
@@ -1007,7 +1007,7 @@ public class BooleanUtilsTest {
}
@Test
- public void testCompare(){
+ public void testCompare() {
assertTrue(BooleanUtils.compare(true, false) > 0);
assertEquals(0, BooleanUtils.compare(true, true));
assertEquals(0, BooleanUtils.compare(false, false));
http://git-wip-us.apache.org/repos/asf/commons-lang/blob/89cbfa54/src/test/java/org/apache/commons/lang3/CharSequenceUtilsTest.java
----------------------------------------------------------------------
diff --git a/src/test/java/org/apache/commons/lang3/CharSequenceUtilsTest.java b/src/test/java/org/apache/commons/lang3/CharSequenceUtilsTest.java
index abaf346..e7dd3b4 100644
--- a/src/test/java/org/apache/commons/lang3/CharSequenceUtilsTest.java
+++ b/src/test/java/org/apache/commons/lang3/CharSequenceUtilsTest.java
@@ -84,7 +84,7 @@ public class CharSequenceUtilsTest {
final boolean expected;
final Class<? extends Throwable> throwable;
TestData(final String source, final boolean ignoreCase, final int toffset,
- final String other, final int ooffset, final int len, final boolean expected){
+ final String other, final int ooffset, final int len, final boolean expected) {
this.source = source;
this.ignoreCase = ignoreCase;
this.toffset = toffset;
@@ -95,7 +95,7 @@ public class CharSequenceUtilsTest {
this.throwable = null;
}
TestData(final String source, final boolean ignoreCase, final int toffset,
- final String other, final int ooffset, final int len, final Class<? extends Throwable> throwable){
+ final String other, final int ooffset, final int len, final Class<? extends Throwable> throwable) {
this.source = source;
this.ignoreCase = ignoreCase;
this.toffset = toffset;
@@ -106,7 +106,7 @@ public class CharSequenceUtilsTest {
this.throwable = throwable;
}
@Override
- public String toString(){
+ public String toString() {
final StringBuilder sb = new StringBuilder();
sb.append(source).append("[").append(toffset).append("]");
sb.append(ignoreCase? " caseblind ":" samecase ");
@@ -134,8 +134,8 @@ public class CharSequenceUtilsTest {
new TestData("Abc", false, 0, "abc", 0, 3, false),
new TestData("Abc", true, 1, "abc", 1, 2, true),
new TestData("Abc", false, 1, "abc", 1, 2, true),
- new TestData("Abcd",true, 1, "abcD",1, 2, true),
- new TestData("Abcd",false, 1, "abcD",1, 2, true),
+ new TestData("Abcd", true, 1, "abcD", 1, 2, true),
+ new TestData("Abcd", false, 1, "abcD", 1, 2, true),
};
private abstract static class RunTest {
http://git-wip-us.apache.org/repos/asf/commons-lang/blob/89cbfa54/src/test/java/org/apache/commons/lang3/CharSetTest.java
----------------------------------------------------------------------
diff --git a/src/test/java/org/apache/commons/lang3/CharSetTest.java b/src/test/java/org/apache/commons/lang3/CharSetTest.java
index e0f318d..a3c25c6 100644
--- a/src/test/java/org/apache/commons/lang3/CharSetTest.java
+++ b/src/test/java/org/apache/commons/lang3/CharSetTest.java
@@ -325,7 +325,7 @@ public class CharSetTest {
set = CharSet.getInstance("^-b");
array = set.getCharRanges();
- assertTrue(ArrayUtils.contains(array, CharRange.isIn('^','b'))); // "^-b"
+ assertTrue(ArrayUtils.contains(array, CharRange.isIn('^', 'b'))); // "^-b"
assertTrue(set.contains('b'));
assertTrue(set.contains('_')); // between ^ and a
assertFalse(set.contains('A'));
@@ -333,7 +333,7 @@ public class CharSetTest {
set = CharSet.getInstance("b-^");
array = set.getCharRanges();
- assertTrue(ArrayUtils.contains(array, CharRange.isIn('^','b'))); // "b-^"
+ assertTrue(ArrayUtils.contains(array, CharRange.isIn('^', 'b'))); // "b-^"
assertTrue(set.contains('b'));
assertTrue(set.contains('^'));
assertTrue(set.contains('a')); // between ^ and b
http://git-wip-us.apache.org/repos/asf/commons-lang/blob/89cbfa54/src/test/java/org/apache/commons/lang3/ClassUtilsTest.java
----------------------------------------------------------------------
diff --git a/src/test/java/org/apache/commons/lang3/ClassUtilsTest.java b/src/test/java/org/apache/commons/lang3/ClassUtilsTest.java
index 59c9dad..0f4c1ce 100644
--- a/src/test/java/org/apache/commons/lang3/ClassUtilsTest.java
+++ b/src/test/java/org/apache/commons/lang3/ClassUtilsTest.java
@@ -158,7 +158,7 @@ public class ClassUtilsTest {
// -------------------------------------------------------------------------
@Test
public void test_getAbbreviatedName_Class() {
- assertEquals("", ClassUtils.getAbbreviatedName((Class<?>)null, 1));
+ assertEquals("", ClassUtils.getAbbreviatedName((Class<?>) null, 1));
assertEquals("j.l.String", ClassUtils.getAbbreviatedName(String.class, 1));
assertEquals("j.l.String", ClassUtils.getAbbreviatedName(String.class, 5));
assertEquals("j.lang.String", ClassUtils.getAbbreviatedName(String.class, 13));
@@ -1295,8 +1295,8 @@ public class ClassUtilsTest {
assertNull(ClassUtils.primitivesToWrappers((Class<?>[]) null), "null -> null"); // equivalent cast to avoid warning
// Other possible casts for null
assertTrue(Arrays.equals(ArrayUtils.EMPTY_CLASS_ARRAY, ClassUtils.primitivesToWrappers()), "empty -> empty");
- final Class<?>[] castNull = ClassUtils.primitivesToWrappers((Class<?>)null); // == new Class<?>[]{null}
- assertTrue(Arrays.equals(new Class<?>[]{null}, castNull), "(Class<?>)null -> [null]");
+ final Class<?>[] castNull = ClassUtils.primitivesToWrappers((Class<?>) null); // == new Class<?>[]{null}
+ assertTrue(Arrays.equals(new Class<?>[]{null}, castNull), "(Class<?>) null -> [null]");
// test empty array is returned unchanged
assertArrayEquals(ArrayUtils.EMPTY_CLASS_ARRAY, ClassUtils.primitivesToWrappers(ArrayUtils.EMPTY_CLASS_ARRAY),
"empty -> empty");
@@ -1366,7 +1366,7 @@ public class ClassUtilsTest {
// Additional varargs tests
assertTrue(Arrays.equals(ArrayUtils.EMPTY_CLASS_ARRAY, ClassUtils.toClass()), "empty -> empty");
final Class<?>[] castNull = ClassUtils.toClass((Object) null); // == new Object[]{null}
- assertTrue(Arrays.equals(new Object[]{null}, castNull), "(Object)null -> [null]");
+ assertTrue(Arrays.equals(new Object[]{null}, castNull), "(Object) null -> [null]");
assertSame(ArrayUtils.EMPTY_CLASS_ARRAY, ClassUtils.toClass(ArrayUtils.EMPTY_OBJECT_ARRAY));
@@ -1415,8 +1415,8 @@ public class ClassUtilsTest {
assertNull(ClassUtils.wrappersToPrimitives((Class<?>[]) null), "Wrong result for null input"); // equivalent cast
// Other possible casts for null
assertTrue(Arrays.equals(ArrayUtils.EMPTY_CLASS_ARRAY, ClassUtils.wrappersToPrimitives()), "empty -> empty");
- final Class<?>[] castNull = ClassUtils.wrappersToPrimitives((Class<?>)null); // == new Class<?>[]{null}
- assertTrue(Arrays.equals(new Class<?>[]{null}, castNull), "(Class<?>)null -> [null]");
+ final Class<?>[] castNull = ClassUtils.wrappersToPrimitives((Class<?>) null); // == new Class<?>[]{null}
+ assertTrue(Arrays.equals(new Class<?>[]{null}, castNull), "(Class<?>) null -> [null]");
}
@Test