[GitHub] [tvm] vincentccc commented on a diff in pull request #15133: [XGBoost,MetaSchedule] Support xgb set tree method

["vincentccc (via GitHub)" <gi...@apache.org>]

vincentccc commented on code in PR #15133:
URL: https://github.com/apache/tvm/pull/15133#discussion_r1271254817


##########
python/tvm/meta_schedule/tir_integration.py:
##########
@@ -58,6 +58,7 @@ def tune_tir(  # pylint: disable=too-many-locals
     seed: Optional[int] = None,
     module_equality: str = "structural",
     special_space: Optional[Mapping[str, SpaceGenerator.SpaceGeneratorType]] = None,
+    **kwargs,

Review Comment:
   Hi zhou, thanks for your time to review, there are some other cost models and set_tree_method only work for xgb model，so I think it is not a proper way to specialize the parameter here. And there may be some other parameters need to be set in other cases, use **kwargs may be more flexible.



##########
python/tvm/meta_schedule/tir_integration.py:
##########
@@ -58,6 +58,7 @@ def tune_tir(  # pylint: disable=too-many-locals
     seed: Optional[int] = None,
     module_equality: str = "structural",
     special_space: Optional[Mapping[str, SpaceGenerator.SpaceGeneratorType]] = None,
+    **kwargs,

Review Comment:
   Hi zhou, thanks for your time to review, there are some other cost models and set_tree_method only work for xgb model，so I think it is not a proper way to specialize the parameter here. And there may be some other parameters need to be set in other cases, use **kwargs may be more flexible.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org