[GitHub] [beam] ihji commented on a diff in pull request #23945: Updates Multi-language Java examples documentation

[GitBox <gi...@apache.org>]

ihji commented on code in PR #23945:
URL: https://github.com/apache/beam/pull/23945#discussion_r1012112887


##########
examples/multi-language/README.md:
##########
@@ -126,9 +126,25 @@ gsutil cat gs://$GCP_BUCKET/multi-language-beam/output*
 
 #### Instructions for running the Java pipeline at HEAD (Beam 2.41.0 and 2.42.0).
 
+* Activate a new virtual environment following
+[these instructions](https://beam.apache.org/get-started/quickstart-py/#create-and-activate-a-virtual-environment).
+
+* 2. Install Apache Beam package with gcp support and the `sklearn` package.
+
+```
+pip install apache-beam[gcp]
+pip install sklearn
+```
+
+* Startup the expansion service
+
+```
+python -m apache_beam.runners.portability.expansion_service_main -p <PORT> --fully_qualified_name_glob "*"

Review Comment:
   Do we need --pickle_library=cloudpickle ?



##########
website/www/site/content/en/documentation/sdks/java-multi-language-pipelines.md:
##########
@@ -243,9 +243,9 @@ pip install apache-beam[gcp,dataframe]
 
 4. Run the following command
 
-   ```
-   python -m apache_beam.runners.portability.expansion_service_main -p <PORT> --fully_qualified_name_glob "*"
-   ```
+```
+python -m apache_beam.runners.portability.expansion_service_main -p <PORT> --fully_qualified_name_glob "*"

Review Comment:
   ditto



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org