[jira] [Commented] (MINIFICPP-364) Resolve issues created by merge of MINIFICPP-251

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/MINIFICPP-364?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16319472#comment-16319472 ] 

ASF GitHub Bot commented on MINIFICPP-364:
------------------------------------------

GitHub user phrocker opened a pull request:

    https://github.com/apache/nifi-minifi-cpp/pull/235

    MINIFICPP-364: resolve issues with test extension. This will cause is…

    …sues with bootstrapping. Also resolve linkage between civet and curl extensions
    
    Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
    
    In order to streamline the review of the contribution we ask you
    to ensure the following steps have been taken:
    
    ### For all changes:
    - [ ] Is there a JIRA ticket associated with this PR? Is it referenced
         in the commit message?
    
    - [ ] Does your PR title start with MINIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
    
    - [ ] Has your PR been rebased against the latest commit within the target branch (typically master)?
    
    - [ ] Is your initial contribution a single, squashed commit?
    
    ### For code changes:
    - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
    - [ ] If applicable, have you updated the LICENSE file?
    - [ ] If applicable, have you updated the NOTICE file?
    
    ### For documentation related changes:
    - [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
    
    ### Note:
    Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/phrocker/nifi-minifi-cpp MINIFICPP-364

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/nifi-minifi-cpp/pull/235.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #235
    
----
commit d39362074d29ffdbc2806421a32ea0eee5e8ec85
Author: Marc Parisi <ph...@...>
Date:   2018-01-10T00:48:22Z

    MINIFICPP-364: resolve issues with test extension. This will cause issues with bootstrapping. Also resolve linkage between civet and curl extensions

----


> Resolve issues created by merge of MINIFICPP-251
> ------------------------------------------------
>
>                 Key: MINIFICPP-364
>                 URL: https://issues.apache.org/jira/browse/MINIFICPP-364
>             Project: NiFi MiNiFi C++
>          Issue Type: Sub-task
>            Reporter: marco polo
>            Assignee: marco polo
>            Priority: Blocker
>             Fix For: 0.4.0
>
>
> Fixing some minor test issues and build dependency issues that can crop up. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)