You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@usergrid.apache.org by sn...@apache.org on 2014/01/30 03:20:39 UTC
git commit: Added comments for review
Updated Branches:
refs/heads/two-dot-o 2c6e7e486 -> e38dda9d9
Added comments for review
Project: http://git-wip-us.apache.org/repos/asf/incubator-usergrid/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-usergrid/commit/e38dda9d
Tree: http://git-wip-us.apache.org/repos/asf/incubator-usergrid/tree/e38dda9d
Diff: http://git-wip-us.apache.org/repos/asf/incubator-usergrid/diff/e38dda9d
Branch: refs/heads/two-dot-o
Commit: e38dda9d9965b018aad6563459e99545c0e73843
Parents: 2c6e7e4
Author: Todd Nine <tn...@apigee.com>
Authored: Wed Jan 29 18:34:55 2014 -0700
Committer: Todd Nine <tn...@apigee.com>
Committed: Wed Jan 29 18:34:55 2014 -0700
----------------------------------------------------------------------
.../collection/mvcc/stage/write/WriteUniqueVerify.java | 6 ++++++
1 file changed, 6 insertions(+)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/incubator-usergrid/blob/e38dda9d/stack/corepersistence/collection/src/main/java/org/apache/usergrid/persistence/collection/mvcc/stage/write/WriteUniqueVerify.java
----------------------------------------------------------------------
diff --git a/stack/corepersistence/collection/src/main/java/org/apache/usergrid/persistence/collection/mvcc/stage/write/WriteUniqueVerify.java b/stack/corepersistence/collection/src/main/java/org/apache/usergrid/persistence/collection/mvcc/stage/write/WriteUniqueVerify.java
index 5ddd519..818a01d 100644
--- a/stack/corepersistence/collection/src/main/java/org/apache/usergrid/persistence/collection/mvcc/stage/write/WriteUniqueVerify.java
+++ b/stack/corepersistence/collection/src/main/java/org/apache/usergrid/persistence/collection/mvcc/stage/write/WriteUniqueVerify.java
@@ -51,6 +51,7 @@ public class WriteUniqueVerify
private final UniqueValueSerializationStrategy uniqueValueStrat;
+ //TODO Dave, we don't want to use our own thread pool. Use the Concurrent class to create new observables
private final ExecutorService threadPool;
private final int MAX_THREAD_COUNT;
@@ -82,6 +83,11 @@ public class WriteUniqueVerify
final Entity entity = ioevent.getEvent().getEntity().get();
// use simple thread pool to verify fields in parallel
+
+ //TODO We don't want to use custom thread pools and futures here.
+ // We want to use concurrent to fork all validations this way they're wrapped by timeouts and
+ // Hystrix thread pools for JMX operations. See the WriteCommand in the EntityCollectionManagerImpl
+ // I think it still needs added to the Concurrent utility class
final List<Future<FieldUniquenessResult>> results =
new ArrayList<Future<FieldUniquenessResult>>();