You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@buildstream.apache.org by GitBox <gi...@apache.org> on 2022/11/26 15:40:31 UTC
[GitHub] [buildstream] eprk1 opened a new issue, #1791: BST to warn if there is a conflicting config
eprk1 opened a new issue, #1791:
URL: https://github.com/apache/buildstream/issues/1791
We have two project.confs, each in, say repo_1 and repo_2
Now, if repo_2 references repo_1 bst elements via a junction, then the plugins definition used while bst build repo_1 elements in repo_2 will be that of repo_1's instead of repo_2's even the build happens in repo_2. This is not obvious so it would be very helpful for bst to inform the users otherwise lots of time will be spent experimenting and investigating where to update plugin info.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@buildstream.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [buildstream] eprk1 commented on issue #1791: [bst-1] BST to warn if there is a conflicting config
Posted by GitBox <gi...@apache.org>.
eprk1 commented on issue #1791:
URL: https://github.com/apache/buildstream/issues/1791#issuecomment-1329523365
>The plugins which a project.conf declares as "local" (loaded from a project directory), cannot be accessed by any other project (in bst1), they cannot be override plugins in a subproject or be accessed from another junctioning project.
yes correct but that's not the issue
the issue is that, there is no way for me to consume the plugin "foo" in project B despite having the plugin "foo" listed in project B's project.conf
to elaborate, in project B's project.conf, I am referencing project A's foo via:
plugins:
- origin: pip
package-name: project_A
sources:
foo: 0
but when inside project B's ws,
bst build project_A:element_uses_foo.bst fails
however,
bst build element_uses_foo.bst does work
So, i think the issue is that even though we are building an element which are accessed via a junction, it should be honoring its current project.conf (project B's), not project A's
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@buildstream.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [buildstream] eprk1 commented on issue #1791: [bst-1] BST to warn if there is a conflicting config
Posted by GitBox <gi...@apache.org>.
eprk1 commented on issue #1791:
URL: https://github.com/apache/buildstream/issues/1791#issuecomment-1329530893
To clarify,
in project B,
bst build project_A:element_uses_foo.bst
bst build element_uses_foo.bst
should both use project B's project.conf definition
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@buildstream.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [bst-1] BST to warn if there is a conflicting config [buildstream]
Posted by "nanonyme (via GitHub)" <gi...@apache.org>.
nanonyme commented on issue #1791:
URL: https://github.com/apache/buildstream/issues/1791#issuecomment-1868368131
> So, i think the issue is that even though we are building an element which are accessed via a junction, it should be honoring its current project.conf (project B's), not project A's
This sounds like invalid assumption. When you build junctioned elements, they are built with declarations belonging to junctioned project. If you want to change these, then you need to patch through junction.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@buildstream.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [buildstream] gtristan commented on issue #1791: [bst-1] BST to warn if there is a conflicting config
Posted by GitBox <gi...@apache.org>.
gtristan commented on issue #1791:
URL: https://github.com/apache/buildstream/issues/1791#issuecomment-1328952188
Hi,
The plugins which a project.conf declares as "local" (loaded from a project directory), cannot be accessed by any other project (in bst1), they cannot be override plugins in a subproject or be accessed from another junctioning project.
Plugin names are also not forced to be unique across loaded projects.
In BuildStream 2, the project summary printed in advance of the build is very meticulous about describing the origins of each plugin which was loaded as a consequence of loading the build graph, this was more necessary since with BuildStream 2 you can use/load plugins from subprojects across junctions.
Do I understand correctly that:
* You have a plugin named "foo" in project A
* You have another plugin also named "foo" in project B which junctions project A
* When building elements in project B, different "foo" plugins will be used in project A and project B, and this is confusing
Would more elaborate information about the loaded projects and what plugins are being loaded in each project (similar to how we log in bst2) be helpful here ?
Here is an example of the loaded project information at the beginning of the build log in bst2 for reference: https://docs.buildstream.build/master/junctions/junction-elements.html#building-and-running
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@buildstream.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org