[GitHub] [tvm] janetsc commented on a diff in pull request #12918: [Hexagon] [runtime] Add user DMA to device API resource management

[GitBox <gi...@apache.org>]

janetsc commented on code in PR #12918:
URL: https://github.com/apache/tvm/pull/12918#discussion_r981889520


##########
src/runtime/hexagon/hexagon_device_api.h:
##########
@@ -153,6 +162,8 @@ class HexagonDeviceAPI final : public DeviceAPI {
     return runtime_threads ? runtime_threads.get() : nullptr;
   }
 
+  HexagonUserDMA* UserDMA() { return runtime_dma ? runtime_dma.get() : nullptr; }

Review Comment:
   I thought about that, but then thought std::make_unique would throw or assert.  Let me dig into the behavior.  If it doesn't throw or assert, I'll add checks for all three managers.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org