You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "mbrobbel (via GitHub)" <gi...@apache.org> on 2023/08/02 12:23:45 UTC
[GitHub] [arrow-rs] mbrobbel opened a new pull request, #4630: Move `BufferBuilder` to `arrow-buffer`
mbrobbel opened a new pull request, #4630:
URL: https://github.com/apache/arrow-rs/pull/4630
# Which issue does this PR close?
None.
# Rationale for this change
`BufferBuilder` builds buffers, so it makes sense to move it to the `arrow-buffer` crate. It also only requires types from that crate.
# What changes are included in this PR?
Moved `BufferBuilder` from `arrow_array::builder` to `arrow_buffer::builder`. Add re-export in `arrow_array::builder` to prevent a breaking change.
# Are there any user-facing changes?
Yes, `BufferBuilder` is now available to users of the `arrrow-buffer` crate.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] mbrobbel commented on pull request #4630: Move `BufferBuilder` to `arrow-buffer`
Posted by "mbrobbel (via GitHub)" <gi...@apache.org>.
mbrobbel commented on PR #4630:
URL: https://github.com/apache/arrow-rs/pull/4630#issuecomment-1662218481
> Could I possibly inquire as to your use-case?
I'm working on [an Arrow implementation](https://github.com/mbrobbel/narrow) for use-cases where array schemas are known at compile time. This allows [deriving](https://github.com/mbrobbel/narrow/blob/main/tests/derive.rs) statically typed arrays for Rust types that provide efficient array-of-structs to struct-of-arrays conversion - and vice versa.
> Is there some reason you wish to stick with using BufferBuilder and MutableBuffer?
No. The arrays are generic over their inner buffer types, so to provide interop with `arrow-rs` buffers they need to implement some traits to make using them as buffers for these arrays possible. The next step is interop with `arrow-array` to allow zero-copy conversion to the array types of the `arrow-array` crate.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] mbrobbel commented on pull request #4630: Move `BufferBuilder` to `arrow-buffer`
Posted by "mbrobbel (via GitHub)" <gi...@apache.org>.
mbrobbel commented on PR #4630:
URL: https://github.com/apache/arrow-rs/pull/4630#issuecomment-1662143753
Makes sense. Until then, I'm probably going to do some follow-up PRs for additional trait implementations for this builder.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] tustvold commented on pull request #4630: Move `BufferBuilder` to `arrow-buffer`
Posted by "tustvold (via GitHub)" <gi...@apache.org>.
tustvold commented on PR #4630:
URL: https://github.com/apache/arrow-rs/pull/4630#issuecomment-1662154699
> I'm probably going to do some follow-up PRs for additional trait implementations for this builder
Could I possibly inquire as to your use-case? Is there some reason you wish to stick with using BufferBuilder and MutableBuffer?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org