[jira] Resolved: (PORTLETBRIDGE-89) ExternalContext.encodeActionURL incorrectly encodes invalid portletMode

["Michael Freedman (JIRA)" <de...@myfaces.apache.org>]

     [ https://issues.apache.org/jira/browse/PORTLETBRIDGE-89?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Michael Freedman resolved PORTLETBRIDGE-89.
-------------------------------------------

       Resolution: Fixed
    Fix Version/s: 2.0.0
                   1.0.0

> ExternalContext.encodeActionURL incorrectly encodes invalid portletMode
> -----------------------------------------------------------------------
>
>                 Key: PORTLETBRIDGE-89
>                 URL: https://issues.apache.org/jira/browse/PORTLETBRIDGE-89
>             Project: MyFaces Portlet Bridge
>          Issue Type: Bug
>    Affects Versions: 1.0.0-beta, 2.0.0-alpha
>            Reporter: Michael Freedman
>            Assignee: Michael Freedman
>             Fix For: 1.0.0, 2.0.0
>
>
> During encodeActionURL the JSF target that the bridge encodes is prepended with the URLs mode so we can ensure that the subsequent request is both for this page and the expected mode.  However if the url passed to encodeActionURL contains a new portlet mode that is invalid we still encode it in the target (prefix) but not in the resulting actionResponse/render generated URL.  Thus when submitted, the link fails because the requested mode doesn't match the bridge encoded target mode.  Fix by not using/prepending the mode in the encoded target if its invalid (instead encode with current mode).  This fix belongs in encodeFacesActionTarget.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.