[GitHub] [dubbo-go] AlexStocks commented on a diff in pull request #2304: add: tag route static config

["AlexStocks (via GitHub)" <gi...@apache.org>]

AlexStocks commented on code in PR #2304:
URL: https://github.com/apache/dubbo-go/pull/2304#discussion_r1170734924


##########
config_center/zookeeper/impl.go:
##########
@@ -103,6 +103,7 @@ func newZookeeperDynamicConfiguration(url *common.URL) (*zookeeperDynamicConfigu
 // AddListener add listener for key
 // TODO this method should has a parameter 'group', and it does not now, so we should concat group and key with '/' manually
 func (c *zookeeperDynamicConfiguration) AddListener(key string, listener config_center.ConfigurationListener, options ...config_center.Option) {
+	key = c.GetURL().GetParam(constant.ConfigNamespaceKey, config_center.DefaultGroup) + "/" + key

Review Comment:
   字符串拼接，使用 strings.Join()，不要用 + 号



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org