You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by "Stamatis Zampetakis (Jira)" <ji...@apache.org> on 2022/10/12 13:51:00 UTC
[jira] [Created] (HIVE-26627) Remove HiveRelBuilder.aggregateCall override and refactor callers to use existing public methods
Stamatis Zampetakis created HIVE-26627:
------------------------------------------
Summary: Remove HiveRelBuilder.aggregateCall override and refactor callers to use existing public methods
Key: HIVE-26627
URL: https://issues.apache.org/jira/browse/HIVE-26627
Project: Hive
Issue Type: Task
Components: CBO
Reporter: Stamatis Zampetakis
Assignee: Stamatis Zampetakis
The HiveRelBuilder overrides [aggregateCall|https://github.com/apache/hive/blob/8c3567ea8e423b202cde370f4d3fb401bcc23e46/ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/HiveRelBuilder.java#L246] from its superclass simply to expose and use it in HiveRewriteToDataSketchesRules.
However, there is no real need to override this method since we can achieve the same outcome by using existing methods in RelBuilder which are easier to use and understand. Furthermore it is safer to depend on public APIs since are more stable in general.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)