[GitHub] keith-turner commented on a change in pull request #848: Remove unused declarations

[GitBox <gi...@apache.org>]

keith-turner commented on a change in pull request #848: Remove unused declarations
URL: https://github.com/apache/accumulo/pull/848#discussion_r243341794
 
 

 ##########
 File path: core/src/main/java/org/apache/accumulo/core/client/summary/CountingSummarizer.java
 ##########
 @@ -179,7 +179,7 @@ private void init(SummarizerConfiguration conf) {
      * @param consumer
      *          emit counter objects derived from key and value to this consumer
      */
-    void convert(Key k, Value v, Consumer<K> consumer);
 
 Review comment:
   This should not be removed.   The intent of this is to allow user to count arbitrary things about key/values.  The currently included impls only happen to count things about keys.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services