You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@griffin.apache.org by toyboxman <gi...@git.apache.org> on 2018/07/05 01:46:42 UTC

[GitHub] incubator-griffin pull request #335: fix a bad practice

GitHub user toyboxman opened a pull request:

    https://github.com/apache/incubator-griffin/pull/335

    fix a bad practice

    1.Format string should use %n rather than \n
    In format strings, it is generally preferable better to use %n,
    which will produce the platform-specific line separator.
    
    2.use System.lineSeparator() instead of '\n'
    
    3.trim up some extra long code lines

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/toyboxman/incubator-griffin bug-1

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-griffin/pull/335.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #335
    
----
commit 0d53fb80df3621dd61488a69d7b1f5864419cf5b
Author: Eugene <to...@...>
Date:   2018-07-02T08:22:46Z

    fix a bad practice
    
    1.Format string should use %n rather than \n
    In format strings, it is generally preferable better to use %n,
    which will produce the platform-specific line separator.
    
    2.use System.lineSeparator() instead of '\n'
    
    3.trim up some extra long code lines

----


---

[GitHub] incubator-griffin pull request #335: fix a bad practice

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/incubator-griffin/pull/335


---